Closed Bug 1047283 Opened 10 years ago Closed 10 years ago

[Calendar] Drawer /Add event/ Display event should not play scrolling animation

Categories

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Calendar
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
2.1 S7 (24Oct)

People

(Reporter: harly, Assigned: evanxd)

References

Details

(Whiteboard: [p=3])

Attachments

(2 files)

https://github.com/mozilla-b2g/gaia/pull/25264
46 bytes, text/x-github-pull-request
harly
: ui-review+
Details | Review
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25264
46 bytes, text/x-github-pull-request
mmedeiros
: review+
Details | Review
When user opens a drawer or add a new event or tap on an event to display, after user finished and close the drawer or save/discard an event, going back to the day view should not play the auto scrolling animation.
Blocks: 1023663
No longer blocks: 1023663
Depends on: 1023663
Discussed with Harly in person, we only trigger the animation once we go to day view from month view, or click today and day item in day view.
Assignee: nobody → evanxd
Whiteboard: [p=1]
Target Milestone: --- → 2.1 S2 (15aug)
Target Milestone: 2.1 S2 (15aug) → 2.1 S3 (29aug)
Whiteboard: [p=1] → [p=3]
Let's move this out a bit. We can handle this in sprint 4 and reduce the number of landings in Calendar before FL.
Target Milestone: 2.1 S3 (29aug) → 2.1 S4 (12sep)
Sure, Dylan.
Target Milestone: 2.1 S4 (12sep) → 2.1 S5 (26sep)
Target Milestone: 2.1 S5 (26sep) → ---
Target Milestone: --- → 2.1 S5 (26sep)
Comment on attachment 8474332 [details] [review] https://github.com/mozilla-b2g/gaia/pull/25264 Hi Harly, Could you help to review the patch? Thanks.
Attachment #8474332 - Flags: ui-review?(hhsu)
Comment on attachment 8474332 [details] [review] https://github.com/mozilla-b2g/gaia/pull/25264 Nicely done, thanks Evan.
Attachment #8474332 - Flags: ui-review?(hhsu) → ui-review+
Target Milestone: 2.1 S5 (26sep) → 2.1 S6 (10oct)
Target Milestone: 2.1 S6 (10oct) → 2.1 S7 (24Oct)
Comment on attachment 8474332 [details] [review] https://github.com/mozilla-b2g/gaia/pull/25264 https://github.com/mozilla-b2g/gaia/pull/25264
Attachment #8474332 - Attachment description: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/19813 → https://github.com/mozilla-b2g/gaia/pull/25264
Comment on attachment 8506811 [details] [review] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25264 Hi Miller, Could you help to review the patch? I'll update the unit tests once the patch is on the right way. Thanks.
Attachment #8506811 - Flags: review?(mmedeiros)
Comment on attachment 8506811 [details] [review] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25264 new day view was just merged (Bug 1052960). this pull request can't be used anymore. sorry about that.
Attachment #8506811 - Flags: review?(mmedeiros) → review-
Comment on attachment 8506811 [details] [review] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25264 Hi Miller, I updated the patch. Please help to review it again. Thanks.
Attachment #8506811 - Flags: review- → review?(mmedeiros)
Blocks: 1071389
Hi Miller, I updated the patch. It fixes day view and week view. Please help to review it again. Thanks.
Flags: needinfo?(mmedeiros)
added comment to GH, implementation is still more complex than needed.
Flags: needinfo?(mmedeiros)
Updated the patch. Miller, please help to review it. Thanks.
Flags: needinfo?(mmedeiros)
Comment on attachment 8506811 [details] [review] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25264 way cleaner! just missing any kind of test (unit or marionette) to confirm the behavior and avoid regressions! thx!
Flags: needinfo?(mmedeiros)
Sure, I'm adding the tests. (Just want to add tests after the patch is good.)
Miller, added tests. Please help to review the patch. Thanks.
Flags: needinfo?(mmedeiros)
Comment on attachment 8506811 [details] [review] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25264 LGTM! thanks!
Flags: needinfo?(mmedeiros)
Attachment #8506811 - Flags: review?(mmedeiros) → review+
Miller, thanks for the review.
master: https://github.com/mozilla-b2g/gaia/commit/36c9d97497c22397b54ede75277863f5aa96e132
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
[Environment] Gaia-Rev 0dfc1996eb583c8b507a82bf6b8319624bba23ea Gecko-Rev https://hg.mozilla.org/mozilla-central/rev/80e18ff7c7b2 Build-ID 20141029160202 Version 36.0a1 Device-Name flame FW-Release 4.4.2 FW-Incremental 39 FW-Date Thu Oct 16 18:19:14 CST 2014 Bootloader L1TC00011880 [Result] PASS
Status: RESOLVED → VERIFIED
See Also: → 1121873
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: