104818 - "Sent later" mails not removed from "Drafts".

Status: RESOLVED DUPLICATE of bug 314009

(MailNews Core :: Backend, defect)

Description

[石庭豐 (Seak, Teng-Fong)]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:0.9.4+)
Gecko/20010925
BuildID:    20010925

Compose a new message.  Write something, save it.  Write again some other things
and "sent it later".  Now we can still find the message in the Drafts folder and
of course it's in the saved state.

Reproducible: Always

PS: Actually, my Mozilla is offline so the "Send" icon is "Send later" icon.

Comment 1

[Dac Chartrand]

The reporting is not assessing the situation correctly. He or she is looking in
the wrong place.

If you write a message, click save ... Message will be saved in YourAccount/Saved/

If you continue the message, click send later ... Message will be saved in
LocalFolders/UnsentMessages/

Hense, this assessment is invalid.

Comment 2

[Dac Chartrand]

TYPO! 

YourAccount/Drafts/

Sorry.

Comment 3

[石庭豐 (Seak, Teng-Fong)]

I wasn't looking at the wrong place.  It's just that I wasn't saying all what I was
exactly thinking.

First, I was thinking: Sent or Sent Later, they are all "Send" and thus should
behave the same, ie, they should remove its draft.  But later on, I thought it
doesn't matter if "Send Later" doesn't remove the draft if a real "Send" does it.

However, I found that a "Send unsent message" doesn't remove drafts either.  So
I made this bug report.

Comment 4

[Boris 'pi' Piwinger]

Reporter, could this be a dupe of bug 141209?

If not: Do you still see it in a recent version?

pi

Comment 5

[石庭豐 (Seak, Teng-Fong)]

Nope, this bug isn't dupe of bug 141209. However, I do observe the behaviour in
that bug.
With 20020523 (Mozilla 1.0 RC3), the bug is still there.

Comment 6

[Arno Roefs]

User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.0.0) Gecko/20020530
Build: 2002053012

1. Compose mail, Save mail, message is now in Drafts.
2. Select "Send mail later" in the compose window, message is now in Drafts &
unsent mail.
3. Enter Drafts, select "Send now".
4. Message gone from Drafts, but still in "unsent mail"

Seems like a bug to me...

Comment 7

[石庭豐 (Seak, Teng-Fong)]

In step 4, are you sure it's not the other way round?  That is, message gone
from "Unsent Mail", but still in "Drafts".

And yup, it IS a bug. Once a draft is "sent later", Mozilla doesn't keep track
of the draft, and when the mail is sent afterwards, the draft left behind.

Comment 8

[Boris 'pi' Piwinger]

Arno's description sound like a consequence of bug 141209.

pi

Comment 9

[Phil Jones]

I have seen the same problem. Specifically:

1. Compose a new message
2. Save it
3. Message is now in Drafts
4. Edit the draft message
5. Send Later
6. Message is now in Unsent Messages and still in Drafts.

I've tried this with Mozilla 1.7a compiled from CVS source. In
mozilla/mailnews/compose/src/nsMsgCompose.cpp on line 2841 it says:

// Remove the current draft msg when sending draft is done.
      MSG_ComposeType compType = nsIMsgCompType::Draft;
      compose->GetType(&compType);
      if (compType == nsIMsgCompType::Draft)
        RemoveCurrentDraftMessage(compose, PR_FALSE);

So that looks great, that explains why it removes the current draft 
message when doing Send Now.

But I can't see any code to remove the current draft msg when
doing Send Later. It seems like a simple programming oversight
to me. The nearest I can find in this file is on line 2914:

    if (mDeliverMode == nsIMsgSend::nsMsgQueueForLater)
      compose->RememberQueuedDisposition();

Perhaps a workable patch would be:

    if (mDeliverMode == nsIMsgSend::nsMsgQueueForLater) {
+      compose->RememberQueuedDisposition();
+      compose->GetType(&compType);
+      if (compType == nsIMsgCompType::Draft)
+        RemoveCurrentDraftMessage(compose, PR_FALSE);
+   }

This should cause Send Later to check to see if the message was 
composed as a draft, and if so then it should remove the current 
draft message. Would this be acceptable?

Phil

Comment 10

[Phil Jones]

Attachment: Remove the current draft when doing "Send Later".

Create a msg. Save it. Go into Drafts. Edit Draft. Send Later. With the patch,
the draft being edited is removed and the completed msg goes to Unsent
Messages. This is my first patch!

Comment 11

[OstGote!]

see similiar Bug 216060

Comment 12

[Mike Cowperthwaite]

*** Bug 271998 has been marked as a duplicate of this bug. ***

Comment 13

[Mike Cowperthwaite]

Phil Jones, you'd better find a different reviewer for your patch; Seth 
apparently uses Bugzilla as a write-only data store.  Does the patch still build 
with current code or does it need updating?

Comment 14

[Miguel]

Still there in Thunderbird 1.0.6

Comment 15

[Adam Guthrie]

*** Bug 304942 has been marked as a duplicate of this bug. ***

Comment 16

[Andrew Brown]

Still a bug in TBird v1.5 (20051201) on MacOSX.
I do -not- observe bug #141209 anymore, so I see no relation.

Comment 17

[Phil Jones]

This patch fixes it. Tested successfully with Mozilla 1.7.13.

RCS file: /cvsroot/mozilla/mailnews/compose/src/nsMsgCompose.cpp,v
retrieving revision 1.423.2.6
diff -r1.423.2.6 nsMsgCompose.cpp
2955,2956c2955,2961
<     if (mDeliverMode == nsIMsgSend::nsMsgQueueForLater)
<       compose->RememberQueuedDisposition();
---
>     if (mDeliverMode == nsIMsgSend::nsMsgQueueForLater) {
>           compose->RememberQueuedDisposition();
>           MSG_ComposeType compType = nsIMsgCompType::Draft;
>           compose->GetType(&compType);
>           if (compType == nsIMsgCompType::Draft)
>                   RemoveCurrentDraftMessage(compose, PR_FALSE);
>     }

Comment 18

[Andrew Brown]

I believe this is fixed with bug 314009

Comment 19

[Magnus Melin [:mkmelin]]

Yes, this was fixed ing bug 314009.

Comment 20

[Magnus Melin [:mkmelin]]

Comment on attachment 141504 [details] [diff] [review]
Remove the current draft when doing "Send Later".

issue fixed in bug 314009. marking patch obsolete