1048711 - [settings] Device specific strings are displayed in English

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Francesco Lodolo [:flod]]

Attachment: Screenshot on flame

Not verified the regression range, but I assume it's a regression from bug 1043615.

Only the main message (turn-on-ums-confirm) is not localized

Comment 1

[Francesco Lodolo [:flod]]

Screenshot is taken with
Gaia      6badeb901727bb85d558a88a3dd86bed74cf67de
Gecko     https://hg.mozilla.org/mozilla-central/rev/6551323d96e6
BuildID   20140801160217
Version   34.0a1
ro.build.version.incremental=110
ro.build.date=Fri Jun 27 15:57:58 CST 2014

I tried to flash the commit before that but it's still broken
Gaia      b0e7882a1e524960f59f8bc02eba8be8cab068ab
Gecko     https://hg.mozilla.org/mozilla-central/rev/6551323d96e6

So it's not depending on bug 1043615.

Comment 2

[Francesco Lodolo [:flod]]

(In reply to Francesco Lodolo [:flod] from comment #1)
> I tried to flash the commit before that but it's still broken
> Gaia      b0e7882a1e524960f59f8bc02eba8be8cab068ab
> Gecko     https://hg.mozilla.org/mozilla-central/rev/6551323d96e6
> 
> So it's not depending on bug 1043615.

This is not useful. I forgot that bug 944604 removed those strings from the main settings properties file, and moved them to device specific files, so what I was seeing was "missing strings in locale, fall back to English".

I'm seeing an English string in:
* bluetooth: rename device
* data connection sharing: HotSpot Wi-Fi description is in English, but the USB tethering description is correctly localized.
* USB storage 1st activation warning
* Find My Device strings are correctly localized.
* Reset device in Info is not localized.

Comment 3

[Francesco Lodolo [:flod]]

Not sure what changed, but now I get all the strings from bug 944604 in English.

I even pulled with adb application.zip for settings, and checked locales-obj/it.json: strings are in English even if they're available in my locales/it repository when running the build.

The command I use to build Gaia is

make clean && PRODUCTION=1 make install-gaia MAKECMDGOALS=production MOZILLA_OFFICIAL=1 GAIA_KEYBOARD_LAYOUTS=en,it LOCALES_FILE=locales/languages_all.json LOCALE_BASEDIR=locales/ DEVICE_DEBUG=1

Comment 4

[Francesco Lodolo [:flod]]

Sherman, any idea of what's happening here? It looks like a build problem, given that the strings are not moved into the .json file

Comment 5

[Sherman Chen [:chens] (inactive)]

I think it might be path related issue, will follow steps in comment 3 with and without patch from bug 944604 to see what's happening.
Do I have to download additional locales to gaia folder to proceed?

Comment 6

[Théo Chevalier]

(In reply to Sherman Chen [:chens] from comment #5)
> I think it might be path related issue, will follow steps in comment 3 with
> and without patch from bug 944604 to see what's happening.
> Do I have to download additional locales to gaia folder to proceed?

You can clone French and/or Italian into your gaia/locales folder to test if it's easier for you:
hg clone https://hg.mozilla.org/gaia-l10n/it
hg clone https://hg.mozilla.org/gaia-l10n/fr

Both locales have localized strings for settings/device_type/* files

Comment 7

[Sherman Chen [:chens] (inactive)]

Attachment: Pull request

Comment 8

[Sherman Chen [:chens] (inactive)]

Thanks for the heads-up, and here's the step I did to reproduce.
1. clone Italian locales into gaia/locales
2. create another locales file languagues_test.json, contains English and Italian.
3. issue command |make clean && LOCALES_FILE=locales/languages_test.json LOCALE_BASEDIR=locales DEVICE_DEBUG=1 make install-gaia|

And I think this patch could solve this issue.

Comment 9

[Francesco Lodolo [:flod]]

Comment on attachment 8469029 [details] [review]
Pull request

I'm not familiar with the build system, but I'm definitely seeing localized strings with this patch applied.

Comment 10

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8469029 [details] [review]
Pull request

looks good, some suggesions:
1. Gb is failed, please take a look
2. add comment for line 142~154 in multilocale.js to explain why we do this.

Comment 11

[Sherman Chen [:chens] (inactive)]

Comment on attachment 8469029 [details] [review]
Pull request

Gaia-try: https://tbpl.mozilla.org/?rev=608db10e19895a5bcd3f5d8bb9f5c25d46e8d800&tree=Gaia-Try

Comment 12

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8469029 [details] [review]
Pull request

looks good and please file follow-up bug for testing device specific locale files.

Comment 13

[Sherman Chen [:chens] (inactive)]

Merged to master: 
https://github.com/mozilla-b2g/gaia/commit/a5dbea45ee75321330573ecb4262a5f6f69173b2

Comment 14

[Théo Chevalier]

Sorry, but looks like I still have the issue in French with the following build, which include the landed fix:

Gaia      9f35fca9d818b26c06aa6b7e5c0bef25886f8f20
Gecko     https://hg.mozilla.org/mozilla-central/rev/7fc96293ada8
BuildID   20140812160208
Version   34.0a1
ro.build.version.incremental=110
ro.build.date=Fri Jun 27 15:57:58 CST 2014
B1TC00011230

I guess we should file a follow up?

Comment 15

[Sherman Chen [:chens] (inactive)]

I suppose the issue you found should be in bluetooth.

In bug 1032071, bluetooth had also moved some device specific strings under device_type folder, and there should be corresponding changes in l10n.

We can also found a file not found warning in build output - [multilocale] Properties file not found: gaia/locales/fr/apps/bluetooth/device_type/phone/bluetooth.device.properties

Comment 16

[Théo Chevalier]

(In reply to Sherman Chen [:chens] from comment #15)
> I suppose the issue you found should be in bluetooth.
> 
> In bug 1032071, bluetooth had also moved some device specific strings under
> device_type folder, and there should be corresponding changes in l10n.
> 
> We can also found a file not found warning in build output - [multilocale]
> Properties file not found:
> gaia/locales/fr/apps/bluetooth/device_type/phone/bluetooth.device.properties


Not only. I do see this Bluetooth string in English, indeed:
apps/settings/device_type/phone/settings.device.properties:change-device-name

But in Settings I also see at least those strings displayed in English:
apps/settings/device_type/phone/settings.device.properties:performanceAndUsageDataInfo
apps/settings/device_type/phone/settings.device.properties:reset-device

Comment 17

[Sherman Chen [:chens] (inactive)]

I found performanceAndUsageDataInfo and reset-device are display in correct languages if you build gaia by yourself, it can simply be verified by following steps in comment 8.

But I can reproduce the issue you have by flashing gecko+gaia from pvt build, so maybe things went wrong in pvt build and not having the right locales to display.

Comment 18

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

In Settings,
internetSharing-usb-desc = Share my phone’s Internet connection with a USB-connected device.
is also shown in English (2.1.0.0-pre 20140818 on Geeksphone Keon).