Page markup for the watch notification message differs between dev and staging/prod

NEW
Unassigned

Status

Websites
wiki.mozilla.org
3 years ago
3 years ago

People

(Reporter: bsilverberg, Unassigned)

Tracking

(Depends on: 1 bug)

Details

(Whiteboard: [fromAutomation], URL)

(Reporter)

Description

3 years ago
One of our automated tests for the wiki has started failing when run against dev [1] because the markup differs between dev and stage [2] for the message that is displayed when watching and unwatching a page. Perhaps this difference stems from the two sites running different versions of MediaWiki? I would like to resolve this issue and get the test passing on both dev and staging again, but I am not sure how to best address it.

Is it expected that stage will be updated to have similar behaviour to dev in the near future?

[1] https://wiki-dev.allizom.org/
[2] https://wiki.allizom.org/
(Reporter)

Comment 1

3 years ago
The same question stands for prod as well, as we run our tests on all three environments.
(Reporter)

Updated

3 years ago
Summary: Page markup for the watch notification message differs between dev and staging → Page markup for the watch notification message differs between dev and staging/prod
(Reporter)

Comment 2

3 years ago
For future reference, the change that needs to be made to support the markup on dev is in /pages/watch_page.py and is:

-    _watchlist_message_locator = (By.CSS_SELECTOR, 'div.mw-js-message-ajaxwatch > p')
+    _watchlist_message_locator = (By.CSS_SELECTOR, 'div.mw-notification-tag-watch-self')

Updated

3 years ago
OS: Mac OS X → All
Hardware: x86 → All
We're in the middle of upgrading Mozilla Wiki to the most current version of Mediawiki (1.23 branch). Dev has been updated to 1.23 and we're testing it now. Stage and production will be made to match Dev once we've completed upgrading and testing Dev. 

Also note that as part of this upgrade, we'll be changing the default theme of the wiki to Vector (from GMO). This might change some of the rendered css which might affect your tests.
Depends on: 1032351
(Reporter)

Comment 4

3 years ago
Thanks for the update :ckoehler :)

I will leave this bug open as a reminder to update the test when the changes make it to staging and production.
No longer depends on: 1032351
Depends on: 1058914
You need to log in before you can comment on or make changes to this bug.