1049325 - [Firefox OS] Last frame of video playback is not shown in PlatformDecoderModule

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Blake Wu [:bwu][:blakewu]]

FFOS's MP4 PlatformDecoderModule (bug 941302) doesn't handle EOS well. The Last frame of video playback is not shown.
Need to notify MediaCodec when there is no input frames any more and let codec push all the rest decoded frames out.  

Testing contnet: http://people.mozilla.org/~cpearce/avatar.mp4 (Thanks for cpearce's info)

Comment 1

[Eric Chou [:ericchou] [:echou]]

Set to feat 2.1+ since it blocks 2.1 feat+ issue (bug 1027519).

Comment 2

[Kai-Chih Hu [:khu]]

Codec indeed had this output(the last frame). But, it's handled in upper layer. Still working on it.

Comment 3

[Blake Wu [:bwu][:blakewu]]

Attachment: Bug-1049325-Part1-Notify-decoder-for-input-EOS-and-report-MP4Reader-EOS.patch

Notify decoder input EOS by inputting a null data and report MP4Reader output EOS (DrainComplete) when getting the last frame (EOS) from decoder.

Comment 4

[Blake Wu [:bwu][:blakewu]]

Attachment: Bug-1049325-Part2-Notify-MediaCodec-input-EOS-and-report-EOS.patch

Notify MediaCodec EOS when input data is null and return EOS error when getting the EOS flag from MediaCodec.

Comment 5

[Kai-Chih Hu [:khu]]

Based on the discussion with the partner, agreed to remove the feature-b2g flag on this.

Comment 6

[Edwin Flores [inactive from 2016-12-01] [:eflores] [:edwin]]

Comment on attachment 8475657 [details] [diff] [review]
Bug-1049325-Part2-Notify-MediaCodec-input-EOS-and-report-EOS.patch

Review of attachment 8475657 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/media/omx/MediaCodecProxy.cpp
@@ +479,5 @@
>    metaData->setInt64(kKeyTime, timeUs);
>    buffer->set_range(buffer->range_offset(), size);
>    *aBuffer = buffer;
> +  if (flags & MediaCodec::BUFFER_FLAG_EOS) {
> +    return MediaCodec::BUFFER_FLAG_EOS;

Should this be returning |ERROR_END_OF_STREAM|?

Comment 7

[Blake Wu [:bwu][:blakewu]]

(In reply to Edwin Flores [:eflores] [:edwin] from comment #6)
> Comment on attachment 8475657 [details] [diff] [review]
> Bug-1049325-Part2-Notify-MediaCodec-input-EOS-and-report-EOS.patch
> 
> Review of attachment 8475657 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: content/media/omx/MediaCodecProxy.cpp
> @@ +479,5 @@
> >    metaData->setInt64(kKeyTime, timeUs);
> >    buffer->set_range(buffer->range_offset(), size);
> >    *aBuffer = buffer;
> > +  if (flags & MediaCodec::BUFFER_FLAG_EOS) {
> > +    return MediaCodec::BUFFER_FLAG_EOS;
> 
> Should this be returning |ERROR_END_OF_STREAM|?
Yes. Returning ERROR_END_OF_STREAM should be better since it is a more generic error code for EOS. I will change it.  
Thanks for the suggestion!

Comment 8

[Blake Wu [:bwu][:blakewu]]

Attachment: Bug-1049325-Part1-Notify-decoder-for-input-EOS-and-report-MP4Reader-EOS-Final.patch

Carry r+ from cpeare and have the corresponding minor change for comment 6.

Comment 9

[Blake Wu [:bwu][:blakewu]]

Attachment: Bug-1049325-Part2-Notify-MediaCodec-input-EOS-and-report-EOS-Final.patch

Carry r+ from edwin and have a small change per comment 6.

Comment 10

[Blake Wu [:bwu][:blakewu]]

TBPL: https://tbpl.mozilla.org/?tree=Try&rev=8bdc6736adfb

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a99f1ae04b4c
https://hg.mozilla.org/integration/mozilla-inbound/rev/2400a27d2bf1

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a99f1ae04b4c
https://hg.mozilla.org/mozilla-central/rev/2400a27d2bf1