[NFC] Marionette test_nfc_peer.js testPeerShouldThrow should be fixed

RESOLVED FIXED in 2.1 S2 (15aug)

Status

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: tauzen, Unassigned)

Tracking

unspecified
2.1 S2 (15aug)
ARM
Gonk (Firefox OS)
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [p=3])

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
testPeerShouldThrow needs some fixing:
1. url used here [1] is not defined and causes test to fail
2. After defining url test crashes emulator-jb

[1] https://mxr.mozilla.org/mozilla-central/source/dom/nfc/tests/marionette/test_nfc_peer.js#119
(Reporter)

Updated

4 years ago
Blocks: 860906
Depends on: 1043186
(Assignee)

Updated

4 years ago
Assignee: nobody → allstars.chh
There are more complicated things in this bug, two tests (say A,B) set 'nfc-manager-tech-discovered' handler, however not reset it, so when another test (C) calls enableRE, the handler in A/B will be called. I'll try to write a helper for listening tech-discovered/lost events.
Created attachment 8470666 [details] [diff] [review]
Patch.
Attachment #8470666 - Flags: review?(dlee)

Updated

4 years ago
Attachment #8470666 - Flags: review?(dlee) → review+
https://hg.mozilla.org/integration/b2g-inbound/rev/7b48db9643e7
Whiteboard: [p=3]
Target Milestone: --- → 2.1 S2 (15aug)
https://hg.mozilla.org/mozilla-central/rev/7b48db9643e7
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Flags: in-testsuite+
Resolution: --- → FIXED

Updated

4 years ago
Depends on: 1054298
You need to log in before you can comment on or make changes to this bug.