Closed
Bug 1049351
Opened 11 years ago
Closed 11 years ago
[NFC] Marionette test_nfc_peer.js testPeerShouldThrow should be fixed
Categories
(Firefox OS Graveyard :: NFC, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.1 S2 (15aug)
People
(Reporter: tauzen, Assigned: allstars.chh)
References
Details
(Whiteboard: [p=3])
Attachments
(1 file)
|
20.03 KB,
patch
|
dimi
:
review+
|
Details | Diff | Splinter Review |
testPeerShouldThrow needs some fixing:
1. url used here [1] is not defined and causes test to fail
2. After defining url test crashes emulator-jb
[1] https://mxr.mozilla.org/mozilla-central/source/dom/nfc/tests/marionette/test_nfc_peer.js#119
|
Reporter | |
Updated•11 years ago
|
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → allstars.chh
|
|
Assignee | |
Comment 1•11 years ago
|
||
There are more complicated things in this bug, two tests (say A,B) set 'nfc-manager-tech-discovered' handler, however not reset it, so when another test (C) calls enableRE, the handler in A/B will be called. I'll try to write a helper for listening tech-discovered/lost events.
|
|
Assignee | |
Comment 2•11 years ago
|
||
Attachment #8470666 -
Flags: review?(dlee)
|
||
Updated•11 years ago
|
Attachment #8470666 -
Flags: review?(dlee) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
Whiteboard: [p=3]
Target Milestone: --- → 2.1 S2 (15aug)
|
||
Comment 4•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•