Closed Bug 105061 Opened 23 years ago Closed 23 years ago

Mac: shifted keybindings don't work

Categories

(Core :: DOM: UI Events & Focus Handling, defect)

PowerPC
Mac System 9.x
defect
Not set
critical

Tracking

()

VERIFIED FIXED
mozilla0.9.7

People

(Reporter: Brade, Assigned: saari)

References

Details

(Keywords: access, platform-parity, regression)

Attachments

(1 file)

With a Macintosh debug build from yesterday on the trunk, I noticed that these 
keybindings don't work:
  New Composer Page (Command-Shift-N)
  Open Location (Command-Shift-L)
  Redo (Command-Shift-Z -- Macintosh only)

Is this cross-platform?  Is this broken on the branch?
Reporter: Did you have CAPSLOCK on (if Macs have these)? There is a bug about
keybindings and caps (sorry, don't recall the specific bugnumber).

Note: Shifted keybindings work with Linux Build-ID 2001101513
caps lock is not set
--> saari
Assignee: hyatt → saari
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.9
*** Bug 106156 has been marked as a duplicate of this bug. ***
this is not a problem on the branch, and appears limited to Mac 9.x and 10.x.

nominating for mozilla0.9.6, as this is a rather serious regression, imho.

saari, any idea what would've caused this?
Severity: major → critical
Component: XP Toolkit/Widgets → Keyboard Navigation
QA Contact: jrgm → sairuh
Summary: shifted keybindings don't work → Mac: shifted keybindings don't work
oddly, i haven't noticed this until the 2001.10.22.13-trunk commercial verif
bits on 10.1.

tried to narrow down when this bug started, but couldn't get a narrower range
than sometime btwn the 2001.10.19.05-trunk [on 10.1, when it worked fine] and
2001.10.22.13-trunk [when it's broken for me]. unfortunately, the builds btwn
those dates are either non-existent or horribly broken [checked on both sweetlou
and the mozilla ftp site, both 10.x and 9.x bits].
Hrm, went over the bonsai logs for that time period, and I didn't see anything 
obvious, but there were a great many candidates. I think it will be faster to 
just debug it. Pulling in to 0.9.7
Target Milestone: mozilla0.9.9 → mozilla0.9.7
*** Bug 108039 has been marked as a duplicate of this bug. ***
everything looks OK at the mac widget level, the key event is properly 
tagged as having the shift modifier. Must be something in the binding 
handling.
Are you sure that this bug is specific to shifted keybindings?

Command-W isn't working in Build 2001103008/MacOS, but it should close the
frontmost window. It's doing the same thing as the "shifted keybindings". That
is, it doesn't do anything.
Mozilla is also having trouble handling shift in menus. See bug 108348.

See also bug 83891 which is similar to the problem described here.
*** Bug 107906 has been marked as a duplicate of this bug. ***
*** Bug 111468 has been marked as a duplicate of this bug. ***
Comment on attachment 59239 [details] [diff] [review]
make sure the unicode key event dipatch generates uppercase keycodes properly

r=brade
Is it possible to get a QA person to do some quick testing on this to ensure no
huge regressions for unicode input?
Attachment #59239 - Flags: review+
oops; I thought I mentioned this earlier but I don't see the comment here...

Be sure to remove tabs from the patch! :-)
sorry, kathy, i don't have a build system setup for either mac 9.x or 10.x. :-/
r=ftang. sorry to cause that problem. I should buy lunch for brade and saari.
*** Bug 112481 has been marked as a duplicate of this bug. ***
*** Bug 112497 has been marked as a duplicate of this bug. ***
simon, could you sr this? thx!
Comment on attachment 59239 [details] [diff] [review]
make sure the unicode key event dipatch generates uppercase keycodes properly

Fix the whacky spacing, and sr=sfraser
Attachment #59239 - Flags: superreview+
hiya saari, could your patch be checked in now? thx!
fixed
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Verified on Mac OS 9.1 using build 2001121304.
Status: RESOLVED → VERIFIED
...and on os 10.1.1 [2001.12.20.04].
Component: Keyboard: Navigation → User events and focus handling
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: