105061 - Mac: shifted keybindings don't work

Status: VERIFIED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Kathleen :Brade]

With a Macintosh debug build from yesterday on the trunk, I noticed that these 
keybindings don't work:
  New Composer Page (Command-Shift-N)
  Open Location (Command-Shift-L)
  Redo (Command-Shift-Z -- Macintosh only)

Is this cross-platform?  Is this broken on the branch?

Comment 1

[Olav Vitters]

Reporter: Did you have CAPSLOCK on (if Macs have these)? There is a bug about
keybindings and caps (sorry, don't recall the specific bugnumber).

Note: Shifted keybindings work with Linux Build-ID 2001101513

Comment 2

[Kathleen :Brade]

caps lock is not set

Comment 3

[David Hyatt]

--> saari

Comment 4

[sairuh (rarely reading bugmail)]

*** Bug 106156 has been marked as a duplicate of this bug. ***

Comment 5

[sairuh (rarely reading bugmail)]

this is not a problem on the branch, and appears limited to Mac 9.x and 10.x.

nominating for mozilla0.9.6, as this is a rather serious regression, imho.

saari, any idea what would've caused this?

Comment 6

[sairuh (rarely reading bugmail)]

oddly, i haven't noticed this until the 2001.10.22.13-trunk commercial verif
bits on 10.1.

tried to narrow down when this bug started, but couldn't get a narrower range
than sometime btwn the 2001.10.19.05-trunk [on 10.1, when it worked fine] and
2001.10.22.13-trunk [when it's broken for me]. unfortunately, the builds btwn
those dates are either non-existent or horribly broken [checked on both sweetlou
and the mozilla ftp site, both 10.x and 9.x bits].

Comment 7

[saari (gone)]

Hrm, went over the bonsai logs for that time period, and I didn't see anything 
obvious, but there were a great many candidates. I think it will be faster to 
just debug it. Pulling in to 0.9.7

Comment 8

[sairuh (rarely reading bugmail)]

*** Bug 108039 has been marked as a duplicate of this bug. ***

Comment 9

[saari (gone)]

everything looks OK at the mac widget level, the key event is properly 
tagged as having the shift modifier. Must be something in the binding 
handling.

Comment 10

[seth]

Are you sure that this bug is specific to shifted keybindings?

Command-W isn't working in Build 2001103008/MacOS, but it should close the
frontmost window. It's doing the same thing as the "shifted keybindings". That
is, it doesn't do anything.

Comment 11

[J Luh]

Mozilla is also having trouble handling shift in menus. See bug 108348.

See also bug 83891 which is similar to the problem described here.

Comment 12

[joki (gone)]

*** Bug 107906 has been marked as a duplicate of this bug. ***

Comment 13

[R.K.Aa.]

*** Bug 111468 has been marked as a duplicate of this bug. ***

Comment 14

[saari (gone)]

Attachment: make sure the unicode key event dipatch generates uppercase keycodes properly

this should do it

Comment 15

[Kathleen :Brade]

Comment on attachment 59239 [details] [diff] [review]
make sure the unicode key event dipatch generates uppercase keycodes properly

r=brade
Is it possible to get a QA person to do some quick testing on this to ensure no
huge regressions for unicode input?

Comment 16

[Kathleen :Brade]

oops; I thought I mentioned this earlier but I don't see the comment here...

Be sure to remove tabs from the patch! :-)

Comment 17

[sairuh (rarely reading bugmail)]

sorry, kathy, i don't have a build system setup for either mac 9.x or 10.x. :-/

Comment 18

[Frank Tang]

r=ftang. sorry to cause that problem. I should buy lunch for brade and saari.

Comment 19

[Kathleen :Brade]

*** Bug 112481 has been marked as a duplicate of this bug. ***

Comment 20

[Kathleen :Brade]

*** Bug 112497 has been marked as a duplicate of this bug. ***

Comment 21

[sairuh (rarely reading bugmail)]

simon, could you sr this? thx!

Comment 22

[Simon Fraser [no longer active]]

Comment on attachment 59239 [details] [diff] [review]
make sure the unicode key event dipatch generates uppercase keycodes properly

Fix the whacky spacing, and sr=sfraser

Comment 23

[sairuh (rarely reading bugmail)]

hiya saari, could your patch be checked in now? thx!

Comment 24

[saari (gone)]

fixed

Comment 25

[michael wendell]

Verified on Mac OS 9.1 using build 2001121304.

Comment 26

[sairuh (rarely reading bugmail)]

...and on os 10.1.1 [2001.12.20.04].