1051795 - [CMAS] Handle the setting that enables/disables CMAS alerts

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Network Alerts, defect)

Description

[Julien Wajsberg [:julienw]]

In this bug, well handle the setting that enables and disabled CMAS alerts.

We'll also possibly need to disable CMAS alerts in the System app, in the existing Cell Broadcast subsyste.

Comment 1

[Kai-Chih Hu [:khu]]

Confirmed with EM/EPM, and this can be landed before FL.

Comment 2

[Steve Chung [:steveck]]

Attachment: Link to github

Hi Oleg, this should be the last CMAS feature in this sprint and I added the settings check and some other fixing. Thanks for all the efforts for CMAS feature :)

Comment 3

[Oleg Zasypkin [:azasypkin]]

Hey Steve,

In code everything looks great, but as I mentioned on Github, something has changed very recently and our "attention" screen is closed right after it was opened. If I haven't messed up with bessicting, looks like recently landed patch for Bug 927862 changed system behaviour

Comment 4

[Steve Chung [:steveck]]

(In reply to Oleg Zasypkin [:azasypkin] from comment #3)
> Hey Steve,
> 
> In code everything looks great, but as I mentioned on Github, something has
> changed very recently and our "attention" screen is closed right after it
> was opened. If I haven't messed up with bessicting, looks like recently
> landed patch for Bug 927862 changed system behaviour

Yeah I think it's because of Bug 927862 changes... 

Anyway I updated the patch per your comments, and I also changed the behvior here that don't close the window while attention screen show up, but close parent window while confirm button submitted.

Comment 5

[Oleg Zasypkin [:azasypkin]]

(In reply to Steve Chung [:steveck] from comment #4)
> (In reply to Oleg Zasypkin [:azasypkin] from comment #3)
> > Hey Steve,
> > 
> > In code everything looks great, but as I mentioned on Github, something has
> > changed very recently and our "attention" screen is closed right after it
> > was opened. If I haven't messed up with bessicting, looks like recently
> > landed patch for Bug 927862 changed system behaviour
> 
> Yeah I think it's because of Bug 927862 changes... 
> 
> Anyway I updated the patch per your comments, and I also changed the behvior
> here that don't close the window while attention screen show up, but close
> parent window while confirm button submitted.

Thanks a lot Steve, looking into it right now!

Comment 6

[Oleg Zasypkin [:azasypkin]]

Comment on attachment 8481160 [details] [review]
Link to github

Now it's great, r=me! I've left small comment on Github about the case when window.opener can be null.

Thanks for the all efforts!

Comment 7

[Steve Chung [:steveck]]

Thanks for the review! Some js integration error here but not relate to this app...
in master : eb34271edb00469d91d81e4398749632e97dd0b6