Closed
Bug 1052795
Opened 10 years ago
Closed 6 years ago
[Callscreen] Customize Status Bar Color
Categories
(Firefox OS Graveyard :: Gaia::Dialer, defect)
Tracking
(b2g-v2.2 affected, b2g-master affected)
RESOLVED
WONTFIX
People
(Reporter: mikehenrty, Unassigned)
References
Details
(Whiteboard: [systemsfe])
Not sure which component to put callscreen bugs in, so adding to dialer for now. For 2.1, each app will have a customized status bar color. Work to support this was completed in bug 1013913 and bug 1033364. Now we must update each of the apps with the appropriate meta tags as specified in the visual spec: https://bug1041625.bugzilla.mozilla.org/attachment.cgi?id=8460033
Comment 1•10 years ago
|
||
That's the good component :) https://wiki.mozilla.org/Modules/FirefoxOS#Dialer.2C_Callscreen.2C_Emergency_call
Reporter | ||
Comment 2•10 years ago
|
||
Etienne, I could use some advice here. It looks like the callscreen is loaded within a mozbrowser iframe, within an attention window of the system app. As such, the theme-color in the callscreen index.html file is not respected when the app is loaded. My thought is to change the system's theme color meta tag to the callscreen's theme color whenever we start the callscreen (ie. in dialer_agent.js). A drawback to this approach is that we will be hard-coding the callscreen's theme color into the system app rather than getting it from the callscreen itself. Can you think of a better way to do this?
Flags: needinfo?(etienne)
Comment 3•10 years ago
|
||
(In reply to Michael Henretty [:mhenretty] from comment #2) > Etienne, I could use some advice here. It looks like the callscreen is > loaded within a mozbrowser iframe, within an attention window of the system > app. As such, the theme-color in the callscreen index.html file is not > respected when the app is loaded. My thought is to change the system's theme > color meta tag to the callscreen's theme color whenever we start the > callscreen (ie. in dialer_agent.js). A drawback to this approach is that we > will be hard-coding the callscreen's theme color into the system app rather > than getting it from the callscreen itself. Can you think of a better way to > do this? landing bug 927862 is the way to do this :) it's the plan currently. we should probably keep this open since there will be a bit of work in the callscreen to show a transparent toolbar in locked mode and a color one otherwise.
Flags: needinfo?(etienne)
Reporter | ||
Updated•10 years ago
|
Depends on: attention-window
Comment 5•10 years ago
|
||
FYI 1008090 is fixed in 927862.
Reporter | ||
Comment 6•10 years ago
|
||
(In reply to Etienne Segonzac (:etienne) from comment #3) > we should probably keep this open since there will be a bit of work in the > callscreen to show a transparent toolbar in locked mode and a color one > otherwise. Can someone from the callscreen team help polish this one off?
Flags: needinfo?(etienne)
Updated•10 years ago
|
QA Whiteboard: [COM=Gaia::Dialer]
Comment 7•10 years ago
|
||
Forwarding to Rik so it gets the proper "backloging". Feel free to needinfo-me back if there's any issue with the System app support for this :)
Flags: needinfo?(etienne) → needinfo?(anthony)
Updated•10 years ago
|
Blocks: dialer-most-wanted
Flags: needinfo?(anthony)
Comment 8•9 years ago
|
||
All dependent bugs are fixed, and I see no more work here to be done. Please re-open if there's anything missing.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 9•9 years ago
|
||
There is still work to be done for this bug. According to spec, the statusbar color in the callscreen should match that of the dialer. Right now, it's still black like the system app.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Updated•9 years ago
|
status-b2g-v2.2:
--- → affected
status-b2g-master:
--- → affected
Comment 11•6 years ago
|
||
Firefox OS is not being worked on
Status: REOPENED → RESOLVED
Closed: 9 years ago → 6 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•