Closed Bug 1052943 Opened 10 years ago Closed 10 years ago

Move additions to C*FLAGS into moz.build and do not link against the static RTL

Categories

(MailNews Core :: Build Config, defect)

defect
Not set
normal

Tracking

(thunderbird34 fixed)

RESOLVED FIXED
Thunderbird 34.0
Tracking Status
thunderbird34 --- fixed

People

(Reporter: iannbugzilla, Assigned: iannbugzilla)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch browsercomps and flags (obsolete) — Splinter Review
Port the following fixes to comm-central Bug 1042878 - move MOZ_CAIRO_CFLAGS et al additions to C*FLAGS into moz.build Bug 939557 - browsercomps.dll failed to build with lots of mismatches detected Bug 937900 - Don't link browsercomps.dll against the static RTL
Attachment #8472001 - Flags: review?(Pidgeot18)
Comment on attachment 8472001 [details] [diff] [review] browsercomps and flags Review of attachment 8472001 [details] [diff] [review]: ----------------------------------------------------------------- r- for one very important reason. I've not fully tested all the ramifications of the patch beyond starting work on a simple MAPI test app. ::: mailnews/mapi/mapiDll/Makefile.in @@ -11,5 @@ > include $(DEPTH)/config/autoconf.mk > > -# Statically link against the CRT, so that we don't go hunting around for it > -# and not find it when we're loaded into explorer.exe or similar > -USE_STATIC_LIBS = 1 This removal is almost certainly wrong. After looking into the rational for why USE_STATIC_LIBS was removed in bug 939577, that criteria probably doesn't apply to the MAPI DLL at all.
Attachment #8472001 - Flags: review?(Pidgeot18) → review-
Depends on: 1054536
Without the mapi changes, requires patch from bug 1054536 too
Attachment #8472001 - Attachment is obsolete: true
Attachment #8474269 - Flags: review?(Pidgeot18)
Summary: Port Bug 1042878, Bug 939557 and Bug 937900 to comm-central → Move additions to C*FLAGS into moz.build and do not link against the static RTL
Attachment #8474269 - Flags: review?(Pidgeot18) → review+
Comment on attachment 8474269 [details] [diff] [review] *_CFLAGS and remove USE_STATIC_LIB except for mapi [Checked in: Comment 3] http://hg.mozilla.org/comm-central/rev/9281c70c7224
Attachment #8474269 - Attachment description: *_CFLAGS and remove USE_STATIC_LIB except for mapi → *_CFLAGS and remove USE_STATIC_LIB except for mapi [Checked in: Comment 3]
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 34.0
BTW: You forgot to remove 'unicharutil_external_s', from /suite/build/moz.build. Will track this problem in Bug 1081519.
Depends on: 1081519
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: