999959 - Double clicking to add an event in day and week views.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Description

[Evan Tseng [:evanxd]]

For the consistence of UI design in month view, we should change the UI design of day view as double clicking to add an event. Currently we could do one clicking to add an event.

Comment 1

[Evan Tseng [:evanxd]]

Hi Harly,

We should fix this.
Could you give the clear UI spec here?
We could just fix it by the double click design in day view, or you have other idea?

Thanks.

Comment 2

[Harly Hsu[:harly]]

Attachment: [Calendar] Double Click to Add Event_Draft.pdf

Attached is a draft wireframe to get us started, feel free to provide any comments or feedbacks. Thanks

Comment 3

[Harly Hsu[:harly]]

Attachment: [2.1 Calendar] Double Click to Add Event_v1.0.pdf

Comment 4

[Miller Medeiros [:millermedeiros]]

I implemented a basic double click for the week view (without visual feedback) and we have plans to change the day view to use the same logic, so listing the bugs as dependencies.

Comment 5

[Dylan Oliver [:doliver]]

[priority] --> tracking-b2g:+ conversion

Comment 6

[Miller Medeiros [:millermedeiros]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25198

Hi Harly, this is work in progress. I still plan to add some sort of "fade in" and "fade out" when the add event button appears/disappears, but just want to confirm if that is the expected behavior. Thanks!

PS: the patch also adds same behavior to the week view.

Comment 7

[Miller Medeiros [:millermedeiros]]

one thing I forgot to say is that I made the "add event link" to hide automatically after 5 seconds. But not sure if that still makes sense, specially since I added the logic to hide it when clicking another time slot or panning the view. let me know what you think.

Comment 9

[Harly Hsu[:harly]]

Comment on attachment 8505890 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25198

Thank you Miller, 
I don't think auto hide after 5 seconds is really needed here, since user can tap at other time slot or scroll to dismiss the "add event link". 
Other than that, this patch looks great! Good work!

Comment 10

[Miller Medeiros [:millermedeiros]]

Comment on attachment 8505890 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25198

I updated the patch (removed the 5s autohide), cleaned the code, squashed the commits and wrote/updated marionette tests. Ready for review.

Comment 11

[Gareth Aye [:gaye] (back from PTO)]

Comment on attachment 8505890 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25198

Looks awesome. Nice work!

Comment 12

[Miller Medeiros [:millermedeiros]]

landed on master: https://github.com/mozilla-b2g/gaia/commit/5ed7b392b0b45ce2435b00d8f49444e9e3b51d8a

Comment 13

[Edward Chen[:edchen]]

Hi Team,

When I double click to add event on mouth view which it cannot go to add new event page. It is not match page 5.of SPEC. Could you please double confirm again.

[Environment]
Gaia-Rev        0dfc1996eb583c8b507a82bf6b8319624bba23ea
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/80e18ff7c7b2
Build-ID        20141029160202
Version         36.0a1
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  39
FW-Date         Thu Oct 16 18:19:14 CST 2014
Bootloader      L1TC00011880

Comment 14

[Miller Medeiros [:millermedeiros]]

Edward, this bug only affected the Week and Day views, we have another bug for Month View (see Bug 1037351)