1053338 - [B2G][Loop] Calling a third user while in a call prevents users from closing Loop app

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Loop, defect)

Description

[Jordan de Geus(JordanD)]

Attachment: logcat_20140812_1700.txt

Description:
When a user is in a call, if the user attempts to call a third user while still in a call, the user will see their current call end and the new call initiate and the third user will receive the call. Upon answering the call on the third device, the user will see the call drop while the first device is still in the "calling" state. Users will be unable to force quit the call via the task manager or the "end call" button

Setup:
- Install the Loop app on 3 devices from: https://github.com/mozilla-b2g/firefoxos-loop-client
- Confirm all three devices have contacts added for all three device 


Repro Steps:
1) Update a Flame to 20140812000205
2) Device 1: Initiate a call with Device 2
3) Device 2: Answer call from Device 1
4) Device 1: Once in a call, press Home> Contacts> Initiate a call with Device 3
5) Device 3: Answer call and observe call drops/fails
6) Device 1: Observe device still is "calling" and user cannot force quit the app or using the "end call" button


Actual:
Calling a third user while in a call prevents users from closing Loop app

Expected:
Call drops on both devices, or users are able to force quit the app

Environmental Variables:
Device: Flame 2.0 (319mb)
Build ID: 20140812000205
Gaia: 1144cdc3a544f81c9bf71598aba1cb67d6c95a29
Gecko: 6495a7bd61ed
Version: 32.0 (2.0)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Repro frequency: 3/5
See attached: Video and logcat
http://youtu.be/j796KgbuY98

Comment 1

[Jordan de Geus(JordanD)]

This issue occurs on Flame 2.0 (512mb)

Actual: Calling a third user while in a call, causes the new call to drop and prevents users from closing the app

Flame 2.0 (512mb)

Environmental Variables:
Device: Flame 2.0
Build ID: 20140812000205
Gaia: 1144cdc3a544f81c9bf71598aba1cb67d6c95a29
Gecko: 6495a7bd61ed
Version: 32.0 (2.0)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0


------------------------------------------------------------
 
Testers are blocked from testing the Buri 2.0. Upon calling another user, when the user answers the call, the call will drop

Buri 2.0

Environmental Variables:
Device: Buri 2.0
Build ID: 20140813063004
Gaia: e215fbf0cb16063b3d2f3e6a4e588c3550b6becb
Gecko: 8e88a30eef43
Version: 32.0 (2.0)
Firmware Version: v1.2device.cfg
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

------------------------------------------------------------

Testers are blocked from testing Flame 2.1 (319mb), and Buri 2.1 as the notifications bar extends beyond the title preventing the user from making another call.

Flame 2.1 (319mb)

Environmental Variables:
Device: Flame Master
Build ID: 20140811040202
Gaia: 19ed3c9e78eaf234cc08484bde6998ae21552ba5
Gecko: a9b43778f0c2
Version: 34.0a1 (Master)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Buri 2.1

Environmental Variables:
Device: Buri Master
Build ID: 20140813073008
Gaia: 9f35fca9d818b26c06aa6b7e5c0bef25886f8f20
Gecko: 76b55c0850ca
Version: 34.0a1 (Master)
Firmware Version: v1.2device.cfg
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

------------------------------------------------------------

Loop app is currently not supported on 1.4

Flame 1.4 (319mb)

Environmental Variables:
Device: Flame 1.4
Build ID: 20140811063003
Gaia: 4a662f6dd831cf6194d7ad3501b1d56ea2964a20
Gecko: c12f198b5e51
Version: 30.0 (1.4)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0

Buri 1.4

Environmental Variables:
Device: Buri 1.4
Build ID: 20140811000206
Gaia: 4a662f6dd831cf6194d7ad3501b1d56ea2964a20
Gecko: e1b03b2fb92e
Version: 30.0 (1.4)
Firmware Version: v1.2device.cfg
User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0

Comment 2

[KTucker [:KTucker][Inactive 3/4/2016]]

The user cannot close the app. mbarone can you look at this and consider blocking on this?

Comment 3

[Jordan de Geus(JordanD)]

The bug preventing me from testing Flame 2.1 has been logged. 
Url for bug:
https://bugzilla.mozilla.org/show_bug.cgi?id=1048458

Comment 4

[Jordan de Geus(JordanD)]

Loop Version: 609ec57

Comment 5

[Fernando Jiménez Moreno [:ferjm]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/firefoxos-loop-client/pull/84

This small patch depends on bug 1039168 and fixes the immediate issue. However, we should also provide some feedback to the user about why she can't make a new call to another user while a call is already active. I tried showing an alert, but it is hidden by the call screen, so we have to either hide the call screen within the loop app to show the alert (it can't be hidden in the status bar cause that's part of the system app) or show the error message within the call screen itself. I guess we need UX input here, but it can probably done in a follow up.

Comment 6

[José Antonio Olivera Ortega [:jaoo]]

(In reply to Fernando Jiménez Moreno [:ferjm] (PTO until 29/8) from comment #5)

> However, we should also provide some feedback to the user about why she
> can't make a new call to another user while a call is already active.

Victoria, should we provide some feedback? Thanks!

Comment 7

[José Antonio Olivera Ortega [:jaoo]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/firefoxos-loop-client/pull/98

Comment 8

[Victoria Gerchinhoren [:vicky]]

(In reply to José Antonio Olivera Ortega [:jaoo] from comment #6)
> (In reply to Fernando Jiménez Moreno [:ferjm] (PTO until 29/8) from comment
> #5)
> 
> > However, we should also provide some feedback to the user about why she
> > can't make a new call to another user while a call is already active.
> 
> Victoria, should we provide some feedback? Thanks!

Ideally, instead of providing feedback we just prevent the user from performing a call in the scenarios we are currently able to manage. So:

Making a call from toolbar: This button should be displayed in a disabled mode while in a call.

Making a call from call log entry: The call log looks in the idle mode but the action is just not triggered. Since calling from an entry is a secondary action, there's no need to change its look.

Making a call from contact details: Ideally we would disable this buttons while in a call, but if this is something we have no control over, we just display a system prompt indicating the desired action is not possible due to the ongoing call.

Let me know if this clarifies your question.

Cheers.

Comment 9

[José Antonio Olivera Ortega [:jaoo]]

(In reply to Victoria Gerchinhoren [:vicky] from comment #8)

> Ideally, instead of providing feedback we just prevent the user from
> performing a call in the scenarios we are currently able to manage. So:
> 
> Making a call from toolbar: This button should be displayed in a disabled
> mode while in a call.
> 
> Making a call from call log entry: The call log looks in the idle mode but
> the action is just not triggered. Since calling from an entry is a secondary
> action, there's no need to change its look.
> 
> Making a call from contact details: Ideally we would disable this buttons
> while in a call, but if this is something we have no control over, we just
> display a system prompt indicating the desired action is not possible due to
> the ongoing call.
> 
> Let me know if this clarifies your question.

Totally, we will add it on bug 1058628. Thanks!

Landed at:

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/194799d175c9f626431998a086c3ecf320dcb648