1053355 - [tarako] Notify developers that their app passed or failed Tarako review

Status: VERIFIED FIXED

(Marketplace Graveyard :: Developer Pages, defect, P2)

Description

[Mark Striemer [:mstriemer]]

We should send an email to the developer when their app passes or fails a Tarako review.

Comment 1

[Mark Striemer [:mstriemer]]

https://github.com/mozilla/zamboni/commit/cddf08bf51be48ea1fa28da52314d2273bcb3568

Comment 2

[krupa raj[:krupa]]

This cannot be tested on dev or stage since we don't send out emails anymore. I will check on prod.

Comment 3

[Madalin Cotetiu]

Using the fake mail tool here https://marketplace.allizom.org/admin/mail it appears that the mail are sent when reviewing an app for tarako.
Screencast: http://screencast.com/t/1UNJV0rVQzaw

Comment 4

[krupa raj[:krupa]]

Email summary says "Tarako review <passed/failed>"
 Develoeprs do not know what "tarako" refers to. Let's update it to say "low-memory devices"

Comment 5

[krupa raj[:krupa]]

(In reply to krupa raj[:krupa] from comment #4)
> Email summary says "Tarako review <passed/failed>"
>  Develoeprs do not know what "tarako" refers to. Let's update it to say
> "low-memory devices"

s/Develoeprs/Developers.

Comment 6

[Mark Striemer [:mstriemer]]

Good catch, updated.

https://github.com/mozilla/zamboni/commit/203599cbb4fb99edd71859520ac111b0921e695f

Comment 7

[Mark Striemer [:mstriemer]]

Missed a word :( https://github.com/mozilla/zamboni/commit/d6f64f6a7d99b0f6599e9182db97ef89a1632e96

Comment 8

[Andrew Williamson [:eviljeff]]

(In reply to krupa raj[:krupa] from comment #2)
> This cannot be tested on dev or stage since we don't send out emails
> anymore. I will check on prod.

The feature implemented in bug 1042850 allows emails to be sent on stage or dev.

Comment 9

[Madalin Cotetiu]

Verified as fixed
The mail is sent and the correct information is include.
Screencast: http://screencast.com/t/tBPpyB25U
Closing.