Closed
Bug 1053672
Opened 10 years ago
Closed 10 years ago
Symbol UI changes aftermath: bad for UX
Categories
(Firefox OS Graveyard :: Gaia::Keyboard, defect)
Tracking
(b2g-v2.2 fixed)
RESOLVED
FIXED
2.1 S5 (26sep)
Tracking | Status | |
---|---|---|
b2g-v2.2 | --- | fixed |
People
(Reporter: janjongboom, Assigned: rudyl)
References
Details
(Whiteboard: [p=1])
Attachments
(1 file)
46 bytes,
text/x-github-pull-request
|
timdream
:
review+
Omega
:
ui-review+
|
Details | Review |
In bug 1015309 the symbol panel has been changed. Some of these changes are not good for UX: 1. Prior to this change the last three keys of the bottom row were: |/ ? BACKSPACE|. Now it's |? ! BS| . This breaks muscle memory of every current Firefox OS user that uses the ? key (my most used alt key). It's also inconsistent with stock Android keyboard where the last two keys are also | ? BSP |. ? and ! should be swapped. 2. The keyboard now has keys for °C, °F and °. °C and °F should be omitted. They are not one symbol, are used approximately 0 times a year, and can be typed by using the ° key. Plus having °F makes no sense at all in every European layout. Plus they don't fit in the key. 3. Dutch keyboard now has $ key on the first symbol panel, with ¥ as first alternative. Doesn't make any sense. Should be €. 4. |" '| and |: ;| also have been switched. Same thing with muscle memory, and also inconsistent with Android. But I use these less so don't really care. 5. The plus sign had it's own key on the first panel (like Android), but has now been omitted in favor of _. I think underscore is only used in e-mail, and plus in more cases, so I'd vouch for bringing back +, and making underscore first alt for -. 6. The second alt panel in Dutch has YEN, POUND symbols. Which makes no sense. Should not have its own key. Similar with the ¿ and the ¡. These only make sense in Spanish. 7. We have + and - and = symbols. I'd expect (als alt key or something) to have access to × and ÷. 8. Same with (C) and (R), we have those but miss the (TM) sign. Maybe as an alt.
Reporter | ||
Updated•10 years ago
|
Flags: needinfo?(ofeng)
Assignee | ||
Comment 1•10 years ago
|
||
Jan, Thanks for the feedback, I can see many good suggestions here. Some comments inlined, (In reply to Jan Jongboom [:janjongboom] (Telenor) from comment #0) > In bug 1015309 the symbol panel has been changed. Some of these changes are > not good for UX: > > 1. Prior to this change the last three keys of the bottom row were: |/ ? > BACKSPACE|. Now it's |? ! BS| . This breaks muscle memory of every current > Firefox OS user that uses the ? key (my most used alt key). It's also > inconsistent with stock Android keyboard where the last two keys are also | > ? BSP |. ? and ! should be swapped. > 2. The keyboard now has keys for °C, °F and °. °C and °F should be omitted. My bad, just realized we have "℃" and "℉" unicode chars, would changing them into the unicode chars make sense? > They are not one symbol, are used approximately 0 times a year, and can be > typed by using the ° key. Plus having °F makes no sense at all in every > European layout. Plus they don't fit in the key. See below for the symbol panel 2 (after you press [Alt]) > 3. Dutch keyboard now has $ key on the first symbol panel, with ¥ as first > alternative. Doesn't make any sense. Should be €. This is because Dutch layout does not define symbol panel 1 and 2 with "alternateLayout"/"symbolLayout" properties in its layout definition file. So, it would inherit the default symbol panels, as what you saw. I think per our current design, we would need to specify "alternateLayout" only to override the '$', and this is tedious sometimes. Hope I can find a better way to deal with this.
Reporter | ||
Comment 2•10 years ago
|
||
> My bad, just realized we have "℃" and "℉" unicode chars, would changing them > into the unicode chars make sense? Just a question, have you *ever* felt the need to type this in? > This is because Dutch layout does not define symbol panel 1 and 2 with > "alternateLayout"/"symbolLayout" properties in its layout definition file. > So, it would inherit the default symbol panels, as what you saw. > I think per our current design, we would need to specify "alternateLayout" > only to override the '$', and this is tedious sometimes. Hope I can find a > better way to deal with this. Yeah, this is problem for every (at least European) language.
Comment 3•10 years ago
|
||
(In reply to Jan Jongboom [:janjongboom] (Telenor) from comment #0) > In bug 1015309 the symbol panel has been changed. Some of these changes are > not good for UX: > > 1. Prior to this change the last three keys of the bottom row were: |/ ? > BACKSPACE|. Now it's |? ! BS| . This breaks muscle memory of every current > Firefox OS user that uses the ? key (my most used alt key). It's also > inconsistent with stock Android keyboard where the last two keys are also | > ? BSP |. ? and ! should be swapped. Good point. We should swap ? and !. > 2. The keyboard now has keys for °C, °F and °. °C and °F should be omitted. > They are not one symbol, are used approximately 0 times a year, and can be > typed by using the ° key. Plus having °F makes no sense at all in every > European layout. Plus they don't fit in the key. Like Rudy mentioned, ℃ and ℉ should be single characters, so we decided to keep them. > 3. Dutch keyboard now has $ key on the first symbol panel, with ¥ as first > alternative. Doesn't make any sense. Should be €. Considering our markets are more European then China/Japan, I'll change the alternatives order from |$ ¥ € £ ¢ ₠| to |$ € £ ₠ ¢ ¥|. And just like Rudy mentioned, Dutch layout can still define the symbol panel if necessary. > 4. |" '| and |: ;| also have been switched. Same thing with muscle memory, > and also inconsistent with Android. But I use these less so don't really > care. When using multi IMEs, that row is |, : ; " '|. It's better to put |,| next to |: ;|. > 5. The plus sign had it's own key on the first panel (like Android), but has > now been omitted in favor of _. I think underscore is only used in e-mail, > and plus in more cases, so I'd vouch for bringing back +, and making > underscore first alt for -. When using single IME, + has it's own key at symbol panel 1. _ is useful in email, URL, and emoticons. (e.g. *_*) So we will keep this one. > 6. The second alt panel in Dutch has YEN, POUND symbols. Which makes no > sense. Should not have its own key. Similar with the ¿ and the ¡. These only > make sense in Spanish. It's a good idea to remove ¿ and ¡ since it's already in the alternatives of ? and !. We can use |« »| instead of |¿ ¡|. > 7. We have + and - and = symbols. I'd expect (als alt key or something) to > have access to × and ÷. We can use |- × ÷| as alternatives of +. > 8. Same with (C) and (R), we have those but miss the (TM) sign. Maybe as an > alt. We can use ™ as alternatives of ®.
Flags: needinfo?(ofeng)
Reporter | ||
Comment 5•10 years ago
|
||
Yep, makes sense.
Assignee: nobody → janjongboom
Flags: needinfo?(janjongboom)
Reporter | ||
Updated•10 years ago
|
Flags: needinfo?(janjongboom)
Assignee | ||
Comment 7•10 years ago
|
||
Jan, do you have time to work on this? If not, I am willing to steal it from you to wrap up the symbol refinement work and make it into v2.1.
Flags: needinfo?(janjongboom)
Reporter | ||
Comment 8•10 years ago
|
||
Yeah, steal it. I don't have time this week to do much.
Assignee: janjongboom → rlu
Flags: needinfo?(janjongboom) → needinfo?(rlu)
Assignee | ||
Comment 9•10 years ago
|
||
Ok, will try to provide a patch this week.
Flags: needinfo?(rlu)
Whiteboard: [p=1]
Target Milestone: --- → 2.1 S4 (12sep)
Assignee | ||
Updated•10 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 10•10 years ago
|
||
After re-reviewing the spec, I found that ₠ seems not necessary, ref. http://www.fileformat.info/info/unicode/char/20a0/index.htm And I cannot find this symbol on Windows phone and Android symbol panel, so I would suggest we remove it from default symbol panel. Omega, could you please help confirm this? Thanks.
Flags: needinfo?(ofeng)
Comment 11•10 years ago
|
||
Let's remove "₠" from alternatives and Symbol panel and add "·". See bug 983043 for the updated UX spec.
Flags: needinfo?(ofeng)
Assignee | ||
Comment 12•10 years ago
|
||
With this patch, I refined the symbol pages again according to the updated spec. Also amend some issues around the layout definition files. Tim, Omega, please help review this change. Thanks.
Attachment #8489863 -
Flags: ui-review?(ofeng)
Attachment #8489863 -
Flags: review?(timdream)
Updated•10 years ago
|
Attachment #8489863 -
Flags: review?(timdream) → review+
Comment 13•10 years ago
|
||
Comment on attachment 8489863 [details] [review] Patch V1 LGTM, but the alternative bubble of 'R$' in Português layout breaks. I think we can have another bug to fix this problem since it's more like alternative overflow.
Attachment #8489863 -
Flags: ui-review?(ofeng) → ui-review+
Assignee | ||
Comment 14•10 years ago
|
||
the issue mentioned in comment 13 has been fixed. Landed to Gaia master, https://github.com/mozilla-b2g/gaia/commit/879bd62dd19e7966274bc0418b8821ba5a51d6d4 -- Thanks for the review.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-b2g-v2.2:
--- → fixed
Resolution: --- → FIXED
Target Milestone: 2.1 S4 (12sep) → 2.1 S5 (26sep)
You need to log in
before you can comment on or make changes to this bug.
Description
•