Closed Bug 1053884 Opened 6 years ago Closed 6 years ago

Change loading 'x' icon

Categories

(Firefox for Android :: Theme and Visual Design, defect)

x86
Android
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 34

People

(Reporter: antlam, Assigned: lucasr)

References

Details

Attachments

(4 files)

Current 'x' in the new toolbar looks very dark/dominating. Filing this bug to track a better option for it.
Attached file icon_x_cancel.zip
attaching updated icon - let's try these
Flags: needinfo?(lucasr.at.mozilla)
Attachment #8473606 - Flags: review?(margaret.leibovic)
Flags: needinfo?(lucasr.at.mozilla)
Attached image Screenshot
Looks a lot better.
Comment on attachment 8473606 [details] [diff] [review]
Update urlbar_stop icon for new toolbar design (r=margaret)

Review of attachment 8473606 [details] [diff] [review]:
-----------------------------------------------------------------

Nice.
Attachment #8473606 - Flags: review?(margaret.leibovic) → review+
Assignee: nobody → lucasr.at.mozilla
Backed out along with the rest of the patch stack for robocop failures.
https://hg.mozilla.org/integration/fx-team/rev/d18d3e14ac3e
The string changes in bug 1010741 caused the failures. Forgot to update the tests accordingly. Try build looks nice and green now, pushed:

https://hg.mozilla.org/integration/fx-team/rev/24971218ad39
https://hg.mozilla.org/mozilla-central/rev/24971218ad39
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 34
You need to log in before you can comment on or make changes to this bug.