Closed Bug 1053964 Opened 6 years ago Closed 6 years ago

[Messages][Tests] Add marionette JS test case to verify close\back button behaviour when app is in activity mode

Categories

(Firefox OS Graveyard :: Gaia::SMS, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: azasypkin, Assigned: azasypkin)

Details

(Whiteboard: [sms-most-wanted][sms-sprint-2.1S4])

Attachments

(1 file)

*** Follow-up from bug 1052442 ***

We have regressions related to this part of functionality pretty frequently so we should test it thoroughly.
Here is what I managed to do :) It would be great if you can look at it once you have some time.

Thanks!
Assignee: nobody → azasypkin
Status: NEW → ASSIGNED
Attachment #8474400 - Flags: feedback?(felash)
Comment on attachment 8474400 [details] [review]
GitHub pull request URL

Thanks for this !

One comment that I couldn't add on github: would be nice to reproduce the issues from bug 1042887 and bug 1043518 too.
Attachment #8474400 - Flags: feedback?(felash) → feedback+
Comment on attachment 8474400 [details] [review]
GitHub pull request URL

Hey Steve,

I've fixed comments that Julien left + have question regarding to one of them.

It's not urgent, but still nice to have especially for the new gaia-header that is going to be landed soon :)

Thanks!
Attachment #8474400 - Flags: review?(schung)
Hey Oleg, I haven't go through whole patch yet, but I always stuck in the last test and timeout in the end per my local test run(please see my comment in github). Could you please rebase to the latest master and try again? Thanks.
Flags: needinfo?(azasypkin)
(In reply to Steve Chung [:steveck] from comment #4)
> Hey Oleg, I haven't go through whole patch yet, but I always stuck in the
> last test and timeout in the end per my local test run(please see my comment
> in github). Could you please rebase to the latest master and try again?
> Thanks.

Hey Steve,

Just rebased - looks fine for me locally. I've refreshed PR with the latest rebased branch, we'll see what happens on TBPL.

Thanks!
Flags: needinfo?(azasypkin)
(In reply to Oleg Zasypkin [:azasypkin] from comment #5)
> (In reply to Steve Chung [:steveck] from comment #4)
> > Hey Oleg, I haven't go through whole patch yet, but I always stuck in the
> > last test and timeout in the end per my local test run(please see my comment
> > in github). Could you please rebase to the latest master and try again?
> > Thanks.
> 
> Hey Steve,
> 
> Just rebased - looks fine for me locally. I've refreshed PR with the latest
> rebased branch, we'll see what happens on TBPL.
> 
> Thanks!

I add some more comment on github. The patch looks fine for me, but it would be great to have a more robust testing environment.
(In reply to Steve Chung [:steveck] from comment #6)
> (In reply to Oleg Zasypkin [:azasypkin] from comment #5)
> > (In reply to Steve Chung [:steveck] from comment #4)
> > > Hey Oleg, I haven't go through whole patch yet, but I always stuck in the
> > > last test and timeout in the end per my local test run(please see my comment
> > > in github). Could you please rebase to the latest master and try again?
> > > Thanks.
> > 
> > Hey Steve,
> > 
> > Just rebased - looks fine for me locally. I've refreshed PR with the latest
> > rebased branch, we'll see what happens on TBPL.
> > 
> > Thanks!
> 
> I add some more comment on github. The patch looks fine for me, but it would
> be great to have a more robust testing environment.

Thanks for debugging this issue! I think we spot what caused this - I've added new commit to the PR that should fix it!
Comment on attachment 8474400 [details] [review]
GitHub pull request URL

I think the current patch should be safe now, and it's a good start to expand message app integration test sets :) Please rebase and land it while try server green!
Attachment #8474400 - Flags: review?(schung) → review+
(In reply to Steve Chung [:steveck] from comment #8)
> Comment on attachment 8474400 [details] [review]
> GitHub pull request URL
> 
> I think the current patch should be safe now, and it's a good start to
> expand message app integration test sets :) Please rebase and land it while
> try server green!

Thanks for review! Try is not fully green, but I see that bugs are filed for every failure, so landed :)

Master: https://github.com/mozilla-b2g/gaia/commit/5cd232651c5a34bebf4d973e7e4904f11d6ce547
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [sms-most-wanted] → [sms-most-wanted][sms-sprint-2.1S4]
You need to log in before you can comment on or make changes to this bug.