1053964 - [Messages][Tests] Add marionette JS test case to verify close\back button behaviour when app is in activity mode

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Oleg Zasypkin [:azasypkin]]

*** Follow-up from bug 1052442 ***

We have regressions related to this part of functionality pretty frequently so we should test it thoroughly.

Comment 1

[Oleg Zasypkin [:azasypkin]]

Attachment: GitHub pull request URL

Here is what I managed to do :) It would be great if you can look at it once you have some time.

Thanks!

Comment 2

[Julien Wajsberg [:julienw]]

Comment on attachment 8474400 [details] [review]
GitHub pull request URL

Thanks for this !

One comment that I couldn't add on github: would be nice to reproduce the issues from bug 1042887 and bug 1043518 too.

Comment 3

[Oleg Zasypkin [:azasypkin]]

Comment on attachment 8474400 [details] [review]
GitHub pull request URL

Hey Steve,

I've fixed comments that Julien left + have question regarding to one of them.

It's not urgent, but still nice to have especially for the new gaia-header that is going to be landed soon :)

Thanks!

Comment 4

[Steve Chung [:steveck]]

Hey Oleg, I haven't go through whole patch yet, but I always stuck in the last test and timeout in the end per my local test run(please see my comment in github). Could you please rebase to the latest master and try again? Thanks.

Comment 5

[Oleg Zasypkin [:azasypkin]]

(In reply to Steve Chung [:steveck] from comment #4)
> Hey Oleg, I haven't go through whole patch yet, but I always stuck in the
> last test and timeout in the end per my local test run(please see my comment
> in github). Could you please rebase to the latest master and try again?
> Thanks.

Hey Steve,

Just rebased - looks fine for me locally. I've refreshed PR with the latest rebased branch, we'll see what happens on TBPL.

Thanks!

Comment 6

[Steve Chung [:steveck]]

(In reply to Oleg Zasypkin [:azasypkin] from comment #5)
> (In reply to Steve Chung [:steveck] from comment #4)
> > Hey Oleg, I haven't go through whole patch yet, but I always stuck in the
> > last test and timeout in the end per my local test run(please see my comment
> > in github). Could you please rebase to the latest master and try again?
> > Thanks.
> 
> Hey Steve,
> 
> Just rebased - looks fine for me locally. I've refreshed PR with the latest
> rebased branch, we'll see what happens on TBPL.
> 
> Thanks!

I add some more comment on github. The patch looks fine for me, but it would be great to have a more robust testing environment.

Comment 7

[Oleg Zasypkin [:azasypkin]]

(In reply to Steve Chung [:steveck] from comment #6)
> (In reply to Oleg Zasypkin [:azasypkin] from comment #5)
> > (In reply to Steve Chung [:steveck] from comment #4)
> > > Hey Oleg, I haven't go through whole patch yet, but I always stuck in the
> > > last test and timeout in the end per my local test run(please see my comment
> > > in github). Could you please rebase to the latest master and try again?
> > > Thanks.
> > 
> > Hey Steve,
> > 
> > Just rebased - looks fine for me locally. I've refreshed PR with the latest
> > rebased branch, we'll see what happens on TBPL.
> > 
> > Thanks!
> 
> I add some more comment on github. The patch looks fine for me, but it would
> be great to have a more robust testing environment.

Thanks for debugging this issue! I think we spot what caused this - I've added new commit to the PR that should fix it!

Comment 8

[Steve Chung [:steveck]]

Comment on attachment 8474400 [details] [review]
GitHub pull request URL

I think the current patch should be safe now, and it's a good start to expand message app integration test sets :) Please rebase and land it while try server green!

Comment 9

[Oleg Zasypkin [:azasypkin]]

(In reply to Steve Chung [:steveck] from comment #8)
> Comment on attachment 8474400 [details] [review]
> GitHub pull request URL
> 
> I think the current patch should be safe now, and it's a good start to
> expand message app integration test sets :) Please rebase and land it while
> try server green!

Thanks for review! Try is not fully green, but I see that bugs are filed for every failure, so landed :)

Master: https://github.com/mozilla-b2g/gaia/commit/5cd232651c5a34bebf4d973e7e4904f11d6ce547