1054108 - [TSF][TS_E_NOLAYOUT] Implement hack for FreeCJ and Easy Changjei

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

I've emailed about the candidate window bug to them. However, currently, no reply comes. We should prepare to create hack for them because the bug blocks the users to test our TSF mode.

I think that if GetTextExt() is called but when we should return TS_E_NOLAYOUT, we should return the position of start of composition start offset. This may cause overlapping candidate window over the placeholder character (full width space), but it must not be no problem since actual composing string is displayed on the candidate window.

Although, if user scrolls something during composition, the candidate window perhaps moves to correct position because of OnLayoutChange() call. This behavior must be ugly but better than current behavior.

Of course, we should check active TIP name and prefs for using this hack.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: nsTextStore::GetTextExt() should return the position of composition start if the layout hasn't been computed yet and when Free ChangJie or Easy Changjei is active TIP

With this patch, if the active TIP name matches with Easy Changjei or Free ChangJie 2010, GetTextExt() adjusts acpStart and acpEnd to the composition start offset only while there is composition and layout at acpEnd hasn't been flushed yet.

This patch limits the version of Free ChangJie because the bug should be fixed in next version and we can check the version from the active TIP name.

I want to treat Easy Changjei similar, but I have no idea to distinguish the version.

Comment 2

[Masatoshi Kimura [:emk]]

Comment on attachment 8473554 [details] [diff] [review]
nsTextStore::GetTextExt() should return the position of composition start if the layout hasn't been computed yet and when Free ChangJie or Easy Changjei is active TIP

> +#define TIP_NAME_ATOK_BEGINGS_WITH \

Typo: s/BEGINGS_WITH/BEGINS_WITH/
Also the word order "TIP_NAME_BEGINS_WITH_ATOK" would be better.

>+      (sDoNotReturnNoLayoutErrorToEasyChangjei &&
>+       mActiveTIPKeyboardDescription.Equals(TIP_NAME_EASY_CHANGJIE)) &&

Which is correct, Changjei or Changjie?
(Google translate will translate "倉頡" to "Changjei", but it will translate "頡" alone to "Jie". Also Google search will "correct" the spell to "Changjie" when I'm searching for "Changjei". Maybe we need help from native Chinese speaker...)

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to Masatoshi Kimura [:emk] from comment #2)
> >+      (sDoNotReturnNoLayoutErrorToEasyChangjei &&
> >+       mActiveTIPKeyboardDescription.Equals(TIP_NAME_EASY_CHANGJIE)) &&
> 
> Which is correct, Changjei or Changjie?
> (Google translate will translate "倉頡" to "Changjei", but it will translate
> "頡" alone to "Jie". Also Google search will "correct" the spell to
> "Changjie" when I'm searching for "Changjei". Maybe we need help from native
> Chinese speaker...)

I think that ChangJie is correct word in Traditional Chinese because MS also uses it.

However, see Easy Changjei's website:
http://www.ecj.hk/

The site title is "易頡輸入法 Easy Changjei(智慧型速成簡易倉頡輸入法)".

And also see the file names of setup:
http://www.ecj.hk/download.html

The name is "easychangjei.exe".

According to these fact, I think that Changjei is proper noun of the product.

FYI: Free ChangJie is here: http://input.foruto.com/freecj/

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: nsTextStore::GetTextExt() should return the position of composition start if the layout hasn't been computed yet and when Free ChangJie or Easy Changjei is active TIP

Just renamed it to TIP_NAME_BEGINS_WITH_ATOK.

Comment 5

[Masatoshi Kimura [:emk]]

Comment on attachment 8473690 [details] [diff] [review]
nsTextStore::GetTextExt() should return the position of composition start if the layout hasn't been computed yet and when Free ChangJie or Easy Changjei is active TIP

(In reply to Masayuki Nakano (:masayuki) (Mozilla Japan) from comment #3)
> According to these fact, I think that Changjei is proper noun of the product.

OK, then please correct the macro name TIP_NAME_EASY_CHANGJIE to TIP_NAME_EASY_CHANGJEI.

r=me with that change.

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to Masatoshi Kimura [:emk] from comment #5)
> (In reply to Masayuki Nakano (:masayuki) (Mozilla Japan) from comment #3)
> > According to these fact, I think that Changjei is proper noun of the product.
> 
> OK, then please correct the macro name TIP_NAME_EASY_CHANGJIE to
> TIP_NAME_EASY_CHANGJEI.

Oh, thank you.

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/249bfca9312a

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/249bfca9312a