1137539 - [TSF][TS_E_NOLAYOUT] Workaround for TS_E_NOLAYOUT bug of <= Windows 8.1 may need to check different TIP name for different language Windows

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Currently, we hack TS_E_NOLAYOUT bug of TSF (it's a bug of <= Windows 8.1) for some TIPs with blacklist. However, the names were checked only on my Japanese Windows environment. At least, we should check the names on:

* the target language Windows of each TIP.
* English Windows.

Then, it must be safe even if they have different name.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.1 Implement TSFStaticSink::IsGoogleJapaneseInputActive()

Except Google Japanese Input, the TIPs which have trouble at calling ITextStoreACP::GetTextExt() don't have different name as far as I've tested.

However, let's clean up the code. I think that TSFStaticSink should have methods to check active TIP name.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.2 Implement TSFStaticSink::IsATOKActive()

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.3 Implement TSFStaticSink::IsFreeChangJieActive()

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.4 Implement TSFStaticSink::IsEasyChangjeiActive()

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/54bee1e15073
https://hg.mozilla.org/integration/mozilla-inbound/rev/9506eef27d94
https://hg.mozilla.org/integration/mozilla-inbound/rev/d74460f107ea
https://hg.mozilla.org/integration/mozilla-inbound/rev/41e28a5bc2fd

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/54bee1e15073
https://hg.mozilla.org/mozilla-central/rev/9506eef27d94
https://hg.mozilla.org/mozilla-central/rev/d74460f107ea
https://hg.mozilla.org/mozilla-central/rev/41e28a5bc2fd