Closed Bug 1137539 Opened 6 years ago Closed 5 years ago

[TSF][TS_E_NOLAYOUT] Workaround for TS_E_NOLAYOUT bug of <= Windows 8.1 may need to check different TIP name for different language Windows

Categories

(Core :: Widget: Win32, defect)

x86_64
Windows 8.1
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla40
Tracking Status
firefox40 --- fixed

People

(Reporter: masayuki, Assigned: masayuki)

References

Details

(Keywords: inputmethod)

Attachments

(4 files)

Currently, we hack TS_E_NOLAYOUT bug of TSF (it's a bug of <= Windows 8.1) for some TIPs with blacklist. However, the names were checked only on my Japanese Windows environment. At least, we should check the names on:

* the target language Windows of each TIP.
* English Windows.

Then, it must be safe even if they have different name.
Except Google Japanese Input, the TIPs which have trouble at calling ITextStoreACP::GetTextExt() don't have different name as far as I've tested.

However, let's clean up the code. I think that TSFStaticSink should have methods to check active TIP name.
Attachment #8586060 - Flags: review?(VYV03354)
Attachment #8586060 - Flags: review?(VYV03354) → review+
Attachment #8586061 - Flags: review?(VYV03354) → review+
Attachment #8586062 - Flags: review?(VYV03354) → review+
Attachment #8586063 - Flags: review?(VYV03354) → review+
Status: NEW → ASSIGNED
Summary: [TSF] Workaround for TS_E_NOLAYOUT bug of <= Windows 8.1 may need to check different TIP name for different language Windows → [TSF][TS_E_NOLAYOUT] Workaround for TS_E_NOLAYOUT bug of <= Windows 8.1 may need to check different TIP name for different language Windows
You need to log in before you can comment on or make changes to this bug.