1054135 - [B2G][System] support 24 hour time format for Time picker

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Input Mgmt, defect)

Description

[[e-mail]]

Test steps:

1. Open settings app
2. change the Time format settings in Settings > Date & Time > Time Format panel

Expect:

The time format in Time picker will be changed.


here's the patch steps to apply correct time format:

2. detect proper time format via mozHour12 API, and get correct time format string from new 'shortTimeFormat12'/'shortTimeFormat24'.

```
var timeFormat = window.navigator.mozHour12 ? _('shortTimeFormat12') : _('shortTimeFormat24');
```


The full usage is at [3](WIP) for reference.


[3] https://github.com/mozilla-b2g/gaia/pull/22757/files

Comment 1

[howie [:howie]]

Fred will help on this, thanks!

Comment 2

[[e-mail]]

Attachment: pull request redirect to github

* use mozHour12 to detect 12/24 hour
* add listener to redraw timepicker
* remove date_picker since its not used
* add test case

Comment 3

[[e-mail]]

merged https://github.com/mozilla-b2g/gaia/commit/b3982ed710e2accf398a873494e143a9fe372e07

thanks!

Comment 4

[Ed Morley [:emorley]]

Reverted for intermittent JS exceptions like:
https://tbpl.mozilla.org/php/getParsedLog.php?id=46251183&tree=B2g-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=46251314&tree=B2g-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=46249927&tree=B2g-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=46246699&tree=B2g-Inbound

https://github.com/mozilla-b2g/gaia/commit/00aa329503d73435c9821d4a50c2797a0374eac6

Comment 5

[[e-mail]]

Attachment: pull request redirect to github

I believe the root cause is we got timeformatchange event when language changed, but there's no existing timepicker.

additional commit is here
https://github.com/gasolin/gaia/commit/c863476afbc8f36e14d96176a680f01eec38032a

I'd squash them after review granted. Please kindly review it again.

Comment 6

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8475716 [details] [review]
pull request redirect to github

Something was broken so deserve a test, but up to you.

Comment 7

[[e-mail]]

merged https://github.com/mozilla-b2g/gaia/commit/579a8714d1c5b382bdd10383477d1221c04dc288

thanks!

Comment 8

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

The user is able to choose from 1-23 hours in the timer picker when using 24hr Time Format in the settings app as expected. Unable to verify this bug until the depends on are verified

Comment 9

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

Since the Time picker is implemented and working correctly, as stated in comment 8, closing this bug as verified fixed