1054162 - Adblock Plus blocks Twitter "Follow" button and #hashtags

Status: RESOLVED INVALID

(Firefox :: Extension Compatibility, defect)

Description

[Chris Peterson [:cpeterson]]

STR:
1. Load this tweet: https://twitter.com/mozilla/status/500070137056481280
2. The tweet reads: "Thanks to everyone for participating in such a rich conversation. We hope it continues! #TeamInternet"
3. Install Adblock Plus addon. (I'm testing Adblock Plus version 2.6.4.)
4. Reload the tweet

RESULT:
The #hashtags and the "Follow" button are missing. The tweet now reads: "Thanks to everyone for participating in such a rich conversation. We hope it continues! "

Comment 1

[Chris Peterson [:cpeterson]]

This bug is a regression in Nightly 34 build 2014-08-13. This bug is basically a non-e10s version of (fixed) e10s bug 1007982.

The regression pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=b53c2753ce9a&tochange=7fc96293ada8

* Bill: do any changesets in this pushlog look suspicious? I see the following console error:

> chrome://browser/content/browser.xul : Unable to run script because scripts are blocked internally.

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

I just tried this in the current nightly and I can't reproduce it. Does it depend on a certain filter list?

Comment 3

[Chris Peterson [:cpeterson]]

You need to install "Fanboy's Annoyance List" from https://easylist.adblockplus.org/en/. This is the same filter list from e10s bug 1007982. The following filter rule from Fanboy's Annoyance List blocks the hashtags:

  twitter.com#@#.twitter-hashtag

Comment 4

[Alice0775 White]

Regression wikndow(m-i)
Good:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d78a39f01102
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:34.0) Gecko/20100101 Firefox/34.0 ID:20140811200055
Bad:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9648b3e555db
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:34.0) Gecko/20100101 Firefox/34.0 ID:20140811200755
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=d78a39f01102&tochange=9648b3e555db

Triggered by: Bug 1050049

Comment 5

[Alice0775 White]

Attachment: debug build log

Comment 6

[Alice0775 White]

FYI,
It works as expected if I added bindToUntrustedContent='true' to abp.xpi\lib\elemHideHitRegistration.js line 129 as follows;

let data = "<bindings xmlns='http://www.mozilla.org/xbl'><binding id='dummy' bindToUntrustedContent='true'/></bindings>";

Comment 7

[Bobby Holley (:bholley)]

Yes. Sorry for not getting in touch earlier - I'd forgotten that ABP uses in-content XBL bindings.

Comment 8

[Wladimir Palant]

Thank you, I filed https://issues.adblockplus.org/ticket/1241 on that. Feel free to resolve this as INVALID since the problem is on our end.

Comment 9

[Chris Peterson [:cpeterson]]

This bug appears to have been fixed upstream: https://issues.adblockplus.org/ticket/1241#comment:6

Comment 11

[Michael]

This was fixed for me, but it has regressed again using any build after 9/28. I am using the windows 64-bit build. None of my custom filters are working anymore.

Comment 12

[Chris Peterson [:cpeterson]]

(In reply to Michael from comment #11)
> This was fixed for me, but it has regressed again using any build after
> 9/28. I am using the windows 64-bit build. None of my custom filters are
> working anymore.

Michael, thanks for testing. Does build 9/28 refer to Firefox Nightly or Adblock Plus? What version of Adblock Plus are you using?

Comment 13

[Chris Peterson [:cpeterson]]

Michael, I can reproduce the problem described in comment 0 when using Nightly build 10/13 with Adblock Plus 2.6.4 (the version on https://addons.mozilla.org) but not with Adblock Plus 2.6.4.3867 (the development version from https://adblockplus.org/en/development-builds).

Comment 14

[Michael]

I might have a different issue then. Here are three screenshots I uploaded to my OneDrive this morning. Link below: In the first one, the ABP options has this & character in the preferences button. This is on every Nightly x64 build after 9-28. When I click on the preferences button, nothing happens at all. In screenshot 2, an element that would normally be collapsed is no longer collapsed. This also only happens on builds after 9-28. In screenshot 3, there is the normal filter preferences button which also works when I click on it. That is the 9-28 x64 nightly build.
https://onedrive.live.com/?cid=0D21E50B424E7DB3&id=D21E50B424E7DB3%21120 
Michael

Comment 15

[Chris Peterson [:cpeterson]]

I have seen the "&Filter" button bug before, but I can't reproduce it or the filehippo.com empty space problem with Nightly 36 build 2014-10-14 (on OS X).

Comment 16

[Michael]

Haha! Figures.... :) Well, I guess I could upload my whole build. It is a zipped build after all. Perhaps I could upload my prefs.js for someone to look at. Ideally someone who does remember the "&filter bug" will read this and post something helpful as a comment to the thread. In the meantime I will do some searches on the "&filter button bug".
It is definitely something that changed around 9-28 that is triggering it.
Thank you for the reply,
Michael T

Comment 17

[Chris Peterson [:cpeterson]]

Some useful information you can post here is in Nightly's "Help" menu > "Troubleshooting Information" menu item > "Copy text to clipboard" button (aka the about:support page). This includes system information, addon versions, and any modified about:config preferences.

Also, what Adblock Plus filters do you have installed or enabled?

Comment 18

[Michael]

OK. Here it is from "copy text to clipboard". I pasted it in after my abp config backup. I noticed two other things also.
1. I cannot run any x64 nightly build with a clean profile. The browser simply "locks up" my whole machine where it becomes completely unresponsive and I have to hold the power button in to shut it off. 
2. I also noticed that with any build after 9-28, if I disable abp it says I must restart the browser, even though it should be and has been for some time now been a "Restartless" add-on. It is restartless with the 9-28 build and works fine. I don't have to restart the browser to either disable/enable the add-on. Every later build and I do have to restart it.

I currently have no filter subsciptions enabled. I only have these custom rules.
Many of them are likely not even necessary anymore. This is from the built-in abp backup option in the filer preferences menu.
# Adblock Plus preferences
version=4

[Subscription]
url=~fl~
title=Ad Blocking Rules
defaults=blocking

[Subscription filters]
||ads.azbilliards.com^
||adtechus.com^
||av-comparatives.org/images/banners/*
||bwp.cnet.com^
doubleclick.net^
||facebook.com/*
||google.com/extern_js/
||intel.com/sites/sitewide/survey/pix/*
||a1.interclick.com^
||kitco.com/images/banner/*
||kitco.com/images/banners/*
||kitco.com/ssi/*
||overclockers.co.uk/home_banners/*
||s2.softpedia-static.com/images/aetd/*
||s1.softpedia-static.com/images/ads/*
||s1.softpedia-static.com/images/afh/*
||platform.twitter.com^
||us.adserver.yahoo.com^

[Subscription]
url=~eh~
title=Element Hiding Rules
defaults=elemhide

[Subscription filters]
###ad-slot-1
###ad-slot-2
##.ad-tl1
##.adsbygoogle
##.advertisement
###div-gpt-ad-1372666913838-0
###div-gpt-ad-1384762460430-0
###div-gpt-ad-1384762460430-1
amazon.com##DIV\[id="DAga"]
amazon.com##DIV\[id="DAr2"]
amazon.com##DIV\[id="DAr7"]
bing.com##DIV\[class="sb_adsNv2"]
bing.com##DIV\[class="sb_adsWv2"]
bing.com##DIV\[class="sb_adsWv2 sb_adsW2v2"]
cnet.com##DIV\[class="bidwar"]
cnet.com##DIV\[class="leaderBoard"]
cnet.com##IFRAME\[class="spotBidIframe"]
google.com##DIV\[id="bottomads"]
google.com##DIV\[id="mbEnd"]
google.com##DIV\[id="mbEnd"]\[class="ads-container"]
google.com##DIV\[id="rhs_block"]
google.com##DIV\[id="tads"]
google.com##DIV\[id="tads"]\[class="ads-container c"]
guru3d.com##DIV\[id="div-gpt-ad-1370710750754-0"]
guru3d.com##DIV\[id="div-gpt-ad-1372674641935-0"]
h10025.www1.hp.com##.threeColumns
h10025.www1.hp.com##TD.bottomSpaceBig\[valign="middle"]
google.com##DIV\[class="ads-container"]
google.com##DIV\[id="tads"]\[class="ads-container c"]
google.com##DIV\[id="bottomads"]
infowars.com##.insider_container
kitco.com##HR
kitco.com##DIV\[id="symbol_search"]\[class="market_indices"]
kitco.com##.center
kitco.com##IMG\[src="/images/advertisement.gif"]
kitco.com##TD\[width="180"]\[valign="top"]
kitco.com##TD\[width="200"]\[valign="top"]
overclockers.co.uk##A\[href="http://forums.overclockers.co.uk/showthread.php?t=17943556&posted=1&utm_source=forums&utm_medium=banner"]
softpedia.com##.ad.ad-300x600.mgtop_20
softpedia.com##.grid_48.ad.ad-970x90
ustream.tv##.featuredContent.colTitleBoxV4.pageScroller
ustream.tv###RecommendedLive
weather.com##DIV\[class="wx-inner"]
weather.com##DIV\[id="WX_Bot300"]\[class="wx-module wx-gptADS"]
weather.com##DIV\[id="WX_Mid300"]\[class="wx-module wx-gptADS"]
winscp.net##DIV\[class="ad_body"]
winscp.net##DIV\[class="ad_title"]
yahoo.com###ad-north-base
yahoo.com###theAd
yahoo.com##.content.rmx-ad.has-image.voh-parent.cf
yahoo.com##DIV\[id="ad"]
yahoo.com##DIV\[id="ad-north-base"]\[class=" fpad"]
yahoo.com##DIV\[id="my-adsLREC"]
yahoo.com##DIV\[id="slot_MB"]
yahoo.com###mobilizer
us-mg5.mail.yahoo.com##DIV\[id="mbAds"]
youtube.com##.ad-div
youtube.com##DIV\[class="yt-alert yt-alert-promo yt-rounded "]
youtube.com##DIV\[id="premium-yva"]
youtube.com##DIV\[id="video-masthead"]
youtube.com##H2
youtube.com##.sidebar-module-description
youtube.com##.sidebar-module-header
youtube.com##.yt-alert-content
youtube.com##.yt-alert.yt-alert-default.yt-alert-info
youtube.com##LI\[id="feed-pyv-container"]\[class="feed-item-container branded-page-box  browse-list-item-container"]
youtube.com###feed-pyv-container
youtube.com###outage-box
youtube.com###ticker
zippcast.com##DIV\[style="border: 1px solid rgb(221, 221, 221); margin: auto; padding: 5px; display: block; width: 150px; height: 610px; text-align: left; color: rgb(153, 153, 153); font-size: 10px;"]

About:Support "copy text to clipboard"


Application Basics
------------------

Name: Firefox
Version: 35.0a1
User Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:35.0) Gecko/20100101 Firefox/35.0
Multiprocess Windows: 0/1

Extensions
----------

Name: Adblock Plus
Version: 2.6.4.3868
Enabled: true
ID: {d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}

Name: Classic Bookmarks Button
Version: 1.0
Enabled: true
ID: ClassicBookmarksButton@ArisT2Noia4dev

Name: Element Hiding Helper for Adblock Plus
Version: 1.3.0.471
Enabled: true
ID: [e-mail]

Name: NoScript
Version: 2.6.9.1rc2
Enabled: true
ID: {73a6fe31-595d-460b-a920-fcc0f8843232}

Name: SmoothWheel (mozdev.org)
Version: 0.45.8.20130519.3
Enabled: true
ID: {5F590AA2-1221-4113-A6F4-A4BB62414FAC}

Name: Adguard AdBlocker
Version: 1.0.3.3
Enabled: false
ID: [e-mail]

Name: Bluhell Firewall
Version: 2.4.0
Enabled: false
ID: {6BB5760D-F97E-421B-AF5B-8457A90C3CED}

Name: PDF Viewer
Version: 1.0.277
Enabled: false
ID: [e-mail]

Name: Yet Another Smooth Scrolling
Version: 3.1.7
Enabled: false
ID: yetanothersmoothscrolling@kataho

Graphics
--------

Adapter Description: Intel(R) HD Graphics 4600
Adapter Description (GPU #2): NVIDIA GeForce GTX 870M
Adapter Drivers: igdumdim64 igd10iumd64 igd10iumd64 igdumdim32 igd10iumd32 igd10iumd32
Adapter Drivers (GPU #2): nvd3dumx,nvwgf2umx,nvwgf2umx nvd3dum,nvwgf2um,nvwgf2um
Adapter RAM: Unknown
Adapter RAM (GPU #2): 3072
ClearType Parameters: Gamma: 2200 Pixel Structure: B ClearType Level: 50 Enhanced Contrast: 50
Device ID: 0x0416
Device ID (GPU #2): 0x1199
Direct2D Enabled: true
DirectWrite Enabled: true (6.3.9600.17111)
Driver Date: 8-5-2014
Driver Date (GPU #2): 9-26-2014
Driver Version: 10.18.10.3907
Driver Version (GPU #2): 9.18.13.4424
GPU #2 Active: false
GPU Accelerated Windows: 1/1 Direct3D 10
Subsys ID: 11061462
Subsys ID (GPU #2): 11061462
Vendor ID: 0x8086
Vendor ID (GPU #2): 0x10de
WebGL Renderer: Google Inc. -- ANGLE (Intel(R) HD Graphics 4600 Direct3D9Ex vs_3_0 ps_3_0)
windowLayerManagerRemote: false
AzureCanvasBackend: direct2d
AzureContentBackend: direct2d
AzureFallbackCanvasBackend: cairo
AzureSkiaAccelerated: 0

Important Modified Preferences
------------------------------

accessibility.accesskeycausesactivation: false
accessibility.browsewithcaret_shortcut.enabled: false
accessibility.typeaheadfind.flashBar: 0
accessibility.typeaheadfind.prefillwithselection: false
accessibility.warn_on_browsewithcaret: false
accessibility.win32.force_disabled: true
browser.cache.check_doc_frequency: 1
browser.cache.disk_cache_ssl: false
browser.cache.disk.capacity: 358400
browser.cache.disk.enable: false
browser.cache.disk.smart_size.first_run: false
browser.cache.frecency_experiment: 2
browser.cache.memory.max_entry_size: -1
browser.cache.offline.capacity: 153600
browser.display.background_color: #CCCCCC
browser.fixup.alternate.enabled: false
browser.newtab.url: about:blank
browser.places.importBookmarksHTML: false
browser.places.smartBookmarksVersion: 7
browser.privatebrowsing.autostart: true
browser.privatebrowsing.dont_prompt_on_enter: true
browser.search.suggest.enabled: false
browser.search.update: false
browser.search.useDBForOrder: true
browser.sessionstore.max_resumed_crashes: 0
browser.sessionstore.max_tabs_undo: 0
browser.sessionstore.max_windows_undo: 0
browser.sessionstore.privacy_level: 2
browser.sessionstore.privacy_level_deferred: 2
browser.sessionstore.resume_from_crash: false
browser.sessionstore.upgradeBackup.latestBuildID: 20140625001155
browser.startup.homepage: about:permissions
browser.startup.homepage_override.buildID: 20140928080618
browser.startup.homepage_override.mstone: 35.0a1
browser.tabs.animate: false
browser.tabs.remote: false
browser.tabs.warnOnClose: false
browser.tabs.warnOnOpen: false
browser.urlbar.autocomplete.enabled: false
dom.indexedDB.enabled: false
dom.ipc.plugins.flash.subprocess.crashreporter.enabled: false
dom.max_chrome_script_run_time: 40
dom.max_script_run_time: 40
dom.mozApps.runUpdate: false
dom.mozApps.used: true
dom.storage.enabled: false
dom.w3c_touch_events.expose: false
extensions.lastAppVersion: 35.0a1
font.internaluseonly.changed: false
general.autoScroll: false
gfx.color_management.mode: 1
gfx.color_management.rendering_intent: 2
gfx.direct2d.force-enabled: true
gfx.direct3d.checkDX10: true
gfx.direct3d.last_used_feature_level_idx: 0
gfx.direct3d.prefer_10_1: true
gfx.font_rendering.cleartype_params.force_gdi_classic_max_size: 1
gfx.font_rendering.cleartype_params.rendering_mode: 5
gfx.font_rendering.cleartype.always_use_for_content: true
gfx.font_rendering.directwrite.enabled: true
gfx.use_text_smoothing_setting: true
image.mem.max_decoded_image_kb: 512000
image.mem.min_discard_timeout_ms: 30000
javascript.options.mem.high_water_mark: 512
javascript.options.showInConsole: false
keyword.URL: https://www.google.com/search?q=
layers.acceleration.force-enabled: true
layers.offmainthreadcomposition.enabled: false
media.gmp-gmpopenh264.enabled: false
media.gmp-manager.lastCheck: 1413337662
mousewheel.acceleration.factor: 2
network.cookie.cookieBehavior: 2
network.cookie.prefsMigrated: true
network.dns.disableIPv6: true
network.dns.disablePrefetch: true
network.dnsCacheEntries: 1536
network.dnsCacheExpiration: 10800
network.http.pipelining: true
network.http.pipelining.maxrequests: 8
network.http.sendRefererHeader: 1
network.http.sendSecureXSiteReferrer: false
network.prefetch-next: false
places.database.lastMaintenance: 1413239435
places.history.enabled: false
places.history.expiration.transient_current_max_pages: 104858
plugin.importedState: true
plugin.state.flash: 1
plugin.state.java: 0
plugin.state.np-mswmp: 0
plugin.state.npctrl: 1
plugin.state.npdeployjava: 0
plugin.state.npmeetingjoinpluginoc: 0
plugin.state.npspwrap: 0
plugin.state.npwlpg: 0
privacy.clearOnShutdown.offlineApps: true
privacy.clearOnShutdown.passwords: true
privacy.clearOnShutdown.siteSettings: true
privacy.cpd.siteSettings: true
privacy.sanitize.migrateFx3Prefs: true
security.disable_button.openCertManager: false
security.disable_button.openDeviceManager: false
security.OCSP.disable_button.managecrl: false
security.OCSP.require: true
security.warn_viewing_mixed: false
security.warn_viewing_mixed.show_once: false
storage.vacuum.last.index: 1
storage.vacuum.last.places.sqlite: 1412128729
webgl.force-enabled: true

Important Locked Preferences
----------------------------

JavaScript
----------

Incremental GC: true

Accessibility
-------------

Activated: false
Prevent Accessibility: 0

Library Versions
----------------

NSPR
Expected minimum version: 4.10.7
Version in use: 4.10.7

NSS
Expected minimum version: 3.17.1 Basic ECC
Version in use: 3.17.1 Basic ECC

NSSSMIME
Expected minimum version: 3.17.1 Basic ECC
Version in use: 3.17.1 Basic ECC

NSSSSL
Expected minimum version: 3.17.1 Basic ECC
Version in use: 3.17.1 Basic ECC

NSSUTIL
Expected minimum version: 3.17.1
Version in use: 3.17.1

Experimental Features
---------------------

Comment 19

[Chris Peterson [:cpeterson]]

Michael, I'm surprised by some of your about:config preference values. For example, dom.indexedDB.enabled=false. The default is true and if I set dom.indexedDB.enabled to false and restart Nightly, I can't load any pages! I filed bug 1083019 for this issue.

Also, network.http.pipelining=true is not recommended. It can cause page load delays and other problems with some HTTP proxies.

Can you reproduce this problem if you disable the NoScript and "Element Hiding Helper for Adblock Plus" addons? Can you try testing a 32-bit Windows build instead of the Win64 builds? We haven't done any testing of e10s on Win64.

And if those issues don't isolate the problem, can you reproduce this problem with a new profile and installing just Adblock Plus? Instructions for creating a new test profile without messing with your default profile:

http://kb.mozillazine.org/Creating_a_new_Firefox_profile_on_Windows

Comment 20

[Michael]

Chris,
I appreciate your help on this. Toggling the prefs dom.storage.enabled and dom.indexedDB.enabled back to true fixed my issue. Up until 9-28-14, these prefs were fine being left at false. As I said earlier, I am unable to run the x64 nightly with a clean profile at all. It completely "Locks up" my machine and I have to do a hard reset of windows. I will not test that any further at this time. I do believe that it is due to either OMTC or e10s or both.
Thank you again for your help and your time,
Michael T

Comment 21

[Chris Peterson [:cpeterson]]

(In reply to Michael from comment #18)
> 1. I cannot run any x64 nightly build with a clean profile. The browser
> simply "locks up" my whole machine where it becomes completely unresponsive
> and I have to hold the power button in to shut it off. 

You should report a new bug about the x64 problem you found (and include your about:support information). Mozilla plans support Win64 as a "tier 1" platform again very soon, so the developers working on Windows will definitely want to know about your problem.

Comment 22

[Wladimir Palant]

For reference: Adblock Plus 2.6.5 was released today and fixes this issue (currently awaiting AMO's review).

Comment 23

[Michael]

@ Chris,
I filed bug 1083559. 
https://bugzilla.mozilla.org/show_bug.cgi?id=1083559 
Thanks again for your help,
Michael