1054723 - error on add-on upload: validation error

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Add-on Validation, defect, P1)

Description

[erosman [:erosman]]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Firefox/31.0 (Beta/Release)
Build ID: 20140716183446

Steps to reproduce:

There are many reports that users can not upload to AMO. They often state it as failure at validation stage.

https://forums.mozilla.org/addons/viewtopic.php?f=23&t=19805
https://forums.mozilla.org/addons/viewtopic.php?f=20&t=19803
https://forums.mozilla.org/addons/viewtopic.php?f=7&t=19795
https://forums.mozilla.org/addons/viewtopic.php?f=20&t=19799

I am an amo-editor and have not seen any new addon added to the queue for the last 24 hours.

I have also noticed intermittent errors from validator while reviewing addon.
Examples are, "Error: The package could not be found" (while file is displayed), or code error (very long string of error)

Comment 1

[Axel Grude [:realRaven]]

Just to add a me-too tried uploading a new version of quickFilters yesterday and today, and it just stalls at the validation stage.

Comment 2

[Holger Lehmann]

I tried to "Add a New Version" by uploading the addon the "Add Version" button never enables. I tried to upload a ZIP-Archive with the sources, just in case, but nothing happens. I let it sit there for approx. 30 minutes, to no avail.

I even tried uploading this as a new add-on, with the same result. I tried Firefox 31.0 and Google Chrome 35, both running under Linux.

Comment 3

[Holger Lehmann]

Attachment: upload-problem.png

See screenshot (upload-problem.png) for details, where it "hangs".

No messages on the Javascript console thus far.

Comment 5

[erosman [:erosman]]

More reports:

https://forums.mozilla.org/addons/viewtopic.php?f=23&t=19805
https://forums.mozilla.org/addons/viewtopic.php?f=27&t=19814
https://forums.mozilla.org/addons/viewtopic.php?f=20&t=14544

Comment 6

[erosman [:erosman]]

There is a report that user can not upload screen-shot to existing addon
quote: I was trying to upload a screenshot to my en_GB extension, but for around 20 minutes that it says "image changes being processed"

Comment 7

[Mathieu Pillard [:mat]]

Jason fixed it by restarting the Celery workers today.

Comment 8

[Luís Miguel [:quicksaver] (not reading bugmail)]

Sorry, but I still have this issue.

I should mention that this morning I didn't have this exact issue, I could upload and validation would "finish" and enable the "Add version" button, but after clicking it, it would give me an "This version already exists" notice (even though it didn't). But now, I'm back to this exact bug.

Comment 9

[Jorge Villalobos [:jorgev] (he/him)]

Others are reporting similar problems, not only related to file uploads, but also in the reviewer tools (getting frequent 504 Gateway Time-out errors).

Comment 10

[Jason Thomas [:jason]]

(In reply to Mathieu Pillard [:mat] from comment #7)
> Jason fixed it by restarting the Celery workers today.

I had to restart the workers again today, specifically for tasks associated with devhub and images queues.

Comment 11

[Luís Miguel [:quicksaver] (not reading bugmail)]

(In reply to Jason Thomas [:jason] from comment #10)
> I had to restart the workers again today, specifically for tasks associated
> with devhub and images queues.

I just uploaded a new version of my add-on and indeed had no problems.

Comment 12

[Kris Maglione [:kmag]]

A lot of validation pages are now showing only "The package cannot be found", which seems related to this. E.g., https://addons.mozilla.org/developers/addon/silentblock/file/271980/validation

My guess is that they're just broken cached results, in which case, they need to be cleared.

Comment 13

[erosman [:erosman]]

While someone is working on the issues .. there is a small issue of missing images.
When in editor, the screen-shot next/previous/close images are broken:

https://addons.cdn.mozilla.net/user-media/img/jquery-lightbox/close.png
https://addons.cdn.mozilla.net/user-media/img/jquery-lightbox/lightbox-blank.gif
https://addons.cdn.mozilla.net/user-media/img/jquery-lightbox/goright.png
https://addons.cdn.mozilla.net/user-media/img/jquery-lightbox/goleft.png

Comment 14

[Mathieu Agopian [:magopian]]

This last comment seems unrelated, I opened a specific bug for it: bug 1056057

Comment 15

[Holger Lehmann]

Today, I could verify that it works again.

Thanks for fixing it :-)

Comment 16

[Mathieu Agopian [:magopian]]

Kris, I don't have access to the validation page you're linking to, and it doesn't seem related to this bug, can you please confirm? Maybe we can now close this bug and open a new one for the issue you're talking about?

Comment 17

[Kris Maglione [:kmag]]

This problem was caused by issues with validation tasks, so it seems to be more likely to be related than not. In any case, I tacked it onto this bug because the message was the same as mentioned in comment 0, but I now see that that part of the comment was related to the validation page issue and not the submission issue, so I don't mind moving it to a separate bug.

Comment 18

[Jorge Villalobos [:jorgev] (he/him)]

Bug 1056177 was also filed related to this, and other developers have been complaining about broken uploads.

Comment 19

[erosman [:erosman]]

Bug 1056475 opened as a separate report for the "Validator errors in Editor Review"

Comment 20

[info]

Hi Guys,
We are trying to upload our extension but without any success..
Validator passes but uploading still fails.

I can attach images if needed..

We are obfuscating our extension and the obfuscated code passes the validators.

Comment 21

[Jorge Villalobos [:jorgev] (he/him)]

Please attach the file you're trying to upload.

Comment 22

[Daniel Kladnik]

Hi,

this bug stil exists.

I'm trying to upload new add-on version. Validation ok but after clicking the "Add version" button i get the "version already extists" message. It really does and it contains 0 files. If I try to delete it (it always fails the first time) i get the "Oops! We had an error. We'll get to fixing that soon." error.

If i don't delete it and list add-on versions a min later, the addon appears as it was uploaded normally, it containts the xpi file and has "Awaiting Full Review (1 file) " status.

It looks like the server cache or sync problem to me.

Comment 23

[Mathieu Agopian [:magopian]]

There's been a fix for some of AMO's instability issues lately (https://bugzilla.mozilla.org/show_bug.cgi?id=1058682#c6). Can you confirm this bug is still present?

Comment 24

[Luís Miguel [:quicksaver] (not reading bugmail)]

Not speaking for everyone of course, but I was able to upload about five different (beta) versions of two add-ons over the weekend without incident.

Comment 25

[Kris Maglione [:kmag]]

I'm going to call this fixed. Please reopen if issues persist.

Comment 26

[Victor Carciu]

Verified as fixed . Validation , upload and new version upload are working as expected