1054995 - Share the way to display phone, sms and email information.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Anthony Ricaud (:rik)]

In bug 1047353, we're gonna display some contact informations the same way the Contacts app does. We should share the code to create those widgets.

Comment 1

[Francisco Jordano [:arcturus] [:francisco]]

Hei Sergi,

I think the changes that Doug is going to introduce wont affect your work with redesigning the contacts form.

But just for taking into account this work is happening.

Comment 2

[Francisco Jordano [:arcturus] [:francisco]]

Hei Sergi,

could you double check if Doug's changes affect your work?

https://github.com/DouglasSherk/gaia/commit/bbdedd7517d62f3250bdc836e5cc6c553be431e1

I don't think so,  but will be better to double check.

Comment 3

[Doug Sherk (:drs) (inactive)]

Attachment: Refactor contacts action buttons into shared.

PR: https://github.com/mozilla-b2g/gaia/pull/23376

I'll file followups once we determine everything we need. I left a couple of comments where I suspect that we'll want followups.

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

Heads up, still didn't have time to do the review, but will do in 9 hours.

Sorry for the inconvenience, but I've been pretty busy with feature work :(

Comment 5

[Doug Sherk (:drs) (inactive)]

Attachment: Refactor contacts action buttons into shared.

Updated PR.

I might be failing some integration tests. If so, I'll fix them tomorrow.

Comment 6

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8480332 [details] [diff] [review]
Refactor contacts action buttons into shared.

Amazing job Dough.

I know this is not the most pleasant task, but it's looking pretty good.

I left you some comments on github, some of them pretty easy to resolve, my main concern right now is the problem with FB contacts not rendering in the list. I know this patch doesn't touch the list, but without it I don't have any problems.

Will try to investigate deeper whats going on there.

Thanks!

Comment 7

[Doug Sherk (:drs) (inactive)]

Attachment: Refactor contacts action buttons into shared.

Updated PR.

I think this is passing every test now, but gaia-try is down. I'll check again when it's back up.

Comment 8

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8480866 [details] [diff] [review]
Refactor contacts action buttons into shared.

Fantastic!

Code lgtm, aand a quick smoke test shows everything working :)

Comment 9

[Doug Sherk (:drs) (inactive)]

https://github.com/mozilla-b2g/gaia/commit/0d659d75cb25de6d06a91330f6ace87dc6229b7e

Thanks, Francisco.