1055737 - Datazilla Repository Update

Status: RESOLVED FIXED

(Infrastructure & Operations Graveyard :: WebOps: Other, task)

Description

[Jonathan Eads ( :jeads )]

A new datazilla repository is ready to push to stage. This release includes the following changes:

1.) Added messaging indicating when an http GET request fails.

Comment 1

[Chris Turra [:cturra]]

commit 658096d5d0a99cff9eb1c214fe508271e0a2c7e0 pushed to stage. please let me know when you've completed your testing and are happy with this change going into production.

Comment 2

[Jonathan Eads ( :jeads )]

It looks like we're hitting a bug in jquery that prevents the error callback getting called when the data type is json and the http get times out. I added an explicit timeout for the failing queries.

Please push the repository to stage again and I will confirm that the change works.

Comment 3

[Chris Turra [:cturra]]

stage updated as requested.

Comment 4

[Jonathan Eads ( :jeads )]

The timeout's set in the jquery ajax calls are not honored. It's a bug in jquery. Having error handling callbacks is better than not having them, might figure a quick fix in the future at some point and the dialogs will be displayed as expected.

Please go ahead and push to production.

Comment 5

[C. Liang [:cyliang]]

Production is now on commit 714d3a6b39d889fbcd21363b329b3b2b1dc47a6f.  

Can you please verify that the fix is working as intended in production?

Comment 6

[Avi Halachmi (:avih)]

If someone could define how it should behave, I can test.

What I tried just now:
- Visited https://datazilla.mozilla.org/
- Throbber spins for ~4 minutes already (and counting).
- No message is displayed and also it doesn't show data.

How long is the timeout duration?

Comment 7

[Avi Halachmi (:avih)]

(In reply to C. Liang [:cyliang] from comment #5)
> Production is now on commit 714d3a6b39d889fbcd21363b329b3b2b1dc47a6f.  
> 
> Can you please verify that the fix is working as intended in production?

jeads mentioned on IRC that the "fix" doesn't fix anything right now due to a jquery bug. See comment 4. This explains comment 6.

Comment 8

[C. Liang [:cyliang]]

Marking the bug as R/F.  If it turns out that this is incorrect, please re-open the bug.

Comment 9

[Avi Halachmi (:avih)]

I modified the title to what this bug is about - according to comment 0, and as such, the issue is not resolved yet.

Comment 10

[Chris Turra [:cturra]]

:avih - the latest git commit has been pushed, which was the request fulfilled by this bug (Datazilla Repository Update). as a result, i am going to remark this bug as r/fixed.

i understand there's still an issue with the with timeout loading data. to have this addressed, you'll need to file a bug with the datazilla dev team (we just assist in pushing code to stage/prod). for more details about how to do that, i would recommend chatting with :jeads.