1056017 - [Arabic] Display problem in Settings App - RTL Support Required.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Saad Dardar [:s2dar]]

Attachment: IMAG0069.jpg

User Agent: Mozilla/5.0 (Windows NT 6.3; rv:31.0) Gecko/20100101 Firefox/31.0 (Beta/Release)
Build ID: 20140716183446

Steps to reproduce:

1. In settings go to language
2. Select language as "Arabic"
3. Click "ok"
4. Go click on anything


Actual results:

Distorted display when selecting the Arabic language.


Expected results:

A normal display in Arabic

Comment 1

[Ahmed Nefzaoui [:Nefzaoui]]

I confirm it's true. I have been excepting this even though didn't get a chance to see it live. But technically this is happening.
Will see if I can build a Flatfish Gaia profile and be able to inspect it.
If so, I'll assign this to me.

Comment 2

[Stephany Wilkes]

That sounds good, Ahmed. When this is ready for review, I can flag Jenny Lee or Omega Feng as they work on Settings on our end. Thank you!

Comment 3

[Ahmed Nefzaoui [:Nefzaoui]]

Attachment: PR to Github

Will add a review? flag as soon as I'm done cleaning the code and fixing any other glitches I can find. However it's pretty much done as of now.

Adding a screenshot for a first feedback..

Comment 4

[Ahmed Nefzaoui [:Nefzaoui]]

Attachment: Screenshot - After Patch

Hey Stephany,
I'd like to get some feedback on this :)
Thanks!

Comment 5

[Stephany Wilkes]

Looks really good to me, Ahmed - thanks! When it's ready for code review we can flag a developer for review?/+. :)

Comment 6

[Ahmed Nefzaoui [:Nefzaoui]]

Comment on attachment 8492761 [details] [review]
PR to Github

Updated :)
Eventually decided to use -moz-padding-start, -end, and same for margins to reduce the change needed for RTL-specific styles on the long term.

Comment 7

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8492761 [details] [review]
PR to Github

Hi Ahmed,

this patch looks nice to me and I left some comments on Github ! Please go check it when you have time. 

There are still rooms for us to improve rtl in Flatfish and I really appreciate you just made a good start !

Thanks :)

Comment 8

[howie [:howie]]

not flatfish only

Comment 9

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

I'll help this bug.

Comment 10

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Attachment: patch on master (2.2)

Arthur, can you help me review this patch for tablet !? THanks :)

Comment 11

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8528770 [details] [review]
patch on master (2.2)

r=me with the comment addressed, thanks.

Comment 12

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

THanks all, merged into Gaia/master (2.2) : https://github.com/mozilla-b2g/gaia/commit/e18e2d06fa470db199ae885dd6f9d6e338724b89

Comment 13

[howie [:howie]]

Remove the feature b2g tag to match the new v2.2 scope.

Comment 14

[Coler]

This issue is verified successfully in latest Flame2.2.
  STRs:
      1. Chnage system language to Arabic.
      2. Check Settings app.
      **The sorts are adapted to Arabic normally.
See attachment Verify_RTL_Flame2.2.mp4

Flame 2.2 build version:

Gaia-Rev        cd42b034fd2825c3675ace3a67f5775eb61c2d60
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/d824c65a6a2b
Build-ID        20150128002506
Version         37.0a2
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150128.035910
FW-Date         Wed Jan 28 03:59:20 EST 2015
Bootloader      L1TC000118D0

Comment 15

[Coler]

Attachment: Verify_RTL_Flame2.2.MP4

Comment 16

[Lancy(Leave from Mozilla)]

Test case has been added in moztrap:
https://moztrap.mozilla.org/manage/case/15558/