1057460 - Logic for when to display /whatsnew in Firefox 33

Status: RESOLVED FIXED

(Release Engineering :: Release Requests, defect)

Description

[Holly Habstritt Gaal [:Habber]]

The following is the logic for when to display /whatsnew for users updating to Firefox 33. 

- Turn off the /whatsnew tour for users who already have the new Australis look and feel. 
- However, for users updating to the new Australis design for the first time, they should see the tour. 


* Firefox 33 - show /whatsnew for updates from 28.0 and older, but not 29.0+


We will address what to do in Firefox 34 in a later bug.

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

Does this apply to beta & release builds, or just to release ?

Comment 2

[Holly Habstritt Gaal [:Habber]]

(In reply to Nick Thomas [:nthomas] from comment #1)
> Does this apply to beta & release builds, or just to release ?

Good question. Yes, please apply this to Beta as well. 

I think it makes sense to keep our logic for Beta and Release the same unless specifically stated.

Comment 3

[Jennifer Bertsch [:jbertsch]]

(In reply to Holly Habstritt Gaal [:Habber] from comment #2)
> (In reply to Nick Thomas [:nthomas] from comment #1)
> > Does this apply to beta & release builds, or just to release ?
> 
> Good question. Yes, please apply this to Beta as well. 
> 
> I think it makes sense to keep our logic for Beta and Release the same
> unless specifically stated.

Agreed, Holly. Thanks.

Comment 4

[Nick Thomas [:nthomas] (UTC+12)]

Ben, this would be perfect use of separate property blobs, but that isn't likely to be a quick change to make. In the meantime I think we'll have to munge snippets for aus3 (perhaps we just add a place to hook in a custom script into the updates builder before uploading to aus3-staging), and when we're on Balrog manually duplicate the blob (to remove actions and openURL) and have a custom rule for version <= 28.0. Thoughts ?

Comment 5

[[e-mail] (:bhearsum)]

(In reply to Nick Thomas [:nthomas] from comment #4)
> Ben, this would be perfect use of separate property blobs, but that isn't
> likely to be a quick change to make. In the meantime I think we'll have to
> munge snippets for aus3 (perhaps we just add a place to hook in a custom
> script into the updates builder before uploading to aus3-staging), and when
> we're on Balrog manually duplicate the blob (to remove actions and openURL)
> and have a custom rule for version <= 28.0. Thoughts ?

Sorry, meant to get to this on Friday. I think this all makes sense (makes me wish we had a custom script hook for years though!). The Balrog solution isn't great, but the only quick alternatives I can think of involve hacks in the code -- duplicating the blob is clearly better than that.

Comment 6

[Nick Thomas [:nthomas] (UTC+12)]

Sorry, I forgot about this bug and we're two beta builds into Firefox 33.0 already. On the plus side, 29.0 and later don't get a whatsnew right now, and en-US for 10 through 28.0b9 (from bug 979599). Need to fill in the other locales, and make sure we're ok over when we change the update server (bug balrog-beta).

Comment 7

[Nick Thomas [:nthomas] (UTC+12)]

For beta, this is actually a one shot thing because of the watershed. 10.0 through to 28.0b* get an update to 29.0b8 before going higher, and the snippets are static. Same story in aus4 (balrog). 

Still need a plan for the release channel.

Comment 8

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: Script to modify beta snippets

Working notes:
1, grabbed a copy of 20140909-nightly-1.tar.bz2 from aus3-staging
2, in a ramdisk (for perf as it's 130k files)
 tar xf ../20140909-nightly-1.tar.bz2 Firefox.ref/{10..28}.0/*/*/*/beta
3, make a working copy
 rsync -a Firefox.ref/ Firefox/
4, rewrite snippets
 python munge.py   # see attachment
5, verified nothing unexpected was changed by diffing against Firefox.ref
6, upload to aus3-staging, check ownership & perms
7, push live

At step 4 I'm 
* removing any 'actions=silent', adding 'actions=showURL'
* removing any openURL definition, and adding
 openURL=https://www.mozilla.org/$L/firefox/29.0/whatsnew/?oldversion=%OLD_VERSION%
  where $L is the locale for the snippet. There were a small number of snippets without the OLD_VERSION query string
* removing promptWaitTime definitions from bug 829227

Comment 9

[Nick Thomas [:nthomas] (UTC+12)]

I pushed this lot live just now (FYI cc for tracy, no testing needed).

Comment 10

[Holly Habstritt Gaal [:Habber]]

(In reply to Nick Thomas [:nthomas] from comment #9)
> I pushed this lot live just now (FYI cc for tracy, no testing needed).

Thanks, Nick.

Comment 11

[Nick Thomas [:nthomas] (UTC+12)]

For the release case, we're going to need to process the snippets after they're generated.

Comment 12

[[e-mail] (:bhearsum)]

(In reply to Nick Thomas [:nthomas] from comment #11)
> For the release case, we're going to need to process the snippets after
> they're generated.

And IIRC, after switching to Balrog we'll need to duplicate release blobs w/ different properties until we figure out how to streamline it.

Comment 13

[Nick Thomas [:nthomas] (UTC+12)]

The patcher config is ready to go for the 33.0 release build. I'll post-process so that we don't get a whatsnew for 29.0 and higher.

Comment 14

[Nick Thomas [:nthomas] (UTC+12)]

Snippets are modified for 33.0 build1:
https://wiki.mozilla.org/Releases/Firefox_33.0/BuildNotes#Modify_whatsnew_pages_for_release_updates

Comment 15

[Nick Thomas [:nthomas] (UTC+12)]

Got redone for build2.

Comment 16

[Nick Thomas [:nthomas] (UTC+12)]

A 33.0.1 release is looking likely, presumably we add 33.0 to the list of versions which should not get a whatsnew page after update.

Comment 17

[Holly Habstritt Gaal [:Habber]]

(In reply to Nick Thomas [:nthomas] from comment #16)
> A 33.0.1 release is looking likely, presumably we add 33.0 to the list of
> versions which should not get a whatsnew page after update.

Agreed. 33.0+ will not need to see the /whatsnew page until the 34.0 update (bug 1102419).