The default bug view has changed. See this FAQ.

Logic for when to display /whatsnew in Firefox 33

RESOLVED FIXED

Status

Release Engineering
Releases
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: Habber, Assigned: nthomas)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
The following is the logic for when to display /whatsnew for users updating to Firefox 33. 

- Turn off the /whatsnew tour for users who already have the new Australis look and feel. 
- However, for users updating to the new Australis design for the first time, they should see the tour. 


* Firefox 33 - show /whatsnew for updates from 28.0 and older, but not 29.0+


We will address what to do in Firefox 34 in a later bug.
(Reporter)

Updated

3 years ago
Version: unspecified → other
(Assignee)

Comment 1

3 years ago
Does this apply to beta & release builds, or just to release ?
(Reporter)

Comment 2

3 years ago
(In reply to Nick Thomas [:nthomas] from comment #1)
> Does this apply to beta & release builds, or just to release ?

Good question. Yes, please apply this to Beta as well. 

I think it makes sense to keep our logic for Beta and Release the same unless specifically stated.
(In reply to Holly Habstritt Gaal [:Habber] from comment #2)
> (In reply to Nick Thomas [:nthomas] from comment #1)
> > Does this apply to beta & release builds, or just to release ?
> 
> Good question. Yes, please apply this to Beta as well. 
> 
> I think it makes sense to keep our logic for Beta and Release the same
> unless specifically stated.

Agreed, Holly. Thanks.
(Assignee)

Comment 4

3 years ago
Ben, this would be perfect use of separate property blobs, but that isn't likely to be a quick change to make. In the meantime I think we'll have to munge snippets for aus3 (perhaps we just add a place to hook in a custom script into the updates builder before uploading to aus3-staging), and when we're on Balrog manually duplicate the blob (to remove actions and openURL) and have a custom rule for version <= 28.0. Thoughts ?
Flags: needinfo?(bhearsum)
(In reply to Nick Thomas [:nthomas] from comment #4)
> Ben, this would be perfect use of separate property blobs, but that isn't
> likely to be a quick change to make. In the meantime I think we'll have to
> munge snippets for aus3 (perhaps we just add a place to hook in a custom
> script into the updates builder before uploading to aus3-staging), and when
> we're on Balrog manually duplicate the blob (to remove actions and openURL)
> and have a custom rule for version <= 28.0. Thoughts ?

Sorry, meant to get to this on Friday. I think this all makes sense (makes me wish we had a custom script hook for years though!). The Balrog solution isn't great, but the only quick alternatives I can think of involve hacks in the code -- duplicating the blob is clearly better than that.
Flags: needinfo?(bhearsum)
(Assignee)

Comment 6

3 years ago
Sorry, I forgot about this bug and we're two beta builds into Firefox 33.0 already. On the plus side, 29.0 and later don't get a whatsnew right now, and en-US for 10 through 28.0b9 (from bug 979599). Need to fill in the other locales, and make sure we're ok over when we change the update server (bug balrog-beta).
Assignee: nobody → nthomas
OS: Mac OS X → All
(Assignee)

Comment 7

3 years ago
For beta, this is actually a one shot thing because of the watershed. 10.0 through to 28.0b* get an update to 29.0b8 before going higher, and the snippets are static. Same story in aus4 (balrog). 

Still need a plan for the release channel.
(Assignee)

Comment 8

3 years ago
Created attachment 8487595 [details]
Script to modify beta snippets

Working notes:
1, grabbed a copy of 20140909-nightly-1.tar.bz2 from aus3-staging
2, in a ramdisk (for perf as it's 130k files)
 tar xf ../20140909-nightly-1.tar.bz2 Firefox.ref/{10..28}.0/*/*/*/beta
3, make a working copy
 rsync -a Firefox.ref/ Firefox/
4, rewrite snippets
 python munge.py   # see attachment
5, verified nothing unexpected was changed by diffing against Firefox.ref
6, upload to aus3-staging, check ownership & perms
7, push live

At step 4 I'm 
* removing any 'actions=silent', adding 'actions=showURL'
* removing any openURL definition, and adding
 openURL=https://www.mozilla.org/$L/firefox/29.0/whatsnew/?oldversion=%OLD_VERSION%
  where $L is the locale for the snippet. There were a small number of snippets without the OLD_VERSION query string
* removing promptWaitTime definitions from bug 829227
(Assignee)

Comment 9

3 years ago
I pushed this lot live just now (FYI cc for tracy, no testing needed).
(Reporter)

Comment 10

3 years ago
(In reply to Nick Thomas [:nthomas] from comment #9)
> I pushed this lot live just now (FYI cc for tracy, no testing needed).

Thanks, Nick.
Blocks: 1056837
(Assignee)

Comment 11

3 years ago
For the release case, we're going to need to process the snippets after they're generated.
(In reply to Nick Thomas [:nthomas] from comment #11)
> For the release case, we're going to need to process the snippets after
> they're generated.

And IIRC, after switching to Balrog we'll need to duplicate release blobs w/ different properties until we figure out how to streamline it.
(Assignee)

Comment 13

3 years ago
The patcher config is ready to go for the 33.0 release build. I'll post-process so that we don't get a whatsnew for 29.0 and higher.
(Assignee)

Comment 14

3 years ago
Snippets are modified for 33.0 build1:
https://wiki.mozilla.org/Releases/Firefox_33.0/BuildNotes#Modify_whatsnew_pages_for_release_updates
(Assignee)

Comment 15

3 years ago
Got redone for build2.
(Assignee)

Updated

3 years ago
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
(Assignee)

Comment 16

3 years ago
A 33.0.1 release is looking likely, presumably we add 33.0 to the list of versions which should not get a whatsnew page after update.
Blocks: 1085526
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Updated

2 years ago
Blocks: 1089928
(Assignee)

Updated

2 years ago
Status: REOPENED → RESOLVED
Last Resolved: 3 years ago2 years ago
Resolution: --- → FIXED
(Reporter)

Comment 17

2 years ago
(In reply to Nick Thomas [:nthomas] from comment #16)
> A 33.0.1 release is looking likely, presumably we add 33.0 to the list of
> versions which should not get a whatsnew page after update.

Agreed. 33.0+ will not need to see the /whatsnew page until the 34.0 update (bug 1102419).
You need to log in before you can comment on or make changes to this bug.