203.22 KB, image/png
1.40 KB, patch
|Details | Diff | Splinter Review|
I installed the Theme kanagawa wave (1.0). It does not show up in the Add-on Manager. I restarted Nightly and it appears. I was able to reproduce the bug by removing the theme, reinstalling, and going back to the Add-on Manager.
That's weird, it looks like we should be doing that: http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/aboutAddons.js#248 I think this is a regression. I can't reproduce in release, but I can in beta. The only change in that period I see is bug 1010096, maybe that caused it :/
Actually, I just tried reproducing this on my local build of fx-team, and I'm seeing the theme listed. Maybe something weird is going on here.
On Nightly (08/26) on my Galaxy S5: On a fresh install, I installed Arrows Blue 1.0 and it appeared right away. On a fresh install, I installed Kanagawa Wave 1.0 and it appeared right away. After installing any theme, any other themes installed for some reason do not appear in the add-on listing.
Summary: After installing a Theme Add-on, Theme does not show up in Add-on manager → Additional installed themes do not appear in Add-On manager listing after initial theme installed
Or maybe in the case of the screenshot attached, having any add-on or theme in the listing prior as a prerequesite (ABP in this case).
Summary: Additional installed themes do not appear in Add-On manager listing after initial theme installed → Additional installed themes do not appear in Add-On manager listing after an initial theme or add-on installed
Can you tell if this is a regression? Are you able to reproduce in release? Also, do you see any errors in the log? I wonder if some change in in AddonManager.jsm could have caused this problem.
I'm seeing an opposite problem happening with my Firefox Privacy Coach add-on, where when I uninstall the add-on (which uninstalls a theme), the theme sticks around until I revisit AMO. I think we may be missing a listener for installed theme changes, or we may be missing one.
It was easy to reproduce this by installing/uninstalling the privacy coach add-on while about:addons was opened. It think whether or not about:addons is open in a background tab is the key way to reproduce this. LightweightThemeManager calls onInstalled/onUninstalled: http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/extensions/LightweightThemeManager.jsm#612 http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/extensions/LightweightThemeManager.jsm#690 So we need to add listeners to handle that in about:addons.
Assignee: nobody → margaret.leibovic
Attachment #8499842 - Flags: review?(mark.finkle)
Comment on attachment 8499842 [details] [diff] [review] Properly listen for lightweight theme install/uninstall in about:addons I am shocked that we never had this code
Attachment #8499842 - Flags: review?(mark.finkle) → review+
(In reply to :Margaret Leibovic from comment #7) > LightweightThemeManager calls onInstalled/onUninstalled: > http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/extensions/ > LightweightThemeManager.jsm#612 > http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/extensions/ > LightweightThemeManager.jsm#690 > > So we need to add listeners to handle that in about:addons. Ah, it's LWT specific and we never really tested just LWTs. Nice catch.
I tried reading through the add-on manager code to see where different types of listeners are called, but it's hard to follow. It might be worth coming up with some different testcases to see if there's anything else we're doing wrong, but we can just be on the lookout for bug reports if people start to use add-ons more. https://hg.mozilla.org/integration/fx-team/rev/e06807007c5c
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
You need to log in before you can comment on or make changes to this bug.