1059843 - (non-standard-js) Stop using non-standard SpiderMonkey extensions in Thunderbird JS code [meta]

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Joshua Cranmer [:jcranmer]]

The things I saw most recently as being investigated for removal:

* Old style generators (yield in non-function*, Iterator)
* for each loops

(Might [x for (x of arr)] instead of [for (x of arr) x] be involved as well?)

Comment 1

[Joshua Cranmer [:jcranmer]]

Bug 1054630 has a better list of extensions:
* destructuring for-in
* for-each
* legacy generator
* expression closures [I think this is function () x ?]

Comment 2

[Joshua Cranmer [:jcranmer]]

There's also let blocks: <https://dxr.mozilla.org/comm-central/search?q=regexp%3A%22let\s*\%28%22+-path%3Amozilla&case=true>. Interestingly, of the 11 uses, 3 of them seem to be copy-paste clones.

Comment 3

[:aceman]

We have a ton of for..in usage with fixIterator(). Do you know how to rewrite that function so it can be used with for..of? Should I file that bug?

Comment 4

[:aceman]

Actually it is already the bug 824104. Could you help there?

Comment 5

[Joshua Cranmer [:jcranmer]]

(In reply to :aceman from comment #3)
> We have a ton of for..in usage with fixIterator(). Do you know how to
> rewrite that function so it can be used with for..of? Should I file that bug?

I have a prototype patch that should make fixIterator simultaneously usable with for..in and for..of.

Comment 6

[Masatoshi Kimura [:emk]]

The platform already removed JavaScript versions.