Bug 1059843 (non-standard-js)

Stop using non-standard SpiderMonkey extensions in Thunderbird JS code [meta]

RESOLVED FIXED

Status

RESOLVED FIXED
4 years ago
9 months ago

People

(Reporter: jcranmer, Unassigned)

Tracking

(Depends on: 1 bug, Blocks: 1 bug, {meta})

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

4 years ago
The things I saw most recently as being investigated for removal:

* Old style generators (yield in non-function*, Iterator)
* for each loops

(Might [x for (x of arr)] instead of [for (x of arr) x] be involved as well?)
(Reporter)

Comment 1

4 years ago
Bug 1054630 has a better list of extensions:
* destructuring for-in
* for-each
* legacy generator
* expression closures [I think this is function () x ?]

Updated

4 years ago
Alias: non-standard-js
(Reporter)

Updated

4 years ago
Blocks: 867617
Depends on: 1118263
(Reporter)

Comment 2

4 years ago
There's also let blocks: <https://dxr.mozilla.org/comm-central/search?q=regexp%3A%22let\s*\%28%22+-path%3Amozilla&case=true>. Interestingly, of the 11 uses, 3 of them seem to be copy-paste clones.
(Reporter)

Updated

4 years ago
Depends on: 1117060

Comment 3

4 years ago
We have a ton of for..in usage with fixIterator(). Do you know how to rewrite that function so it can be used with for..of? Should I file that bug?

Updated

4 years ago
OS: Linux → All
Hardware: x86_64 → All

Comment 4

4 years ago
Actually it is already the bug 824104. Could you help there?
(Reporter)

Comment 5

4 years ago
(In reply to :aceman from comment #3)
> We have a ton of for..in usage with fixIterator(). Do you know how to
> rewrite that function so it can be used with for..of? Should I file that bug?

I have a prototype patch that should make fixIterator simultaneously usable with for..in and for..of.
(Reporter)

Updated

4 years ago
Depends on: 1123117
(Reporter)

Updated

4 years ago
See Also: → bug 1103158
(Reporter)

Updated

4 years ago
Depends on: 1123118
(Reporter)

Updated

4 years ago
Depends on: 1123119
(Reporter)

Updated

4 years ago
Depends on: 1123122
(Reporter)

Updated

4 years ago
Depends on: 1123124

Updated

4 years ago
Keywords: meta
Summary: Stop using non-standard SpiderMonkey extensions in Thunderbird JS code → Stop using non-standard SpiderMonkey extensions in Thunderbird JS code [meta]

Updated

4 years ago
Depends on: 1121727
The platform already removed JavaScript versions.
Status: NEW → RESOLVED
Last Resolved: 9 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.