1061335 - Switch builders to VS2013

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[(Away)]

Thanks to jlund for the original patch. I've split it apart so that we can get the supporting pieces into the tree before actually flipping the switch.

Comment 1

[(Away)]

Attachment: Part 1: Rename mozconfig.vs2010-common to mozconfig.vs-common

Comment 2

[(Away)]

Attachment: Part 2: Add in-tree mozconfigs for VS2013 (these are not yet active)

Comment 3

[(Away)]

Part 2 is actually an |hg cp| with changes on top (Bugzilla doesn't show this very well).

Comment 4

[(Away)]

Attachment: Part 3: Switch in-tree mozconfigs to VS2013 (DON'T LAND YET)

Comment 5

[Mike Hommey [:glandium]]

Comment on attachment 8482423 [details] [diff] [review]
Part 3: Switch in-tree mozconfigs to VS2013 (DON'T LAND YET)

Review of attachment 8482423 [details] [diff] [review]:
-----------------------------------------------------------------

::: b2g/config/mozconfigs/win32_gecko/debug
@@ +19,2 @@
>  else
>    . $topsrcdir/build/win32/mozconfig.vs2010

Why not change this too?

Comment 6

[(Away)]

(In reply to Mike Hommey [:glandium] (out from Sep 6 to Sep 22) from comment #5)
> Comment on attachment 8482423 [details] [diff] [review]
> Part 3: Switch in-tree mozconfigs to VS2013 (DON'T LAND YET)
> 
> Review of attachment 8482423 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: b2g/config/mozconfigs/win32_gecko/debug
> @@ +19,2 @@
> >  else
> >    . $topsrcdir/build/win32/mozconfig.vs2010
> 
> Why not change this too?

I wondered the same thing over in bug 1009807. Apparently we don't use win32 builders anymore. Those lines might be for Seamonkey.

Comment 7

[(Away)]

Pushed the supporting pieces. This will make VS2013 try pushes very easy.

https://hg.mozilla.org/integration/mozilla-inbound/rev/fe99aeb6ae65
https://hg.mozilla.org/integration/mozilla-inbound/rev/d45a41039ece

Comment 8

[Jordan Lund (:jlund)]

ah cool, hopefully that makes it easier to do quick tests on try.

I'm in the middle of trying to clear up some points of confusion: namely win regressions and varying vs2013 versions

I'm sending out an email right now to folks from build, relops, and sheriffs. But until we have a unified understanding and plan going forward, could we hold off on actually pulling the trigger on this?

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/fe99aeb6ae65
https://hg.mozilla.org/mozilla-central/rev/d45a41039ece

Comment 10

[(Away)]

> But until we have a unified understanding and plan going forward,
> could we hold off on actually pulling the trigger on this?

Yes, I agree. I'm not planning to push the final piece until we're completely ready.

Comment 11

[(Away)]

Comment on attachment 8482423 [details] [diff] [review]
Part 3: Switch in-tree mozconfigs to VS2013 (DON'T LAND YET)

I'm flagging this since glandium will be away for a while. I'm not planning to land it yet.

Comment 12

[(Away)]

Attachment: Part 3: Switch in-tree mozconfigs to VS2013 (DON'T LAND YET)

compare-mozconfigs.py pointed out that I missed one under Win64.

Carrying forward r=glandium.

Comment 13

[(Away)]

Attachment: Part 3: Switch in-tree mozconfigs to VS2013

Removed the Win64 mozconfigs as they have been landed in bug 1080074. Carrying forward r=glandium from previous patch. sr=bsmedberg by IRC.

Try: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=704087ef0991
PGO: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=df44e744f079
Bn: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=77258e23750e

Comment 14

[(Away)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ea2ea74d0e33

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ea2ea74d0e33

Comment 16

[Masatoshi Kimura [:emk]]

Forgot to remove leave-open?

Comment 17

[Gary [:streetwolf52]]

Flash videos stopped working with this patch based on some regression testing I did. I'm running the latest Flash beta 15.0.0.199.

 Mozilla/5.0 (Windows NT 6.3; WOW64; rv:36.0) Gecko/20100101 Firefox/36.0

Comment 18

[Gary [:streetwolf52]]

Regression results:

20141013192600
https://hg.mozilla.org/integration/mozilla-inbound/rev/e0c4c804b279  - Good

20141013195601
https://hg.mozilla.org/integration/mozilla-inbound/rev/ea2ea74d0e33  - Bad

Comment 19

[Gary [:streetwolf52]]

Opened up new bug report https://bugzilla.mozilla.org/show_bug.cgi?id=1082670

Comment 20

[(Away)]

> Forgot to remove leave-open?
Good catch.