1061473 - [Flame][Dual SIM] Outgoing call from bluetooth car kit asked which SIM card to use

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Nicolas Delebecque (:nicodel)]

Device: Flame
Version: 2.1.0.0-prerelease (20140901160203)

Steps to reproduce:
Insert one SIM card in your dual SIM phone (Flame) inside SIM 1 slot.
In Settings, make sure outgoing calls are routed to SIM 1.
Connect your phone to your car kit using bluetooth.
Dial a phone number from your car kit (while not driving!), and not from your phone.
Launch call from your car kit.

Actual results:
Nothing happens! Car kit (depending on each one) says that calls cannot be made.
Look at your phone, if you are on the home screen nothing is displayed and no new notifications appeared.
Open the dialer application, it asks for the user to choose which SIM to call from, with only one choice: SIM 1...
Tap on SIM 1 choice on the phone, and the call is being made, if not the call is not made.
In this situation, driver has to take the phone in his hands in order to make calls which is not really taking advantages of bluetooth car kit.

Expected results:
Phone number should be dialed without asking the user to choose with which SIM card it has to be made, like it is being done when the call is made from the phone.
And if a choice has to be made, the dialer application should be open automatically for the user to understand what is going on, and to choose from which SIM card he wants to call.

Comment 1

[Anthony Ricaud (:rik)]

We have two issues here. Let's fix the fact that it always asks which SIM to use instead of dialing when a preferred one is set. I've opened bug 1062294 for that one.

Comment 2

[Anthony Ricaud (:rik)]

The issue lies in https://github.com/mozilla-b2g/gaia/blob/9e863e957416c039c674d7d36f5a925b9c99fe93/apps/communications/dialer/js/dialer.js#L379-L385

Comment 3

[Doug Sherk (:drs) (inactive)]

Attachment: Fix SIM picker being shown for Bluetooth calls when a user preferred SIM is set.

PR: https://github.com/mozilla-b2g/gaia/pull/23688

Comment 4

[Doug Sherk (:drs) (inactive)]

https://github.com/mozilla-b2g/gaia/commit/faa59403d66145b6eb7ed69fa5c04d8eda7fc228

Comment 5

[Kai-Zhen Li [:seinlin][:kli]]

v2.0m: https://github.com/mozilla-b2g/gaia/commit/3781145e09e0dcde7c613d60728d60996206ad1a