1061489 - [Bluetooth] Separate BluetoothInterface from actual implementation

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Thomas Zimmermann [:tzimmermann] [:tdz]]

BluetoothInterface.{cpp,h} currently implement Bluedroid support. We want to have support for multiple backends, especially a Bluetooth daemon. So the interface and the current Bluedroid code have to be separated from each other.

Comment 1

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [01] Bug 1061489: Move Bluedroid code out of BluetoothInterface.{cpp,h}

No functional changes. This patch just moves code around.

Comment 2

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [02] Bug 1061489: Distribute Bluetooth HAL implementation among multiple files

Again, no functional changes. This patch also cleans up indention errors that were accidentally introduced by the first patch.

Comment 3

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Comment on attachment 8483469 [details] [diff] [review]
[02] Bug 1061489: Distribute Bluetooth HAL implementation among multiple files

Review of attachment 8483469 [details] [diff] [review]:
-----------------------------------------------------------------

Can we rename Bluetooth*Manager to Blutooth*HALInterface.cpp? And then add additional patches on topic of them. Otherwise, it will be better to keep git history.

Comment 4

[Thomas Zimmermann [:tzimmermann] [:tdz]]

(In reply to Shawn Huang [:shawnjohnjr] from comment #3)
> Comment on attachment 8483469 [details] [diff] [review]
> [02] Bug 1061489: Distribute Bluetooth HAL implementation among multiple
> files
> 
> Review of attachment 8483469 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Can we rename Bluetooth*Manager to Blutooth*HALInterface.cpp? And then add
> additional patches on topic of them. Otherwise, it will be better to keep
> git history.

I don't get the point, because those are two different things. The interfaces are really just interfaces. The managers instead maintain state.

For the daemon, I only want to re-implement the interfaces, but not the managers.

Comment 5

[Thomas Zimmermann [:tzimmermann] [:tdz]]

BTW My plan is to later add a |BluetoothInterface| for BlueZ 4 as well. At that point, most manager classes can be merged with their base class, so the current multitude of Bluetooth*Manager classes will go away.

Comment 6

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Hi Shawn,

What's the status here? I'm not sure what to make of your last comment.

Comment 7

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

(In reply to Thomas Zimmermann [:tzimmermann] [:tdz] from comment #4)
> (In reply to Shawn Huang [:shawnjohnjr] from comment #3)
> > Comment on attachment 8483469 [details] [diff] [review]
> > [02] Bug 1061489: Distribute Bluetooth HAL implementation among multiple
> > files
> > 
> > Review of attachment 8483469 [details] [diff] [review]:
> > -----------------------------------------------------------------
> > 
> > Can we rename Bluetooth*Manager to Blutooth*HALInterface.cpp? And then add
> > additional patches on topic of them. Otherwise, it will be better to keep
> > git history.
> 
> I don't get the point, because those are two different things. The
> interfaces are really just interfaces. The managers instead maintain state.
> 
> For the daemon, I only want to re-implement the interfaces, but not the
> managers.

Sorry, it seems to me I lost my mind. I'm wrong.

Comment 8

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Thanks Shawn

https://hg.mozilla.org/integration/b2g-inbound/rev/8644a9c4b993
https://hg.mozilla.org/integration/b2g-inbound/rev/e2e2e6397253

https://tbpl.mozilla.org/?tree=B2g-Inbound&rev=e2e2e6397253

Comment 9

[Carsten Book [:Tomcat]]

sorry had to back this out since this caused a bustage like https://tbpl.mozilla.org/php/getParsedLog.php?id=47859290&tree=B2g-Inbound

Comment 10

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [03] Bug 1061489: Updating CLOBBER

Comment 11

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

(In reply to Carsten Book [:Tomcat] from comment #9)
> sorry had to back this out since this caused a bustage like
> https://tbpl.mozilla.org/php/getParsedLog.php?id=47859290&tree=B2g-Inbound

This caused by non-clean build environment. Comment 10 had already added CLOBBER change.

Comment 12

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Next try...

https://hg.mozilla.org/integration/b2g-inbound/rev/8c49d78239d1
https://hg.mozilla.org/integration/b2g-inbound/rev/63de503e22c3
https://hg.mozilla.org/integration/b2g-inbound/rev/e1d819297fe4

https://tbpl.mozilla.org/?tree=B2g-Inbound&rev=e1d819297fe4

Comment 13

[(PTO June 19-July 7) Ryan VanderMeulen]

https://hg.mozilla.org/mozilla-central/rev/8c49d78239d1
https://hg.mozilla.org/mozilla-central/rev/63de503e22c3
https://hg.mozilla.org/mozilla-central/rev/e1d819297fe4