1065336 - [Bluetooth] Add support for Bluedroid daemon to Gecko

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Thomas Zimmermann [:tzimmermann] [:tdz]]

We need to implement |BluetoothInterface| for the Bluedroid daemon.

Comment 1

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

AFAIK, all gecko daemon related patches changes landed. Close it.

Comment 2

[Thomas Zimmermann [:tzimmermann] [:tdz]]

(In reply to Shawn Huang [:shawnjohnjr] from comment #1)
> AFAIK, all gecko daemon related patches changes landed. Close it.

Not yet. :( There's still a clean up patch required for the initialization and the daemon backend must be switched on.

Comment 3

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

(In reply to Thomas Zimmermann [:tzimmermann] [:tdz] from comment #2)
> (In reply to Shawn Huang [:shawnjohnjr] from comment #1)
> > AFAIK, all gecko daemon related patches changes landed. Close it.
> 
> Not yet. :( There's still a clean up patch required for the initialization
> and the daemon backend must be switched on.
Opps! I thought you're going to track them in an another bug. Thanks for correction.

Comment 4

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [01] Bug 1065336: Implement Bluetooth backend selection; use daemon by default

That's the final patch for the first complete version of bluetoothd. Once it lands, Gecko will refer to the daemon for Bluetooth functionality.

Comment 5

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Comment on attachment 8550229 [details] [diff] [review]
[01] Bug 1065336: Implement Bluetooth backend selection; use daemon by default

Review of attachment 8550229 [details] [diff] [review]:
-----------------------------------------------------------------

It looks good to me.

Comment 6

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Landing this patch. Thanks, Shawn!

https://hg.mozilla.org/integration/b2g-inbound/rev/9abbd96020cd

https://treeherder.mozilla.org/ui/#/jobs?repo=b2g-inbound&revision=9abbd96020cd

Comment 7

[(PTO June 19-July 7) Ryan VanderMeulen]

https://hg.mozilla.org/mozilla-central/rev/9abbd96020cd

Comment 8

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Comment on attachment 8550229 [details] [diff] [review]
[01] Bug 1065336: Implement Bluetooth backend selection; use daemon by default

Review of attachment 8550229 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bluetooth/BluetoothInterface.cpp
@@ +103,5 @@
> +#else
> +#ifdef MOZ_B2G_BT_BLUEDROID
> +  static const char sDefaultBackend[] = "bluedroid";
> +#else
> +  static const char const * sDefaultBackend = nullptr;

../../../gecko/dom/bluetooth/BluetoothInterface.cpp:107:3: error: duplicate 'const'
Duplicate 'const' cause build break if system/bluetoothd and external/bluetooth/bluedroid does not exist. Please update the patch for v2.2. and fix for m-c, thank you.

Comment 9

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

(In reply to Shawn Huang [:shawnjohnjr] from comment #8)
> Comment on attachment 8550229 [details] [diff] [review]
> [01] Bug 1065336: Implement Bluetooth backend selection; use daemon by
> default
> 
> Review of attachment 8550229 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: dom/bluetooth/BluetoothInterface.cpp
> @@ +103,5 @@
> > +#else
> > +#ifdef MOZ_B2G_BT_BLUEDROID
> > +  static const char sDefaultBackend[] = "bluedroid";
> > +#else
> > +  static const char const * sDefaultBackend = nullptr;
> 
> ../../../gecko/dom/bluetooth/BluetoothInterface.cpp:107:3: error: duplicate
> 'const'
> Duplicate 'const' cause build break if system/bluetoothd and
> external/bluetooth/bluedroid does not exist. Please update the patch for
> v2.2. and fix for m-c, thank you.

Let me clarify again to avoid misunderstanding, this build break won't happen under the current build configuration because bluedroid is the default choice for JB/KK. But considering some people are missing these two folders (they probably did not sync codebase for a while), we shall fix this potential build break. Sorry I missed this error during code review.

Comment 10

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Shawn, please see bug 1124565.

Comment 11

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Comment on attachment 8550229 [details] [diff] [review]
[01] Bug 1065336: Implement Bluetooth backend selection; use daemon by default

Oh, I forgot to set the flag.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 

Bug 1005934

User impact if declined: 

We won't be able to use the Bluetooth daemon on v2.2.

Testing completed: 

We manually tested Bluetooth on our local machines.

Risk to taking this patch (and alternatives if risky): 

The change of this single patch is small. The overall feature is v2.2+ already.

String or UUID changes made by this patch:

None.

Comment 12

[(PTO June 19-July 7) Ryan VanderMeulen]

https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/7dffadac7c32