Closed Bug 1061506 Opened 10 years ago Closed 10 years ago

Icons in contact edit form looking a bit fuzzy

Categories

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Contacts
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:2.1+, b2g-v2.1 verified, b2g-v2.2 verified)

Status:
VERIFIED FIXED
Milestone:
2.1 S4 (12sep)
Project Flags:
blocking-b2g 2.1+
Tracking Flags:
Tracking Status
b2g-v2.1 --- verified
b2g-v2.2 --- verified

People

(Reporter: sergi, Assigned: sergi)

References

Details

(Keywords: regression, Whiteboard: P=3)

Attachments

(2 files, 1 obsolete file)

Before/After
54.41 KB, image/png
Details
https://github.com/mozilla-b2g/gaia/pull/23861
46 bytes, text/x-github-pull-request
arcturus
: review+
fabrice
: approval-gaia-v2.1+
Details | Review 
      No description provided.
Assignee: nobody → sergi.mansilla
Whiteboard: P=3
Target Milestone: --- → 2.1 S4 (12sep)
This is a very simple, low-risk fix that improves user experience a lot.
blocking-b2g: --- → 2.1?
Sergi,
Could you provide a screenshot and more information?
Flags: needinfo?(sergi.mansilla)
triage: major issue to new feature "contacts form redesign".
Functionality-wise it works properly, but this fix(polish) is must-have to make the feature shiny.
blocking-b2g: 2.1? → 2.1+
Keywords: regression
Attached file Github PR (obsolete) — 

        Attachment #8486342 -
        Flags: review?(francisco)
Flags: needinfo?(sergi.mansilla)

    
    

    
  

      
      
      
      

        Attached image
          
        Before/After
        — 
      

    


  

    
    

    
  
Comment on attachment 8486342 [details] [review]
Github PR

Perfect job :)

Thanks Sergi

        Attachment #8486342 -
        Flags: review?(francisco) → review+

    
    

    
  
Merged at bafd6f501dc1c588867c30fc3fe58c759022dc7a
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED

    
    

    
  
Sorry, had to revert cause of some linter problems:

https://github.com/mozilla-b2g/gaia/commit/bedd277bf39980bb6420bd83333448d4314a7451
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

    
    

    
  


  

        Attachment #8486342 -
        Attachment is obsolete: true

        Attachment #8486481 -
        Flags: review?(francisco)

    
    

    
  
Comment on attachment 8486481 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/23861

Looking good, let's wait for the gaia-try works to finish and let's get in again :)

        Attachment #8486481 -
        Flags: review?(francisco) → review+

    
    

    
  
Finally landed:

https://github.com/mozilla-b2g/gaia/commit/14f4b2396d51826ea682bece58065c0ea2bddf90
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED

    
    

    
  
Please request Gaia v2.1 approval on this when you get a chance.

          status-b2g-v2.1:
          --- → affected

          status-b2g-v2.2:
          --- → fixed
Flags: needinfo?(sergi.mansilla)

    
    

    
  
Comment on attachment 8486481 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/23861

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
Contacts form redesing
[User impact] if declined:
Horrible user expericen. User will likely jump through the window when seeing the contact form like this.
[Testing completed]:
Smoke test passed on a flame device
[Risk to taking this patch] (and alternatives if risky):
Minimun,just css rules
[String changes made]:

        Attachment #8486481 -
        Flags: approval-gaia-v2.1?(fabrice)

        Attachment #8486481 -
        Flags: approval-gaia-v2.1?(fabrice) → approval-gaia-v2.1+

    
    

    
  
Tested and working
Flame
2.1
Gecko:c0b6c35
Gaia:fe8298a
Status: RESOLVED → VERIFIED

    
    

    
  
(In reply to Loli (:lolimartinezcr) from comment #23)
> Tested and working
> Flame
> 2.2
> Gecko:c0b6c35
> Gaia:fe8298a

Tested and workgin
Flame
2.1
Gecko: 3953700
Gaia: 713448b

    
    

    
  
Issue is verified fixed on the 2.2 flame and 2.1 flame 

There is no overlap of the icons in contacts edit screen, also the icons are not fuzzy/blurry 

Flame 2.2

Device: Flame 2.2 Master KK (319mb) (Full Flash)
BuildID: 20141017040208
Gaia: abef62c0623e5504a97b4fd411e879a67b285b52
Gecko: ae1dfa192faf
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 36.0a1 (2.2 Master)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

Flame 2.1

Device: Flame 2.1 KK (319mb) (Full Flash)
BuildID: 20141017001201
Gaia: 1ea74943cfe525c76a074ca1d7de8e51a70f6b98
Gecko: 2befa902ff5c
Gonk: 05aa7b98d3f891b334031dc710d48d0d6b82ec1d
Version: 34.0 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

          status-b2g-v2.1:
          fixed → verified

          status-b2g-v2.2:
          fixed → verified
Flags: needinfo?(ktucker)
QA Whiteboard: [QAnalyst-Triage+]
Flags: needinfo?(ktucker)

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: