1061506 - Icons in contact edit form looking a bit fuzzy

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Comment 1

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

This is a very simple, low-risk fix that improves user experience a lot.

Comment 2

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

Sergi,
Could you provide a screenshot and more information?

Comment 3

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

triage: major issue to new feature "contacts form redesign".
Functionality-wise it works properly, but this fix(polish) is must-have to make the feature shiny.

Comment 6

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

Attachment: Github PR

Comment 7

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

Attachment: Before/After

Comment 8

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8486342 [details] [review]
Github PR

Perfect job :)

Thanks Sergi

Comment 9

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

Merged at bafd6f501dc1c588867c30fc3fe58c759022dc7a

Comment 10

[Francisco Jordano [:arcturus] [:francisco]]

Sorry, had to revert cause of some linter problems:

https://github.com/mozilla-b2g/gaia/commit/bedd277bf39980bb6420bd83333448d4314a7451

Comment 11

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/23861

Comment 12

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8486481 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/23861

Looking good, let's wait for the gaia-try works to finish and let's get in again :)

Comment 13

[Francisco Jordano [:arcturus] [:francisco]]

Finally landed:

https://github.com/mozilla-b2g/gaia/commit/14f4b2396d51826ea682bece58065c0ea2bddf90

Comment 14

[Ryan VanderMeulen (PTO, back July 27)]

Please request Gaia v2.1 approval on this when you get a chance.

Comment 15

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8486481 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/23861

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
Contacts form redesing
[User impact] if declined:
Horrible user expericen. User will likely jump through the window when seeing the contact form like this.
[Testing completed]:
Smoke test passed on a flame device
[Risk to taking this patch] (and alternatives if risky):
Minimun,just css rules
[String changes made]:

Comment 22

[Ryan VanderMeulen (PTO, back July 27)]

v2.1: https://github.com/mozilla-b2g/gaia/commit/1247221c4293607daada56a0fbca06f81ac4abcc

Comment 23

[Loli (:lolimartinezcr)]

Tested and working
Flame
2.1
Gecko:c0b6c35
Gaia:fe8298a

Comment 24

[Loli (:lolimartinezcr)]

(In reply to Loli (:lolimartinezcr) from comment #23)
> Tested and working
> Flame
> 2.2
> Gecko:c0b6c35
> Gaia:fe8298a

Tested and workgin
Flame
2.1
Gecko: 3953700
Gaia: 713448b

Comment 25

[[:RJ]]

Issue is verified fixed on the 2.2 flame and 2.1 flame 

There is no overlap of the icons in contacts edit screen, also the icons are not fuzzy/blurry 

Flame 2.2

Device: Flame 2.2 Master KK (319mb) (Full Flash)
BuildID: 20141017040208
Gaia: abef62c0623e5504a97b4fd411e879a67b285b52
Gecko: ae1dfa192faf
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 36.0a1 (2.2 Master)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

Flame 2.1

Device: Flame 2.1 KK (319mb) (Full Flash)
BuildID: 20141017001201
Gaia: 1ea74943cfe525c76a074ca1d7de8e51a70f6b98
Gecko: 2befa902ff5c
Gonk: 05aa7b98d3f891b334031dc710d48d0d6b82ec1d
Version: 34.0 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0