1061888 - Update Shumway to version 0.9.2669

Status: RESOLVED FIXED

(Firefox Graveyard :: Shumway, defect)

Description

[Yury Delendik (:yury)]

Upgrades Shumway to the latest github master code

Comment 1

[Yury Delendik (:yury)]

Attachment: Update Shumway to version 0.9.2680

Comment 2

[Till Schneidereit [:till]]

Comment on attachment 8483114 [details] [diff] [review]
Update Shumway to version 0.9.2680

Review of attachment 8483114 [details] [diff] [review]:
-----------------------------------------------------------------

One thing we can do to reduce the size of the patch quite substantially (I hope at least) is to let tsc remove comments during compilation. I kinda like having them for debugging purposes, so ideally we'd only do that when compiling for bundling purposes, but if that's harder to do, then let's just remove them entirely. tsc has a setting for that.

Other than that, looks good, so r=me with the enableVerifier thing explained or fixed.

::: browser/extensions/shumway/content/ShumwayTelemetry.jsm
@@ +1,1 @@
> +/* -*- Mode: Java; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- */

We should just go through and remove these mode lines everywhere. Not important for the purposes of this patch, though.

::: browser/extensions/shumway/content/web/viewer.js
@@ +21,5 @@
> +  return {
> +    /**
> +     * Creates an event that the extension is listening for and will
> +     * synchronously respond to.
> +     * NOTE: It is reccomended to use request() instead since one day we may not

Nit: "recommended"

@@ +227,5 @@
> +
> +function parseSwf(url, movieParams, objectParams) {
> +  var compilerSettings = JSON.parse(
> +    FirefoxCom.requestSync('getCompilerSettings', null));
> +  // enableVerifier.value = compilerSettings.verifier;

Hmm, why is this commented out? The commit in which you did that doesn't give any reason. Does it mean that we don't enable the verifier at all, or just that it's not possible to deactivate it in about:config?

@@ +237,5 @@
> +  //forceHidpi.value = FirefoxCom.requestSync('getBoolPref', {pref: 'shumway.force_hidpi', def: false});
> +  //dummyAnimation.value = FirefoxCom.requestSync('getBoolPref', {pref: 'shumway.dummyMode', def: false});
> +
> +  console.log("Compiler settings: " + JSON.stringify(compilerSettings));
> +  console.log("Parsing " + url + "...");

Let's change these two to console.info.

Comment 3

[Yury Delendik (:yury)]

Attachment: Update Shumway to version 0.9.2697

Review comments addressed

Comment 4

[Till Schneidereit [:till]]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/e60be2f9ea76

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e60be2f9ea76