1061932 - [Email][Compose Mail] Cannot edit Email body, send message, or save draft when using only an Outlook account.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[Martin Shuman [:Marty]]

Attachment: logcat-Email.txt

Description:
When the user only has a single Outlook (or Hotmail) account set up in the Email app, the user is able to begin composing a new email message, where they can input a recipient address and a subect line.  However, they are not able to edit the body of the email, add attachements to the email, discard the message, save the message as a draft, or send the message.  The Email Signiture is also not applied to the body of the email.

This issue only seems to occur with Outlook or Hotmail accounts (Gmail accounts work properly).  Additionally, this issue does not seem to occur when a second Gmail account is also added to the Email app.


Repro Steps:
1) Update a Flame to 20140902040205
2) Open the Email app and set up an Outlook or Hotmail account.
3) Open a New email message, and attempt to edit the Body of the message.
4) Attempt to Send the message, or Save it as a Draft.


Actual:
The user cannot edit the email body, cannot send the message, and cannot save or discard the message.

Expected:
The user can edit the email body, send the message, save and discard the message.

Environmental Variables:
Device: Flame Master
Build ID: 20140902040205
Gaia: 44bf2e3bc5ddea9db9a8c851bd353cb234aa883c
Gecko: c360f3d1c00d
Version: 34.0a1 (Master)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0


Note: This issue is sometimes blocked by bug 1061868


Repro frequency: 75%
See attached: video clip, logcat

Comment 1

[Martin Shuman [:Marty]]

This issue does NOT occur in Flame 2.0
User is able to Compose and Send an email properly.

Environmental Variables:
Device: Flame 2.0
BuildID: 20140902000202
Gaia: 449d8db9b3ea1f9262db822c37ef2143477172b7
Gecko: 40d74e0bbcf5
Version: 32.0 (2.0) 
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 2

[James Burke [:jrburke]]

Attachment: GitHub pull request

Caused by the changes for bug 885110. When I was constructing the build layers, I had trouble testing activesync accounts, and when talking in IRC with :mcav at the time, it was a temporary issue with my local branch/account but I forgot to back and test sending afterwards, even though I did test the message_list view with the Activesync account.

The issue: mimefuncs was not in the worker-boostrap build layer, but since the composite/configurator layer had an explicit dependency on 'mimefuncs', it was combined in that layer. Since `removeCombined` is used in the build config to remove files that end up in a layer, to save on app zip space, this meant the file was not there if loading just an ActiveSync account, and then going to Compose, which dynamically loads 'mimefuncs' when needed.

The fix was just to put the module in the common worker-bootstrap layer, since it is needed by all account branches. Tested on flame device, both saving a draft and sending later and using the contacts and attachments activities to construct emails and send them.

Comment 3

[James Burke [:jrburke]]

[Blocking Requested - why for this release]:
Sending email with an ActiveSync/Outlook email account is broken.

Comment 4

[Marcus Cavanaugh [:mcav]]

Comment on attachment 8483073 [details] [review]
GitHub pull request

Thanks for catching and patching this so quickly!

Comment 5

[James Burke [:jrburke]]

Comment on attachment 8483073 [details] [review]
GitHub pull request

[Approval Request Comment]
See comment 2.

[Bug caused by] (feature/regressing bug #):
Bug 885110

[User impact] if declined:
Sending email with an ActiveSync/Outlook email account is broken.

[Testing completed]:
Tested on flame device, both saving a draft and sending later and using the contacts and attachments activities to construct emails and send them.

[Risk to taking this patch] (and alternatives if risky):
super low risk, just a build config change.

[String changes made]:
none

Comment 6

[James Burke [:jrburke]]

Merged in master:
https://github.com/mozilla-b2g/gaia/commit/f1d0e8daf1d13131e0add416ba1e245a3dfb1383

from pull request:
https://github.com/mozilla-b2g/gaia/pull/23647

Comment 7

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/3a8f8d5f49f0cb48317d2c9e3f8a3fedb1a68bbb

Comment 8

[Edward Chen[:edchen]]

[Environment]
Gaia      944e5b4582c4efa1b67cd33245dbb8f6aa25d09f
Gecko     https://hg.mozilla.org/releases/mozilla-aurora/rev/7546fedad918
BuildID   20140914160203
Version   34.0a2
ro.build.date   Fri Jun 27 15:57:58 CST 2014
ro.bootloader   L1TC00011230
ro.build.version.incremental   110


[Result]
PASS

Comment 9

[Elie]

Attachment: VIDEO0037_Compress.MP4

Verify pass in flame 2.1 build:
Gaia-Rev        1b231b87aad384842dfc79614b2a9ca68a4b4ff3
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/95fbd7635152
Build-ID        20141118001204
Version         34.0

Comment 10

[Josh Cheng [:josh]]

(In reply to Elie from comment #9)
> Created attachment 8525112 [details]
> VIDEO0037_Compress.MP4
> 
> Verify pass in flame 2.1 build:
> Gaia-Rev        1b231b87aad384842dfc79614b2a9ca68a4b4ff3
> Gecko-Rev      
> https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/95fbd7635152
> Build-ID        20141118001204
> Version         34.0

Hi Elie,
Please also verify on 2.2. Thanks!

Comment 11

[Norry.L.F(Leave from Mozilla)]

Attachment: video of verify issue

This issue has been successfully verified on Flame v2.2
See attachment(Verify.MP4)
Reproducing rate: 0/5
Flame 2.2 build:
Gaia-Rev        4aee256937afe9db2520752650685ba61ce6097d
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/084441e904d1
Build-ID        20141118144012
Version         36.0a1
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141118.181013
FW-Date         Tue Nov 18 18:10:22 EST 2014
Bootloader      L1TC00011880