Closed Bug 1062321 Opened 10 years ago Closed 10 years ago

[Utility Tray] When notifications overflow they should be scrollable

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::System
Platform:
x86
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:2.1+, b2g-v2.1 verified, b2g-v2.2 verified)

Status:
VERIFIED FIXED
Milestone:
2.1 S4 (12sep)
Project Flags:
blocking-b2g 2.1+
Tracking Flags:
Tracking Status
b2g-v2.1 --- verified
b2g-v2.2 --- verified

People

(Reporter: epang, Assigned: cwiiis)

References

Details

(Keywords: regression, Whiteboard: [systemsfe])

Attachments

(2 files)

notifications.jpg
319.81 KB, image/jpeg
Details
Fix notification overflow not being scrollable
46 bytes, text/x-github-pull-request
mikehenrty
: review+
fabrice
: approval-gaia-v2.1+
Details | Review
Attached image notifications.jpg — 
When there are more notifications then the allotted space the notification should become drag-gable between the header and system component.  See attached image
draggable confused me when I saw this e-mail, retitling :)

Pretty sure this is a regression from the swipe notification handling, probably easily fixed. Won't assign just yet though, want to sort out a couple of other bugs first.
Keywords: regression
Summary: [Utility Tray] When notifications overflow they should be drag-gable → [Utility Tray] When notifications overflow they should be scrollable
Assignee: nobody → chrislord.net
Status: NEW → ASSIGNED

        Attachment #8483544 -
        Flags: review?(mhenretty)

    
  
Blocks: 1041383

    
    

    
  
[Blocking Requested - why for this release]: A duplicate bug of this was a blocker (bug 1061213)
blocking-b2g: --- → 2.1?

    
    

    
  
Regression
blocking-b2g: 2.1? → 2.1+
Target Milestone: --- → 2.1 S4 (12sep)

    
    

    
  
Comment on attachment 8483544 [details] [review]
Fix notification overflow not being scrollable

Works like a charm.

        Attachment #8483544 -
        Flags: review?(mhenretty) → review+

    
    

    
  
Merged: https://github.com/mozilla-b2g/gaia/commit/915634fc36d838747f18b24e0c402e505eb497bc
Status: ASSIGNED → RESOLVED
Closed: 10 years ago

          status-b2g-v2.1:
          --- → affected

          status-b2g-v2.2:
          --- → fixed
Resolution: --- → FIXED

    
    

    
  
Comment on attachment 8483544 [details] [review]
Fix notification overflow not being scrollable

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined: Can't scroll notifications when you have more than can fit in the panel
[Testing completed]: Tested locally, mhenretty confirms it works, merged to master
[Risk to taking this patch] (and alternatives if risky): Low risk of other issues when swiping on notifications
[String changes made]: None

        Attachment #8483544 -
        Flags: approval-gaia-v2.1?

        Attachment #8483544 -
        Flags: approval-gaia-v2.1? → approval-gaia-v2.1+

    
    

    
  
this is verified and works on Flame 2.2 Master KK (319mb) (Full Flash) and 2.1 KK (319mb) (Full Flash)


Flame 2.2 Master KK (319mb) (Full Flash)

Device: Flame 2.2 Master
BuildID: 20141011040204
Gaia: 95f580a1522ffd0f09302372b78200dab9b6f322
Gecko: 3f6a51950eb5
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 35.0a1 (2.2 Master)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0 

2.1 KK (319mb) (Full Flash)

Environmental Variables:
Device: Flame 2.1 KK (319mb) (Full Flash)
Build ID: 20141010000201
Gaia: d71f8804d7229f4b354259d5d8543c25b4796064
Gecko: 7fa82c9acdf2
Version: 34.0a2 Flame 2.1 KK (319mb)
Firmware Version: v180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0
Status: RESOLVED → VERIFIED
QA Whiteboard: [QAnalyst-Triage?]

          status-b2g-v2.1:
          fixed → verified

          status-b2g-v2.2:
          fixed → verified
Flags: needinfo?(ktucker)

    
    

    
  
In Flame 2.2 Master KK (319mb) (Full Flash) and 2.1 KK (319mb) (Full Flash), with multiple notifications the list is scrollable, both up and down with no errors.
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker)

    
  
No longer blocks: 1041383
Depends on: 1041383

    
  
Blocks: 1041383
No longer depends on: 1041383

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: