1062839 - The orange camera icon from the callee window titlebar should be reverted for the RTL locales

Status: VERIFIED FIXED

(Hello (Loop) :: Client, defect, P3)

Description

[Paul Silaghi, QA [:pauly]]

Attachment: Loop RTL camera button reverted.png

34.0a1 (2014-09-02) AR, FA, HE

Comment 1

[Maire Reavy [:mreavy]]

Darrin -- Is this a bug from a UX point of view?  (Similar to bug 1062838)

Comment 2

[Darrin Henein [:darrin]]

The video icon should remain facing right, as in LTR locales. We do not mirror icons like this.

Comment 3

[Maire Reavy [:mreavy]]

Sounds like there is no bug then.

Comment 4

[Paul Silaghi, QA [:pauly]]

(In reply to Maire Reavy [:mreavy] (Plz needinfo me) from comment #3)
> Sounds like there is no bug then.
Yes, there is, because the camera is now facing left. See the screenshot

Comment 5

[:shell escalante]

until full RTL list and priority - moving to backlog

Comment 6

[Mark Banner (:standard8)]

Attachment: Fix the direction of the camera/screenshare notification anchor icons on the chat window toolbar in RTL mode (should be the same as LTR).

I downloaded a nightly ar build and inspected via devtools. The code works for the url bar, as it flips the block one way (for the popup location), then back again (for the icon itself).

It seems the easiest way out of this is just to cancel the transform for the case where we're in the chat bar.

Comment 7

[Mike de Boer [:mikedeboer]]

Comment on attachment 8653544 [details] [diff] [review]
Fix the direction of the camera/screenshare notification anchor icons on the chat window toolbar in RTL mode (should be the same as LTR).

Review of attachment 8653544 [details] [diff] [review]:
-----------------------------------------------------------------

This will also work for the now pop-out (undock) icon, so LGTM. Thanks!

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/c989c49afbbb

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c989c49afbbb

Comment 10

[Bogdan Maris, Desktop QA]

Was unable to reproduce this issue on old l10n nightly builds because there are none available. 
Verified that using latest Nightly AR build across platform (Windows 7 64-bit, Mac OS X 10.10.5 and Ubuntu 14.04 32-bit) the video icon is pointed to the right.