1063266 - (CopyPaste) the textselection dialog should be repositioned once the content is resized.

Status: RESOLVED DUPLICATE of bug 1067728

(Firefox OS Graveyard :: Gaia::System, defect, P1)

Description

[(Inactive after June) George Duan [:gduan] [:喬智]]

When click on the input field of the bottom,the keyboard shows and overlap the textselection dialog.

Comment 1

[(Inactive after June) George Duan [:gduan] [:喬智]]

The problem here is, when we resize the window due to keyboard launch, the content would be auto scrolled. So the bubble position would be incorrect.

We need to have ability to calculate the diff of scroll start and end in system app.

Comment 2

[(Inactive after June) George Duan [:gduan] [:喬智]]

I tried to print out all mozbrowserasyncscroll event from appWindow.js. It's only triggered when app is opened and closed and switched instead of scrolling.

Comment 3

[(Inactive after June) George Duan [:gduan] [:喬智]]

see https://bugzilla.mozilla.org/show_bug.cgi?id=1020801#c56
we're going to remove mozbrowserasyncscroll...

Comment 4

[Peter Chang[:pchang]]

Is this still an issue?

Comment 5

[(Inactive after June) George Duan [:gduan] [:喬智]]

Yes, this is still a issue.

When keyboard display, all the content will be resized and repositioned, there's proper event to tell me if absolute position of selecting area is changed.

Besides keyboard case, we also need to consider orientation change case.

Comment 6

[(Inactive after June) George Duan [:gduan] [:喬智]]

set ni to Peter.

If we resize the content iframe, like rotate the phone or show/hide keyboard, is there any way to get the latest rect information to update bubble position?

We found below method to get new rect. However, it's controlled in each iframe, and besides, it's have problem when the selection happens in input/textarea dom.

var selection = window.getSelection();
var range = selection.getRange(0);
var rect = range.getBoundingClientRect();

Comment 7

[Peter Chang[:pchang]]

(In reply to George Duan [:gduan] [:喬智] from comment #6)
> set ni to Peter.
> 
> If we resize the content iframe, like rotate the phone or show/hide
> keyboard, is there any way to get the latest rect information to update
> bubble position?
> 
> We found below method to get new rect. However, it's controlled in each
> iframe, and besides, it's have problem when the selection happens in
> input/textarea dom.
> 
> var selection = window.getSelection();
> var range = selection.getRange(0);
> var rect = range.getBoundingClientRect();

For the input/textarea dom, are you able to get the editor object?
If yes, you can also call 'getSelection' with this editor. If the new rect data is correct, I think we could also pass this new rect to shell.js as the same as scrollviewchange event.

http://dxr.mozilla.org/mozilla-central/source/browser/devtools/debugger/test/browser_dbg_search-autofill-identifier.js#32

Comment 8

[(Inactive after June) George Duan [:gduan] [:喬智]]

I can't get meaningful rect information from input/textarea dom.

Comment 9

[(Inactive after June) George Duan [:gduan] [:喬智]]

For not input/textarea case, I can get the selection area information as below:
window.getSelection().getRangeAt(0).getBoundingClientRect()
and the output would contain x/y/width/height/top/right/bottom/left information of the selection area.

However, I can get the position characters I select in input/textarea field by using input.selectionEnd/selectionStart,
and I can also set selection range by using input.setSelectionRange(startPos, endPos).
I find no way to get the rect position of selecting area. 

We need a way to get new rect information once the window has been resized or orientation is changed.

Comment 10

[Peter Chang[:pchang]]

pass ni to TY

Comment 11

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Update selection carets after reflow. r=roc (v1)

Let SelectionCarets inherits from nsIReflowObserver so it could refresh
its position after reflow. This fixes the incorrect position of
selection carets after we rotate the device to change the screen from
portrait mode to landscape mode and vice versa.

Try result:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=2f494ed38bbd

Comment 12

[Peter Chang[:pchang]]

TYLin, I think this issue will be fixed in bug 1067728 too.