Tabs : <tab> does not observe disabled state

RESOLVED FIXED

Status

()

Core
XUL
RESOLVED FIXED
16 years ago
10 years ago

People

(Reporter: kinger, Assigned: jag (Peter Annema))

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

16 years ago
Setting the disabled state (attribute) on a tab does not act as I would expect.

Current behaviour:
The tab text will dull, and the onfocus event will not be executed. However, it
will still switch to the tab and display the tabpanel contents.

Expected behaviour:
Dulling of text, non-execution of code and not allowing the tabpanel to be
displayed.

Assigning to hewitt as per hyatt's request.

Comment 1

16 years ago
Created attachment 54861 [details] [diff] [review]
patch to disable opening of tab if disabled

Updated

16 years ago
Status: NEW → ASSIGNED
Priority: -- → P3
Target Milestone: --- → mozilla0.9.8

Updated

16 years ago
Target Milestone: mozilla0.9.8 → mozilla1.0.1

Comment 2

13 years ago
question: how can one put a tab as disabled?
I only see close tab, close other tab, new tab, bookmark this group of tabs,
reload tab, reload all tabs.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a4) Gecko/20040927

Comment 3

12 years ago
Thomas: XUL is intended as a toolkit for building applications, and those
applications may have other uses for tabs besides just what Mozilla browsers
expose ;-)

This patch looks pretty reasonable to me, but I'd need to further study other
bindings to ensure that this is implementing the disabled property in a
consistent manner.

Comment 4

12 years ago
Reassigning to me so that this is at least on my radar.
Assignee: hewitt → darin
Status: ASSIGNED → NEW
OS: Windows 2000 → All
Priority: P3 → --
Hardware: PC → All
Target Milestone: mozilla1.0.1 → mozilla1.8beta3

Comment 5

12 years ago
The patch does nothing to address keyboard navigation between tabs.

Comment 6

12 years ago
> The patch does nothing to address keyboard navigation between tabs.

Neil, thanks for the info.  Do you have time to revise the patch?

Updated

12 years ago
Target Milestone: mozilla1.8beta3 → mozilla1.9alpha

Comment 7

11 years ago
-> default owner
Assignee: darin → jag
Target Milestone: mozilla1.9alpha → ---
(Reporter)

Comment 8

11 years ago
I'd say this patch has bit-rotted a bit. Anyone interested in me making another one?
*** Bug 360233 has been marked as a duplicate of this bug. ***
QA Contact: jrgmorrison → xptoolkit.widgets

Comment 10

11 years ago
Can confirm this bug is still here FIVE YEARS after first report.

Tabs recieve focus whether they are disabled by property or attribute.

Maybe the next decade will bring a fix ;-)
Keywords: helpwanted

Comment 11

11 years ago
Here are the other related bugs I found to the XUL tab.

https://bugzilla.mozilla.org/show_bug.cgi?id=366116
https://bugzilla.mozilla.org/show_bug.cgi?id=261826
https://bugzilla.mozilla.org/show_bug.cgi?id=307088

Affected are the hidden, disabled attributes/properties as well as the ordering of tabs.

Updated

11 years ago
Duplicate of this bug: 368069
requesting blocking1.9; this bug is ancient, relatively easy to fix (good first bug), and useful for Gecko app developers and extension developers.
Flags: blocking1.9?
Whiteboard: [good first bug]
Depends on: 370742
Fixed by bug 370742
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED

Updated

10 years ago
Flags: blocking1.9?

Updated

10 years ago
Keywords: helpwanted
Whiteboard: [good first bug]
You need to log in before you can comment on or make changes to this bug.