1064401 - Disable overscrolling completely for 2.0

Status: RESOLVED FIXED

(Core :: Panning and Zooming, defect)

Description

[Botond Ballo [:botond]]

Bug 1055361 disabled the original overscroll effect (zooming out) during panning for 2.0, leaving it in place during a fling.

Bug 1057578 introduced a new effect (stretching) for 2.1 for both panning and flinging.

To maintain a consistent user experience across releases, for 2.0 we would like to disable the zoom effect during flinging as well.

Comment 1

[Botond Ballo [:botond]]

Attachment: Flip the pref in b2g.js

Comment 2

[Milan Sreckovic [:milan] (needinfo for best results)]

This would be b2g32 only change - we do not want it in a later repo...

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Yeah, according to https://wiki.mozilla.org/Release_Management/B2G_Landing#Landing_Procedure_3 you need to request approval for b2g32 and then land on that branch directly.

Comment 4

[Botond Ballo [:botond]]

Comment on attachment 8485838 [details] [diff] [review]
Flip the pref in b2g.js

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
  Bug 1055361.

User impact if declined: 
  User sees different overscroll effect in 2.0 than 2.1,
  leading to an inconsistent user experience.

Testing completed: 
  Locally.

Risk to taking this patch (and alternatives if risky): 
  Low - we're just flipping a pref.

String or UUID changes made by this patch:
  None.

Comment 5

[Botond Ballo [:botond]]

Attachment: Flip the pref (gecko portion)

I just realized, overscrolling has an entry in the developer options, so the pref needs to be changed in additional places.

Comment 6

[Botond Ballo [:botond]]

Attachment: Flip the pref (gaia portion)

Comment 7

[Botond Ballo [:botond]]

(In reply to Botond Ballo [:botond] from comment #5)
> I just realized, overscrolling has an entry in the developer options, so the
> pref needs to be changed in additional places.

This also raises the question of whether we want to, perhaps, remove the developer option from 2.0 altogether.

Comment 8

[Milan Sreckovic [:milan] (needinfo for best results)]

I'd leave it, we have a lot of developer options that are not for general consumption...

Comment 9

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8485891 [details] [diff] [review]
Flip the pref (gaia portion)

Review of attachment 8485891 [details] [diff] [review]:
-----------------------------------------------------------------

You'll need to make a PR against gaia 2.0 to get this landed.

Comment 10

[Botond Ballo [:botond]]

Comment on attachment 8485890 [details] [diff] [review]
Flip the pref (gecko portion)

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
  Bug 1055361.

User impact if declined: 
  User sees different overscroll effect in 2.0 than 2.1,
  leading to an inconsistent user experience.

Testing completed: 
  Locally.

Risk to taking this patch (and alternatives if risky): 
  Low - we're just flipping a pref.

String or UUID changes made by this patch:
  None.

Comment 11

[Botond Ballo [:botond]]

Comment on attachment 8485891 [details] [diff] [review]
Flip the pref (gaia portion)

[Approval Request Comment]
See above. The two patches go together.

Comment 12

[Peter Dolanjski [:pdol]]

We should probably block to make sure we don't add something to the product then change it and also just to be 100% safe on the legal side.

Comment 13

[bhavana bajaj [:bajaj]]

Comment on attachment 8485890 [details] [diff] [review]
Flip the pref (gecko portion)

Adding verifyme for QA to ensure overscrolling in 2.0 is disabled after this lands.

Comment 15

[Botond Ballo [:botond]]

checkin-needed for gecko and gaia patches, for B2G 2.0 only - thanks!

Comment 16

[Botond Ballo [:botond]]

(In reply to Botond Ballo [:botond] from comment #14)
> Pull request for the Gaia patch:

Sorry, here is the correct link: https://github.com/mozilla-b2g/gaia/pull/24009

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/a1919483cecb

v2.0: https://github.com/mozilla-b2g/gaia/commit/5a4939dc272cd1cdfa070f1df24f4787c2ae3db5

Comment 18

[Kai-Zhen Li [:seinlin][:kli]]

http://hg.mozilla.org/releases/mozilla-b2g32_v2_0m/rev/a1919483cecb

Comment 19

[Shine(Leave from Mozilla)]

Attachment: video

This issue has been successfully verified on Flame 2.0 and woodduck 2.0
Verify steps:
1. Launch Browser and link any website (ex. www.nba.com).
2. Tap a news to read.
3. Zoom in the webpage.
4. Fling the webpage.
** The zoom effect during flinging is disabled.
See attachment: 1064401_video.MP4
Reproducing rate: 0/5
Flame2.0 build:
Gaia-Rev        1ede2666f1e6c1b3fd3b282011caf0cbc59544b0
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/faa64077b0c2
Build-ID        20141119000207
Version         32.0

Woodduck 2.0 biuld:
Gaia-Rev        cc690f8016b672475dc186bc7fd58aef45e684b7
Gecko-Rev       03d3ab62d5b07b915434f2d1d68495ad5915ecd2
Build-ID        20141118184148
Version         32.0