1065123 - Search activity startup crash @ java.lang.IllegalArgumentException: Couldn''t find search engine for identifier: yahoo at org.mozilla.search.providers.SearchEngineManager.createEngine(SearchEngineManager.java)

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Search Activity, defect)

Comment 1

[Thomas Stache]

https://crash-stats.mozilla.com/report/index/79667d99-04c5-495b-b3a6-2ecb92140909

Comment 2

[Thomas Stache]

https://crash-stats.mozilla.com/report/index/f9e4ef78-f8c9-442e-a254-d6dc92140909

Comment 3

[Kevin Brosnan [Ex-Mozilla]]

Any steps to reproduce?

Comment 4

[Aaron Train [:aaronmt]]

Was this what Margaret was discussing about in IRC channel?

Comment 5

[:Margaret Leibovic]

Yes, this must be happening in a locale that doesn't include yahoo in its search plugins. Once bug 1024527 is fixed, localizers will be able to indicate a default search engine, which should solve this.

However, perhaps instead of crashing we should just end up in a no-engine-selected state, so at least the user can go into settings to try to pick a different engine.

Comment 6

[Thomas Stache]

(In reply to Kevin Brosnan [:kbrosnan] from comment #3)
> Any steps to reproduce?

Just launch the search activity from the Firefox widget or the Android "Google Now gesture".

Comment 7

[Thomas Stache]

Aren't Fennec nightlies en-us? (can't check, as the device is not with me)
The Android install is indeed de-de, however.

Comment 8

[:Margaret Leibovic]

Attachment: Don't crash if the default engine isn't found

The search activity will be pretty useless in this case, but at least the user can still go to settings to choose a valid search engine.

We should never hit this case in real localized builds, but this will be good for pre-release testers and localizers.

Comment 9

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8487094 [details] [diff] [review]
Don't crash if the default engine isn't found

Review of attachment 8487094 [details] [diff] [review]:
-----------------------------------------------------------------

This looks fine to me.  Ship it!

::: mobile/android/search/java/org/mozilla/search/providers/SearchEngineManager.java
@@ +109,5 @@
>  
>              @Override
>              protected void onPostExecute(SearchEngine engine) {
>                  // Only touch engine on the main thread.
>                  SearchEngineManager.this.engine = engine;

Should we be setting this at all?

Comment 10

[:Margaret Leibovic]

(In reply to Nick Alexander :nalexander from comment #9)
> Comment on attachment 8487094 [details] [diff] [review]
> Don't crash if the default engine isn't found
> 
> Review of attachment 8487094 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> This looks fine to me.  Ship it!
> 
> :::
> mobile/android/search/java/org/mozilla/search/providers/SearchEngineManager.
> java
> @@ +109,5 @@
> >  
> >              @Override
> >              protected void onPostExecute(SearchEngine engine) {
> >                  // Only touch engine on the main thread.
> >                  SearchEngineManager.this.engine = engine;
> 
> Should we be setting this at all?

I suppose there's not much reason to if it's null.

Comment 11

[:Margaret Leibovic]

https://hg.mozilla.org/integration/fx-team/rev/29475f2d0097
https://github.com/mozilla/fennec-search/commit/df76b06ce5912b53c9a537abfc2361db801c4f04

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/29475f2d0097

Comment 13

[u279076]

This remains the #2 top crash for Firefox for Android 35.0a1 however there are 0 reports involving a build generated after September 10. 

Thomas, since you reported this crash originally, could you please update to the latest Nightly and verify this is resolved?

Comment 14

[Thomas Stache]

Attachment: Screenshot of search engine settings without a selection

The startup crash is gone. The screenshot shows what Margaret said would happen: Search starts without an active engine. There is no indication what's wrong, though. You can initiate searches, but just nothing happens.

This is Nightly 20140911. What I do not understand is why this is a locale issue? Nightly is running in en-US, the screenshot shows that the Search Activity is running in English. Why does it not find/select Yahoo?

Comment 15

[u279076]

Thanks Thomas, I'm marking this bug verified fixed based on your confirmation that the startup crash is gone. Crash stats seem to support this as well.

I'll leave it to Margaret to address your concerns raised in your second paragraph.

Comment 16

[Thomas Stache]

(from comment #14)
> What I do not understand is why this is a locale
> issue? Nightly is running in en-US, the screenshot shows that the Search
> Activity is running in English. Why does it not find/select Yahoo?

Margaret, can you tell if the locale dependency makes sense (please see quote)?

Comment 17

[:Margaret Leibovic]

(In reply to Thomas Stache from comment #16)
> (from comment #14)
> > What I do not understand is why this is a locale
> > issue? Nightly is running in en-US, the screenshot shows that the Search
> > Activity is running in English. Why does it not find/select Yahoo?
> 
> Margaret, can you tell if the locale dependency makes sense (please see
> quote)?

The screenshot actually shows the search activity running in German (I see Amazon.de), or at least BrowserLocaleManager is returing German as the locale when it fetches search engines. The strings were in English because of bug 1024527, but if localizers have been able to start working on translating them, they should start to appear in German. Can you file a separate bug for us to investigate this? It sounds like there is a bug in our locale switching logic.

Comment 18

[:Margaret Leibovic]

(In reply to :Margaret Leibovic from comment #17)
> (In reply to Thomas Stache from comment #16)
> > (from comment #14)
> > > What I do not understand is why this is a locale
> > > issue? Nightly is running in en-US, the screenshot shows that the Search
> > > Activity is running in English. Why does it not find/select Yahoo?
> > 
> > Margaret, can you tell if the locale dependency makes sense (please see
> > quote)?
> 
> The screenshot actually shows the search activity running in German (I see
> Amazon.de), or at least BrowserLocaleManager is returing German as the
> locale when it fetches search engines. The strings were in English because
> of bug 1024527, but if localizers have been able to start working on
> translating them, they should start to appear in German. Can you file a
> separate bug for us to investigate this? It sounds like there is a bug in
> our locale switching logic.

FYI, Aaron filed bug 1068127 about this, we can use that bug to track fixing this.

Comment 19

[Chris Peterson [:cpeterson]]

Removing steps-wanted keyword because this bug has been resolved.