1065262 - [Lockscreen] No action is triggered on notification in lock screen with passcode enabled

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

Description

[Gerry Chang [:gchang]]

### Steps:
1. Go to Settings > Enable screen lock & pass code
2. While on the lockscreen, take a screenshot. 
3. Tap the notification
4. Tap the open

### Expected:
1. Show keyboard for passcode
2. After entering the correct passcode, user will be redirected to Gallery app and see the screenshot.


### Actual:
1. Nothing happen. Still remain in the lockscreen.

### Reproduce rate
always

### Version:
Device    flame
Gaia      90812662b9e0d3aba88882290c08971fdff98515
Gecko     https://hg.mozilla.org/releases/mozilla-aurora/rev/9da2a5828e56
BuildID   20140909160202
Version   34.0a2

Comment 1

[Gerry Chang [:gchang]]

[Blocking Requested - why for this release]:

Comment 2

[howie [:howie]]

Triage: blocking.

Comment 3

[Greg Weng [:snowmantw][:gweng][:λ]]

According to my discuss with Gerry, this not occurred at the first time he verified the actionable LockScreen, and it's broken now. So, this is a 'regression' in development, but since J.Smith sent a mail to argument that not all fine-now-broken things should be marked as 'regression', which makes this bug in an embarrassing situation, that no one would find regression window except me.

Comment 4

[Greg Weng [:snowmantw][:gweng][:λ]]

The possible breaking points:

0. Verfied good: after
https://github.com/mozilla-b2g/gaia/commit/d5b380a98e9003f45fe1bb1580c313b2a99885bc

1. Possible broken (1):
https://github.com/mozilla-b2g/gaia/commit/6aa3b641ffe075ff40801ca0e8c35ce6459a9793

2. Possible broken (2):
https://github.com/mozilla-b2g/gaia/commit/d5b380a98e9003f45fe1bb1580c313b2a99885bc

Comment 5

[Greg Weng [:snowmantw][:gweng][:λ]]

Gerry notice me that I post wrong commit.

Re-organize the break points since I post the wrong commits

The possible breaking points:

0. Verfied good: after
https://github.com/mozilla-b2g/gaia/commit/d5b380a98e9003f45fe1bb1580c313b2a99885bc

1. Possible broken (1):
https://github.com/mozilla-b2g/gaia/commit/6aa3b641ffe075ff40801ca0e8c35ce6459a9793

2. Possible broken (2), but fixed the previous 1. error (regression error):
https://github.com/mozilla-b2g/gaia/commit/4793372476c1dd6c95bc15b1bc111a35080b19e7

3. Possible broken (3) (recently):
https://github.com/mozilla-b2g/gaia/commit/4817ffe2c8626baf8d6b16b19d7da879f1bf68ad

Comment 6

[Gerry Chang [:gchang]]

(In reply to Greg Weng [:snowmantw][:gweng][:λ] from comment #5)
> Gerry notice me that I post wrong commit.
> 
> Re-organize the break points since I post the wrong commits
> 
> The possible breaking points:
> 
> 0. Verfied good: after
> https://github.com/mozilla-b2g/gaia/commit/
> d5b380a98e9003f45fe1bb1580c313b2a99885bc
> 
This is correct.
> 1. Possible broken (1):
> https://github.com/mozilla-b2g/gaia/commit/
> 6aa3b641ffe075ff40801ca0e8c35ce6459a9793
> 
This is bug 1061088. 
> 2. Possible broken (2), but fixed the previous 1. error (regression error):
> https://github.com/mozilla-b2g/gaia/commit/
> 4793372476c1dd6c95bc15b1bc111a35080b19e7
> 
No action is triggered with passcode enable. This is bug 1065262.
> 3. Possible broken (3) (recently):
> https://github.com/mozilla-b2g/gaia/commit/
> 4817ffe2c8626baf8d6b16b19d7da879f1bf68ad
>
No action is triggered with passcode enable. This is bug 1065262.

Comment 7

[Jason Smith [:jsmith]]

(In reply to Greg Weng [:snowmantw][:gweng][:λ] from comment #3)
> According to my discuss with Gerry, this not occurred at the first time he
> verified the actionable LockScreen, and it's broken now. So, this is a
> 'regression' in development, but since J.Smith sent a mail to argument that
> not all fine-now-broken things should be marked as 'regression', which makes
> this bug in an embarrassing situation, that no one would find regression
> window except me.

I'm confused about this comment. If Gerry knows this was working previously on an earlier build within the same release with proof (working on X build), then we can flag this as a regression & do a window against it.

Comment 8

[Jason Smith [:jsmith]]

Adding window wanted to validate the root cause commit.

Comment 9

[Greg Weng [:snowmantw][:gweng][:λ]]

A little help is Comment 6 shows the the first breaking point could be confirmed is:

https://github.com/mozilla-b2g/gaia/commit/4793372476c1dd6c95bc15b1bc111a35080b19e7

according to the result Gerry provides. I discussed this with him yesterday, and confirm that after this commit.

Comment 10

[Greg Weng [:snowmantw][:gweng][:λ]]

And the:

https://github.com/mozilla-b2g/gaia/commit/6aa3b641ffe075ff40801ca0e8c35ce6459a9793

commit made the whole function, not only passcode part, broken. I listed it here is that I suspect the regression came from the commit.

Comment 11

[Adam Alldredge [:AdamA][Inactive]]

B2G-Inbound Regression Window

Last working:
Device: Flame 2.1
BuildID: 20140824235254
Gaia: 5fae8a02bc31d28a4a76371bd9b0c8ef98a4b4f4
Gecko: e8efd2cf56e8
Version: 34.0a1 (2.1)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

First Broken:
Device: Flame 2.1
BuildID: 20140825011754
Gaia: c36879d1d2644b5e059ef06aa855def460f8e08f
Gecko: 42091f9dd02f
Version: 34.0a1 (2.1)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Last working Gaia First Broken Gecko: Issue does NOT reproduce
Gaia: 5fae8a02bc31d28a4a76371bd9b0c8ef98a4b4f4
Gecko: 42091f9dd02f

First Broken Gaia Last working Gecko: Issue DOES reproduce
Gaia: c36879d1d2644b5e059ef06aa855def460f8e08f
Gecko: e8efd2cf56e8

Pushlog:
https://github.com/mozilla-b2g/gaia/compare/5fae8a02bc31d28a4a76371bd9b0c8ef98a4b4f4...c36879d1d2644b5e059ef06aa855def460f8e08f

Caused by Bug 1043892

Comment 12

[Joshua Mitchell (Inactive)]

Greg - it looks like this might have been caused by Bug 1043892

Comment 13

[Greg Weng [:snowmantw][:gweng][:λ]]

Attachment: Patch

Thanks QA to identify the breaking point. This is the patch.

Comment 14

[Greg Weng [:snowmantw][:gweng][:λ]]

Gaia Try is green:

https://tbpl.mozilla.org/?rev=24c1dcc9112f2a545c4e4dc7662e9499eeca1d8a&tree=Gaia-Try

I would land this on master and prepare v2.1 patch.

Comment 15

[Greg Weng [:snowmantw][:gweng][:λ]]

master: https://github.com/mozilla-b2g/gaia/commit/abcdebf2a4cfe52594e47422dc1db16b76d6bd3c

Comment 16

[Greg Weng [:snowmantw][:gweng][:λ]]

Attachment: Patch v2.1

Waiting CI.

Comment 18

[Greg Weng [:snowmantw][:gweng][:λ]]

The v2.1 patch passed Gaia-Try tests after re-trigger an irrelevant Gip test:

https://tbpl.mozilla.org/?rev=d260dc30a13228622571c16dc31fc90241409e9a&tree=Gaia-Try

I now submit the approval.

Comment 19

[Greg Weng [:snowmantw][:gweng][:λ]]

Comment on attachment 8493550 [details] [review]
Patch v2.1

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Bug 1043892
[User impact] if declined: No regression fix in 2.1
[Testing completed]: Gaia-Try (see above comment) and manually test it on device
[Risk to taking this patch] (and alternatives if risky): No
[String changes made]: No

Comment 20

[Greg Weng [:snowmantw][:gweng][:λ]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/700f481fca40ef8ea0a3aad4ff109c0c62eb6bac

Comment 21

[Gerry Chang [:gchang]]

Verified @
Gaia-Rev        75329a3dd30b30accbd859f862d056e7b10d1dcf
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-aurora/rev/1c5e5e94f818
Build-ID        20140925165840
Version         34.0a2

Comment 22

[Sue]

Attachment: video of issue verify

This issue has been successfully verified on Flame 2.1
See attachment: verify_video.MP4
Reproducing rate: 0/5
Flame 2.1 versions:
Gaia-Rev        1b231b87aad384842dfc79614b2a9ca68a4b4ff3
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/95fbd7635152
Build-ID        20141119001205
Version         34.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141119.035246
FW-Date         Wed Nov 19 03:52:56 EST 2014
Bootloader      L1TC00011880