1065355 - Make timeline and shadereditor tests run on e10s

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), defect)

Description

[Victor Porof [:vporof][:vp]]

A coding exception was thrown and uncaught in a Task.
Full message: TypeError: target.window is null
Full stack: initFrontend@chrome://mochitests/content/browser/browser/devtools/timeline/test/head.js:76:7
Tester_execTest@chrome://mochikit/content/browser-test.js:659:9
Tester.prototype.nextTest</<@chrome://mochikit/content/browser-test.js:556:7

Comment 1

[Mark Hammond [:markh] [:mhammond]]

Attachment: 0002-get-timeline-tests-working-in-e10s-by-disabling-the-.patch

The patch in bug 1067229 plus this attachment gets the timeline tests passing when run under e10s.  Victor, what is the "right" thing to do re the debuggee here?

Comment 2

[Mark Hammond [:markh] [:mhammond]]

FTR, the 'shadereditor' tests have an almost identical problem - head.js tries to get a 'debuggee' object in a couple of places but it seems unused by the tests.

Comment 3

[Mark Hammond [:markh] [:mhammond]]

Same basic fix for both timeline and shadereditor, so we might as well kill both birds here.

Comment 4

[Mark Hammond [:markh] [:mhammond]]

Attachment: 0001-Bug-1065355-part-1-get-timeline-tests-working-in-e10.patch

As we discussed on IRC, I've just dropped the "debuggee" result from initShaderEditor() - however, I also changed it to return an object instead of an array so it is easier to add a debuggee back in the future without touching the tests that don't need it.

This gets all timeline tests passing for me locally.

Comment 5

[Mark Hammond [:markh] [:mhammond]]

Attachment: 0002-Bug-1065355-part-2-get-shadereditor-tests-working-in.patch

An almost identical patch, but for the shadereditor.

Comment 6

[Mark Hammond [:markh] [:mhammond]]

https://hg.mozilla.org/integration/fx-team/rev/d4e8b9359261
https://hg.mozilla.org/integration/fx-team/rev/0ea262e00917

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d4e8b9359261
https://hg.mozilla.org/mozilla-central/rev/0ea262e00917

Comment 8

[David Lawrence [:dkl]]

Sorry for the spam. Moving bugs to Firefox :: Developer Tools: Performance Tools (Profiler/Timeline).

dkl