1065712 - Move new_tablet_* to the appropriate directories

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

For example, new_tablet_tab_strip is in layout/ - it should be in layout-large-v11/.

Also, we may have added layout files that are not prepended with new_tablet_*, but are only used on tablets - be sure to move these as well.

It's also possible that these files reference new styles and such in the values/ directory - these should be modified too.

Comment 1

[Richard Newman [:rnewman]]

Our non-tablet users thank you in advance for your diligence :D

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Move new_tablet_* resources to *large* directories

Comment 3

[Martyn Haigh (:mhaigh)]

Comment on attachment 8487631 [details] [diff] [review]
Move new_tablet_* resources to *large* directories

Review of attachment 8487631 [details] [diff] [review]:
-----------------------------------------------------------------

I'm still seeing a few resources in the layouts folder (new_tablet_tab_strip, new_tablet_tabs_counter) and some resource starting with new_tablet_ still in the drawable folder.

::: mobile/android/base/resources/values-large-v11/styles.xml
@@ +21,5 @@
>          <item name="android:layout_marginLeft">@dimen/forward_default_offset</item>
>      </style>
>  
> +    <style name="UrlBar.ImageButton.TabCount.NewTablet">
> +        <item name="android:background">@drawable/new_tablet_tabs_count</item>

move the file referenced here from the drawable folder

Comment 4

[Martyn Haigh (:mhaigh)]

Comment on attachment 8487631 [details] [diff] [review]
Move new_tablet_* resources to *large* directories

Sorry, didn't spot the file moves in there!

Looks good

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Yeah, unfortunately the file diff... splinter-ed. :D

For future travellers: apply locally - the renamed files don't appear on bugzilla.

Comment 6

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://hg.mozilla.org/integration/fx-team/rev/7d2eec16bbde

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/7d2eec16bbde