Move new_tablet_* to the appropriate directories

RESOLVED FIXED in Firefox 35

Status

()

Firefox for Android
General
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: mcomella, Assigned: mcomella)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 35
All
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

For example, new_tablet_tab_strip is in layout/ - it should be in layout-large-v11/.

Also, we may have added layout files that are not prepended with new_tablet_*, but are only used on tablets - be sure to move these as well.

It's also possible that these files reference new styles and such in the values/ directory - these should be modified too.
Our non-tablet users thank you in advance for your diligence :D
Blocks: 942609
Assignee: nobody → michael.l.comella
Status: NEW → ASSIGNED
Created attachment 8487631 [details] [diff] [review]
Move new_tablet_* resources to *large* directories
Attachment #8487631 - Flags: review?(mhaigh)
Comment on attachment 8487631 [details] [diff] [review]
Move new_tablet_* resources to *large* directories

Review of attachment 8487631 [details] [diff] [review]:
-----------------------------------------------------------------

I'm still seeing a few resources in the layouts folder (new_tablet_tab_strip, new_tablet_tabs_counter) and some resource starting with new_tablet_ still in the drawable folder.

::: mobile/android/base/resources/values-large-v11/styles.xml
@@ +21,5 @@
>          <item name="android:layout_marginLeft">@dimen/forward_default_offset</item>
>      </style>
>  
> +    <style name="UrlBar.ImageButton.TabCount.NewTablet">
> +        <item name="android:background">@drawable/new_tablet_tabs_count</item>

move the file referenced here from the drawable folder
Attachment #8487631 - Flags: review?(mhaigh) → review-
Comment on attachment 8487631 [details] [diff] [review]
Move new_tablet_* resources to *large* directories

Sorry, didn't spot the file moves in there!

Looks good
Attachment #8487631 - Flags: review- → review+
Yeah, unfortunately the file diff... splinter-ed. :D

For future travellers: apply locally - the renamed files don't appear on bugzilla.
https://hg.mozilla.org/mozilla-central/rev/7d2eec16bbde
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
You need to log in before you can comment on or make changes to this bug.