If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Update OpenTok library to 2.2.9

RESOLVED FIXED in Firefox 34

Status

Hello (Loop)
Client
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: song, Assigned: standard8)

Tracking

unspecified
mozilla35
Points:
1
Dependency tree / graph
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox34 fixed, firefox35 fixed)

Details

(Whiteboard: [loop-uplift])

Attachments

(2 attachments)

(Reporter)

Description

3 years ago
Created attachment 8488104 [details]
webrtc-js-2.2.9.1.tgz

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/37.0.2062.94 Safari/537.36

Steps to reproduce:

no steps, just update to 2.2.9



Actual results:

right now opentok 2.2.7 is used


Expected results:

opentok 2.2.9 should be used
(Reporter)

Comment 1

3 years ago
Changes in 2.2.9.1: https://tokbox.com/opentok/libraries/client/js/release-notes.html

* Logging fix: setLogLevel(0) will not show any logging at all.
* Override GUID storage API
(Assignee)

Comment 2

3 years ago
Created attachment 8488132 [details] [diff] [review]
Update OpenTok library to 2.2.9.

Thanks for the files Song.

I've given this a quick run through with a local test and everything seems fine.
Attachment #8488132 - Flags: review?(adam)
(Assignee)

Updated

3 years ago
Assignee: nobody → standard8
Status: UNCONFIRMED → NEW
Iteration: --- → 35.1
Points: --- → 1
Ever confirmed: true
Target Milestone: --- → mozilla35

Comment 3

3 years ago
Comment on attachment 8488132 [details] [diff] [review]
Update OpenTok library to 2.2.9.

Review of attachment 8488132 [details] [diff] [review]:
-----------------------------------------------------------------

Assuming we don't have any regressions, this all looks good to me.
Attachment #8488132 - Flags: review?(adam) → review+
(Assignee)

Comment 4

3 years ago
https://hg.mozilla.org/integration/fx-team/rev/358914066f47
(Assignee)

Updated

3 years ago
Blocks: 1053796

Comment 5

3 years ago
Hi Mark, Is this bug going up for uplift to Fx34 nomination?
Flags: needinfo?(standard8)

Comment 6

3 years ago
Please also update the SDK on your CDN.
See Also: → bug 1066532
https://hg.mozilla.org/mozilla-central/rev/358914066f47
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Untracking for QE verification. Please needinfo me to request testing.
Flags: qe-verify-
(Assignee)

Comment 9

3 years ago
(In reply to msander from comment #6)
> Please also update the SDK on your CDN.

Landing it here is part of our process - it gets auto extracted to a github repository from which we will be creating a release soon (sometime later this week I expect, as we have dependencies on the main server being updated).

If there is a reason that this should be pushed out quicker, please let us know.
Flags: needinfo?(standard8)
(Assignee)

Comment 10

3 years ago
(In reply to sescalante from comment #5)
> Hi Mark, Is this bug going up for uplift to Fx34 nomination?

I don't think it would hurt. It will make the browser console quieter and possibly improve performance slightly (definitely if the console is open). We should probably take bug 1053796 with it, in case we do want to debug the sdk in beta/release.
Whiteboard: [loop-uplift]

Comment 11

3 years ago
(In reply to Mark Banner (:standard8) from comment #9)
> If there is a reason that this should be pushed out quicker, please let us
> know.

Later this week should be fine. v2.2.6 was on your CDN for some time after we sent v2.2.7.2, so I wanted to make sure this one would make it up there relatively quickly.

In addition to the logging/guid changes Song mentioned, this build also disables FEC, which in some cases is causing Chrome 37 to crash. The crash issue is much more of a problem in multi-party calls, so it probably won't impact your 1-1 use case in any noticeable way.
(Reporter)

Comment 12

3 years ago
this should be able to resolve https://bugzilla.mozilla.org/show_bug.cgi?id=1066816 and move https://bugzilla.mozilla.org/show_bug.cgi?id=1033587 along.
(Reporter)

Comment 13

3 years ago
sorry, wrong terminology. Not resolve, unblock https://bugzilla.mozilla.org/show_bug.cgi?id=1066816 and https://bugzilla.mozilla.org/show_bug.cgi?id=1033587

Comment 14

3 years ago
If we uplift this to 34, I would think uplifting Bug 1066816 would be a good move as well -- it would allow for cleaner analytics once we get into release.

Updated

3 years ago
Blocks: 1066816
Mark, is anything holding us back from requesting uplift for this, so that we get useful stats in 34?
Flags: needinfo?(standard8)
(In reply to Nils Ohlmeier [:drno] from comment #15)
> Mark, is anything holding us back from requesting uplift for this, so that
> we get useful stats in 34?

No, I've actually requested uplift for this along with several other Loop bugs in a separate email to the Firefox release-drivers.  There were enough bugs that doing each bug by hand (and approving each by hand) would be tedious.  If my request is approved soon, this should be uplifted to Aurora by this Thursday.
Flags: needinfo?(standard8)
Comment on attachment 8488132 [details] [diff] [review]
Update OpenTok library to 2.2.9.

Approval Request Comment
Uplift request for patches staged and tested on Fig
Attachment #8488132 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/releases/mozilla-aurora/rev/73ad2e4e793d

Updated

3 years ago
status-firefox34: --- → fixed
status-firefox35: --- → fixed
(Assignee)

Updated

3 years ago
Depends on: 1078226
Comment on attachment 8488132 [details] [diff] [review]
Update OpenTok library to 2.2.9.

I worked with Randell and Maire on uplifting a large number of Loop bugs at once. All of the bugs have been staged on Fig and tested by QE before uplift to Aurora. As well, all of the bugs are isolated to the Loop client. Randell handled the uplift with my approval. I am adding approval to the bug after the fact for bookkeeping.
Attachment #8488132 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.