1067026 - crash in java.lang.IllegalStateException: Error reading list.txt at org.mozilla.search.providers.SearchEngineManager.getAllEngines(SearchEngineManager.java)

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Search Activity, defect)

Description

[Aaron Train [:aaronmt]]

This bug was filed from the Socorro interface and is 
report bp-c800884e-b259-4058-b8ab-b32882140911.
=============================================================

java.lang.IllegalStateException: Error reading list.txt
	at org.mozilla.search.providers.SearchEngineManager.getAllEngines(SearchEngineManager.java:139)
	at org.mozilla.search.SearchPreferenceActivity$2.doInBackground(SearchPreferenceActivity.java:120)
	at android.os.AsyncTask$2.call(AsyncTask.java:288)
	at java.util.concurrent.FutureTask.run(FutureTask.java:237)
	at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:231)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1112)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:587)
	at java.lang.Thread.run(Thread.java:841)

Comments

  "tried opening the settings of the search app"

Comment 1

[Aaron Train [:aaronmt]]

Growing in volume, tracking?

Comment 2

[:Margaret Leibovic]

I'll look into this.

Comment 3

[:Margaret Leibovic]

This reminds me of the conversation in bug 1065123. This will happen if we can't find the list.txt files, which could happen if we're somehow creating the wrong path for the locale.

Maybe we should land a patch to add some more logging to see what locale we're getting here.

It would be really nice if someone could reproduce this, perhaps by trying out different locales.

Comment 4

[Richard Newman [:rnewman]]

My guess: they're using an OS locale that we don't ship.

E.g., es_US. That'll result in a Fennec displayed in English, but the Java locale is still es_US. That'll give us a path of /es-US/, which doesn't exist.

See also Bug 1045053, which is addressing a similar split.

Comment 5

[Richard Newman [:rnewman]]

So, STR for you to try:

* Android settings. Language. Pick Español (Estados Unidos).
* Launch Nightly. Verify that it's showing you English, not Spanish.
* Open the search activity and hit settings.

Comment 6

[Aaron Train [:aaronmt]]

(In reply to Richard Newman [:rnewman] from comment #5)
> So, STR for you to try:
> 
> * Android settings. Language. Pick Español (Estados Unidos).
> * Launch Nightly. Verify that it's showing you English, not Spanish.
> * Open the search activity and hit settings.

Yep that did it.

Comment 7

[:Margaret Leibovic]

How does Fennec deal with this case? Does it just fall back to en-US? We could make the search activity just fall back to en-US instead of crashing.

Comment 8

[Richard Newman [:rnewman]]

If Gecko doesn't understand the OS locale, it believes it's in en-US (which is the source of Bug 1045053).

Falling back to en-US seems like a reasonable choice, yeah :D

Comment 9

[:Margaret Leibovic]

Attachment: Fall back to en-US if search plugins aren't found for the user's locale

Comment 10

[:Margaret Leibovic]

https://github.com/mozilla/fennec-search/commit/a923dbbc198a805d499f63254b052abb56eedbf1
https://hg.mozilla.org/integration/fx-team/rev/b58ffeb810cd

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b58ffeb810cd

Comment 12

[u279076]

There's been 0 crashes reported in the last week but I'm flagging it for QE verification given this has a reproducible case.

Comment 13

[Cristina Madaras, QA [:CristinaM]]

Verified as fixed in Firefox for Android 35 Beta 1 with Nexus 4 (Android 4.4.4), using steps from comment 5.