106712 - disable the View | Messages | Threaded menuitem when in quick search mode

Status: VERIFIED WONTFIX

(SeaMonkey :: MailNews: Message Display, defect, P3)

Description

[(not reading, please use [e-mail] instead)]

disable the View | Messages | Threaded menuitem when in quick search mode

right now, we just return and do nothing when the user tries to check the mode
while in quick search.

jglick, do we want to hide the thread related columns when we go into quick
search, like we do in the search results pane of advanced search?

the thread related columns are:

the thread column, the unread in thread column, the total in thread column.

one problem with hiding / showing the columns is by doing that, we'll make the
columns jump around when going into, and out of, quick search, which probably
won't look as good.

Comment 1

[timeless]

disable view>unread and view>threads w/ unread too since using it ignores those.
... perhaps just disable quick search feature?

Comment 2

[Håkan Waara]

What?  Why should these modes be unavailable in Quick Search?  Just fix it to
work instead. :)

Comment 3

[jglick]

What about the reverse, if the user is in a Threaded mode, is quick search not 
available? Ideally it would be nice if they could work together, but i'm not 
sure exactly how or if that would work. Håkan, do you have an idea for how this 
would work?

Comment 4

[timeless]

i'd like showing entire threads only if a message in the thread matches the query.

Bonus points to give messages not matching the query an extra class so they can
be styled extra to distinguish from messages that do ... (default style: color:
grey?)

Comment 5

[laurel]

*** Bug 111523 has been marked as a duplicate of this bug. ***

Comment 6

[laurel]

nominating for next release -- either disable threading ui items or get
threading to work in quicksearch.

Comment 7

[Samir Gehani]

Mail triage team: nsbeta1+/adt3

Comment 8

[[e-mail]]

Attachment: Proposed patch

Comment 9

[(not reading, please use [e-mail] instead)]

re-assigning nsbeta1+ bugs

Comment 10

[(not reading, please use [e-mail] instead)]

Comment on attachment 111838 [details] [diff] [review]
Proposed patch

r/sr=sspitzer

thanks neil.

Comment 11

[(not reading, please use [e-mail] instead)]

neil, can you get this into 1.3 beta?

Comment 12

[Asa Dotzler [:asa]]

Comment on attachment 111838 [details] [diff] [review]
Proposed patch

a=asa (on behalf of drivers) for checkin to 1.3beta.

Comment 13

[(not reading, please use [e-mail] instead)]

I saw that this patch was checked in on 1/29, but is it fixed?

trying in today's build, I don't think the fix that was checked in is working.

(not sure if it is an issue with the patch, or with the view, meaning that
gDBView.supportsThreading is returning the wrong thing.)

my gut tells me that we need to override GetSupportsThreading() in
nsMsgQuickSearchDBView

Comment 14

[[e-mail]]

Attachment: Missed a bit :-/

Comment 15

[(not reading, please use [e-mail] instead)]

Comment on attachment 113233 [details] [diff] [review]
Missed a bit :-/

wait, wont' that affect this the view all msgs command?


      case "cmd_viewAllMsgs":
      case "cmd_sortByThread":
      case "cmd_viewUnreadMsgs":
      case "cmd_viewThreadsWithUnread":
      case "cmd_viewWatchedThreadsWithUnread":
      case "cmd_viewIgnoredThreads":
      case "cmd_stop":
	return true;

Comment 16

[(not reading, please use [e-mail] instead)]

Comment on attachment 113233 [details] [diff] [review]
Missed a bit :-/

waiting to hear about the view all cmd

Comment 17

[(not reading, please use [e-mail] instead)]

Comment on attachment 113233 [details] [diff] [review]
Missed a bit :-/

adding back r/sr=sspitzer

seeking approval on neil's behalf.

I'll explain in my next comment...

Comment 18

[(not reading, please use [e-mail] instead)]

from neil:

"View All Messages doesn't work properly when quick search or mail views are
enabled - it does view all messages, despite the settings of quick search and
mail views, but it doesn't clear the appearance of quick search or mail views.
If you want that fixed, you might as well make some or all of those menuitems
clear quick search and mail views, but my impression was that's not what you want."

neil's right.  also note, the issue of that menu (and how it and mailviews and
quick search interact) is covered (or will be covered) by another bug.

r/sr on neils patch.  accepting for neil, on his behalf. 

Comment 19

[Asa Dotzler [:asa]]

Comment on attachment 113233 [details] [diff] [review]
Missed a bit :-/

a=asa (on behalf of drivers) for checkin to 1.3beta.

Comment 20

[Sander]

Is there already a bug for doing the right thing, namely making threaded view
and quicksearch work together?

Comment 21

[[e-mail]]

Fix checked in.

Comment 22

[Ninoschka Baca]

Trunk build 2003-04-10: WinXP, Mac 10.1.5, Linux RH 8
Is this the expected behavior for this bug? 

Using this build I found the following results:

The following results in the View|Messages submenu items all being disabled:
1. Perform a Quick Search
2. Change the View dropdown to anything but All

If the View dropdown is changed to All then the View|Messages submenu items are
all enabled.


Note: bug# 135326 covers Quick Search working in threaded mode.

Comment 23

[(not reading, please use [e-mail] instead)]

I'm thinking about backing this out, see bug #189543

Comment 24

[(not reading, please use [e-mail] instead)]

reopening, as this was backed out (changed the design) for bug #189543

Comment 25

[(not reading, please use [e-mail] instead)]

wontfixing.  baced out (as part of bug #189543)

Comment 26

[Ninoschka Baca]

Verified Wontfix.