1067429 - crash in android.content.res.Resources$NotFoundException: Resource is not a Drawable (color or path): TypedValue{t=0x1/d=$ a=3 r=$} at android.content.res.Resources.loadDrawable(Resources.java)

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aaron Train [:aaronmt]]

This bug was filed from the Socorro interface and is 
report bp-640c28d7-47b5-45c2-8414-4165d2140910.
=============================================================

android.content.res.Resources$NotFoundException: Resource is not a Drawable (color or path): TypedValue{t=0x1/d=0x7f070126 a=3 r=0x7f070126}
	at android.content.res.Resources.loadDrawable(Resources.java:1890)
	at android.content.res.TypedArray.getDrawable(TypedArray.java:601)
	at android.view.View.<init>(View.java:2471)
	at android.view.ViewGroup.<init>(ViewGroup.java:365)
	at android.widget.LinearLayout.<init>(LinearLayout.java:156)
	at android.widget.LinearLayout.<init>(LinearLayout.java:152)
	at java.lang.reflect.Constructor.constructNative(Native Method)
	at java.lang.reflect.Constructor.newInstance(Constructor.java:416)
	at android.view.LayoutInflater.createView(LayoutInflater.java:576)
	at com.android.internal.policy.impl.PhoneLayoutInflater.onCreateView(PhoneLayoutInflater.java:56)
	at android.view.LayoutInflater.onCreateView(LayoutInflater.java:644)
	at android.view.LayoutInflater.createViewFromTag(LayoutInflater.java:669)
	at android.view.LayoutInflater.inflate(LayoutInflater.java:457)
	at android.view.LayoutInflater.inflate(LayoutInflater.java:391)
	at android.view.LayoutInflater.inflate(LayoutInflater.java:347)
	at android.widget.Toast.makeText(Toast.java:247)
	at android.widget.Toast.makeText(Toast.java:270)
	at android.sec.clipboard.ClipboardExManager$1.handleMessage(ClipboardExManager.java:100)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loop(Looper.java:132)
	at android.app.ActivityThread.main(ActivityThread.java:4123)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:491)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:844)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:602)
	at dalvik.system.NativeStart.main(Native Method)

Still crashing for the GT-P6200 device on 33+

Comment 1

[Aaron Train [:aaronmt]]

246 crashes on 33.0b2

https://crash-stats.mozilla.com/report/list?product=FennecAndroid&signature=android.content.res.Resources%24NotFoundException%3A+Resource+is+not+a+Drawable+%28color+or+path%29%3A+TypedValue%7Bt%3D0x1%2Fd%3D0x7f070126+a%3D3+r%3D0x7f070126%7D+at+android.content.res.Resources.loadDrawable%28Resources.java%29

Largely these two tablets on Android (API 13, 3.2)
 
* GT-P6200
* GT-P6800

Comment 2

[Brian Nicholson (:bnicholson)]

I finally got my hands on this tablet last week, but it's ICS, not Honeycomb. I'll see if I can root/downgrade it.

Comment 3

[Nick Alexander :nalexander [he/him]]

Looking through reports, we trigger this -- a great deal -- at http://mxr.mozilla.org/mozilla-release/source/mobile/android/base/GeckoApp.java#782.  It's just showing a toast; there's no Fennec resources involved.  The best we can do is try something else on these devices, to avoid the crash.

This is ridiculous.

Comment 4

[Aaron Train [:aaronmt]]

Did something regress from the fixes that were proposed and landed in bug 970081?

Comment 5

[Brian Nicholson (:bnicholson)]

See https://bugzilla.mozilla.org/show_bug.cgi?id=987864#c4. Although it changes, the resource ID always ends up pointing to org.mozilla.firefox:style/GeckoActionBar.Title, so I still think this could be our fault.

Comment 6

[Nick Alexander :nalexander [he/him]]

bnicholson: I was not aware our styling could affect system toasts at all.  Can you take this ticket and repeat your investigation here?

Comment 7

[Brian Nicholson (:bnicholson)]

(In reply to Nick Alexander :nalexander from comment #6)
> bnicholson: I was not aware our styling could affect system toasts at all. 
> Can you take this ticket and repeat your investigation here?

I'm also not sure whether it can, but the fact that the referenced resource is always the same seems suspicious. I at least want to reproduce to see if that reveals anything.

Already assigned myself!

Comment 8

[Nick Alexander :nalexander [he/him]]

(In reply to Nick Alexander :nalexander from comment #6)
> bnicholson: I was not aware our styling could affect system toasts at all. 
> Can you take this ticket and repeat your investigation here?

I'll look a little, too.  Fetching

http://ftp.mozilla.org/pub/mozilla.org/mobile/releases/latest-beta/android/multi/fennec-33.0b2.multi.android-arm.apk

Running

aapt l -a fennec-33.0b2.multi.android-arm.apk | grep 0x7f070126

yields

      spec resource 0x7f070126 org.mozilla.firefox_beta:style/GeckoActionBar: flags=0x00000400
        resource 0x7f070126 org.mozilla.firefox_beta:style/GeckoActionBar: <bag>
        resource 0x7f070126 org.mozilla.firefox_beta:style/GeckoActionBar: <bag>

I bet we have the same issue as before.

Comment 9

[Nick Alexander :nalexander [he/him]]

(In reply to Nick Alexander :nalexander from comment #8)
> (In reply to Nick Alexander :nalexander from comment #6)
> > bnicholson: I was not aware our styling could affect system toasts at all. 
> > Can you take this ticket and repeat your investigation here?
> 
> I'll look a little, too.  Fetching
> 
> http://ftp.mozilla.org/pub/mozilla.org/mobile/releases/latest-beta/android/
> multi/fennec-33.0b2.multi.android-arm.apk
> 
> Running
> 
> aapt l -a fennec-33.0b2.multi.android-arm.apk | grep 0x7f070126
> 
> yields
> 
>       spec resource 0x7f070126
> org.mozilla.firefox_beta:style/GeckoActionBar: flags=0x00000400
>         resource 0x7f070126 org.mozilla.firefox_beta:style/GeckoActionBar:
> <bag>
>         resource 0x7f070126 org.mozilla.firefox_beta:style/GeckoActionBar:
> <bag>
> 
> I bet we have the same issue as before.

GeckoActionBar is defined at

http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/resources/values-v11/styles.xml#79

as

79     <style name="GeckoActionBar" parent="@android:style/Widget.Holo.Light.ActionMode">
80         <item name="android:background">@drawable/ab_stacked_transparent_light_holo</item>
81     </style>

Widget.Holo.Light.ActionMode is defined at:

http://androidxref.com/4.4.4_r1/xref/frameworks/base/core/res/res/values/styles.xml?a=true&h=2309

A wrinkle: it looks like this is actually a v11 thing:

http://developer.android.com/reference/android/R.style.html#Widget_Holo_Light_ActionBar

Comment 10

[Richard Newman [:rnewman]]

https://developer.android.com/reference/android/R.style.html#TextAppearance_Holo_Widget_ActionBar_Title
= v13

mobile/android/base/resources/values-v11/styles.xml
83:    <style name="TextAppearance.Widget.ActionBar.Title" parent="@android:style/TextAppearance.Medium"/>
85:    <style name="GeckoActionBar.Title" parent="TextAppearance.Widget.ActionBar.Title">

mobile/android/base/resources/values-v13/styles.xml
13:    <style name="TextAppearance.Widget.ActionBar.Title" parent="@android:style/TextAppearance.Holo.Widget.ActionBar.Title"/>


which looks fine, but we definitely have a bug in Sync (v11 referring to a v13 thang):

mobile/android/base/resources/values-v11/sync_styles.xml
9:    <item name="android:textAppearance">@android:style/TextAppearance.Holo.Widget.ActionBar.Title</item>

Comment 11

[Brian Nicholson (:bnicholson)]

Attachment: Alphabetize theme styles

Simply reorders theme styles alphabetically.

Comment 12

[Brian Nicholson (:bnicholson)]

Attachment: Create GeckoAppBase as the parent for Gecko.App

Uses inheritance for Gecko.App to avoid some duplication. Creates GeckoAppBase as the parent for Gecko.App (similar to our GeckoBase/Gecko inheritance), where Gecko.App contains shared styles and GeckoAppBase can be overridden at each API level.

The third patch here will introduce a values-v14 where all of the values-v11 styles will be the same, except for two additional styles. That means these all of the values-v11 styles will still be duplicated in values-v14. We could be a more clever about this if we wanted to; for example, we could have GeckoAppBase be the shared set of styles (rather than Gecko.App), and the hierarchy could look something like this:

res/values/themes.xml:
    <style name="GeckoAppBase" parent="Gecko">
        <!-- all shared styles go here -->
    </style>
    <style name="Gecko.App" parent="GeckoAppBase">
        <!-- these will be overridden -->
    </style>

res/values-v11/themes.xml:
    <style name="GeckoAppBase.v11">
        <!-- all shared original and v11+ styles go here -->
    </style>
    <style name="Gecko.App" parent="GeckoAppBase.v11"/>

res/values-v14/themes.xml:
    <style name="GeckoAppBase.v11.v14">
        <!-- all shared original, v11+, and v14+ styles go here -->
    </style>
    <style name="Gecko.App" parent="GeckoAppBase.v14"/>

This would remove any style duplication, but I think it's inconsistent with how styles are normally structured. But I'd be fine with this inheritance model instead if you prefer it.

Comment 13

[Brian Nicholson (:bnicholson)]

Attachment: Add values-v14, removing v14-only styles from values-v11

Here's the actual fix. I was finally able to downgrade my GT-P6200 to 3.2, reproduced the crash, then narrowed down the broken styles. actionModeStyle and actionModeSelectAllDrawable are both v14+, so we need to move them out of v11. I can confirm that this patch fixes the crash.

Comment 14

[Brian Nicholson (:bnicholson)]

(In reply to Brian Nicholson (:bnicholson) from comment #12)
>     <style name="GeckoAppBase.v11">
>         <!-- all shared original and v11+ styles go here -->

This comment was confusing, so just to be clear: what I really meant was that only the v11 styles would go here, and the original styles would be inherited from GeckoAppBase. Same correction for GeckoAppBase.v11.v14: only the v14 styles would go there, and the original/v11 styles would be inherited.

Comment 16

[Lucas Rocha (:lucasr)]

Comment on attachment 8492849 [details] [diff] [review]
Alphabetize theme styles

Review of attachment 8492849 [details] [diff] [review]:
-----------------------------------------------------------------

OCD much? ;-)

Comment 17

[Lucas Rocha (:lucasr)]

Comment on attachment 8492852 [details] [diff] [review]
Add values-v14, removing v14-only styles from values-v11

Review of attachment 8492852 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.

Comment 18

[Brian Nicholson (:bnicholson)]

(In reply to Lucas Rocha (:lucasr) from comment #16)
> OCD much? ;-)

Heh, it helped find the duplicates for the other patches :D

https://hg.mozilla.org/integration/fx-team/rev/008e268fe555
https://hg.mozilla.org/integration/fx-team/rev/7b68abc42dbc
https://hg.mozilla.org/integration/fx-team/rev/6ae35824e143

Comment 19

[Brian Nicholson (:bnicholson)]

Marking affected versions -- we should get this uplifted.

Comment 20

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/008e268fe555
https://hg.mozilla.org/mozilla-central/rev/7b68abc42dbc
https://hg.mozilla.org/mozilla-central/rev/6ae35824e143

Comment 21

[Kevin Brosnan [:kbrosnan]]

[Tracking Requested - why for this release]: Patch available for common crash on two Samsung devices.

Comment 22

[Sylvestre Ledru [:Sylvestre]]

Brian, can we get uplift requests for aurora & beta? thanks

Comment 23

[Brian Nicholson (:bnicholson)]

Comment on attachment 8492849 [details] [diff] [review]
Alphabetize theme styles

Approval Request Comment
[Feature/regressing bug #]: N/A
[User impact if declined]: Honeycomb devices crash frequently.
[Describe test coverage new/current, TBPL]: No tests, but got my hands on crashing device and verified that crash is fixed.
[Risks and why]: Very low risk. We had v14 styles in our v11 folder, which is invalid. This fixes them by moving them into the v14 folder.
[String/UUID change made/needed]: None

Comment 24

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/fccc96852b49
https://hg.mozilla.org/releases/mozilla-aurora/rev/1d5fce93645d
https://hg.mozilla.org/releases/mozilla-aurora/rev/9fe5c195a2c8

https://hg.mozilla.org/releases/mozilla-beta/rev/f29b8812b6d0
https://hg.mozilla.org/releases/mozilla-beta/rev/112a9fe148d2
https://hg.mozilla.org/releases/mozilla-beta/rev/89d93cece9fd

Comment 26

[u279076]

Assuming verified fixed since there are 0 reports of this crash in Fennec 34/35/36 and 0 reports in Fennec 33.0 Beta following 33.0b7.