1067573 - [Browser][History] Browser history does not display when app is freshly launched.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Browser Chrome, defect)

Description

[Martin Shuman [:Marty]]

Attachment: logcat-Browser.txt

Description:
Opening the Browser app does not display any previous Browser history.  If the user navigates to any  web pages, opening a new instance of the Browser app will display the history, but if the user terminates all web pages and instances of the Browser app, reopening the app will once again not display any history.

Note: The browser app will not show the default Mozilla and Firefox OS links either.

Repro Steps:
1) Update a Flame device to BuildID: 20140915000203
2) Navigate to one or more web pages (google.com, twitter.com, etc.)
3) Close all browsers and web pages from the Task Manager
4) Reopen the Browser app.
  
Actual:
No Browser history is displayed on a fresh launch of the Browser app.
  
Expected: 
The Browser app displays browser history properly.
  
Environmental Variables:
Device: Flame 2.1
BuildID: 20140915000203
Gaia: 944e5b4582c4efa1b67cd33245dbb8f6aa25d09f
Gecko: 7546fedad918
Version: 34.0a2 (2.1)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0
  
Notes: This issue occurs on both 319MB and 512MB memory.
  
Repro frequency: 7/7
See attached: logcat, screenshot.

---------------------------------------------------------------------

This issue does NOT occur on Flame Master.
Browser history is displayed properly.

Environmental Variables:
Device: Flame 2.2 Master
BuildID: 20140915040203
Gaia: 855be6ade407c26e0596e7306a44deebc3f60933
Gecko: f27ff178807d
Version: 35.0a1 (2.2 Master)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0


---------------------------------------------------------------------

This issue does NOT occur on Friday's Flame 2.1.
Browser history is displayed properly.

Environmental Variables:
Device: Flame 2.1
BuildID: 20140912000203
Gaia: 7fe8807b384e1867fa4322f49a1310126fc5a849
Gecko: 1d4b0fc511dc
Version: 34.0a2 (2.1)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0


---------------------------------------------------------------------

This issue does NOT occur on Flame 2.0.
Browser history is displayed properly.

Environmental Variables:
Device: Flame 2.0
BuildID: 20140915000202
Gaia: 7edd3b0b9f65c3dde235c732d270e43e055a1254
Gecko: 13e04ab68621
Version: 32.0 (2.0)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 1

[Martin Shuman [:Marty]]

Attachment: Browser_History_Screenshot.png

Comment 2

[Peter Bylenga [:PBylenga]]

[Blocking Requested - why for this release]:
Regression of a core feature with high visibility (every time you launch browser).

Requesting a window.

Comment 3

[Candice Serran (:cserran)]

blocker justification: core functionality not working

Comment 4

[Adam Alldredge [:AdamA][Inactive]]

Aurora regression window:

Last working:
Device: Flame 2.1
BuildID: 20140912081053
Gaia: 59e5c2467b7b8219ed194a0d0a94c6ed59af95be
Gecko: b09d2857b74e
Version: 34.0a2 (2.1)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

First Broken:
Device: Flame 2.1
BuildID: 20140912095609
Gaia: d4de4123c678b198692af256254a26507e9c9a08
Gecko: 6f6cc4b975b0
Version: 34.0a2 (2.1)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Last working Gaia First Broken Gecko: Issue does NOT reproduce
Gaia: 59e5c2467b7b8219ed194a0d0a94c6ed59af95be
Gecko: 6f6cc4b975b0

First Broken Gaia Last working Gecko: Issue DOES reproduce
Gaia: d4de4123c678b198692af256254a26507e9c9a08
Gecko: b09d2857b74e

Pushlog:
https://github.com/mozilla-b2g/gaia/compare/59e5c2467b7b8219ed194a0d0a94c6ed59af95be...d4de4123c678b198692af256254a26507e9c9a08

Caused by Bug 1053261

Comment 5

[Joshua Mitchell (Inactive)]

Broken by Bug 1053261?

Comment 6

[Dale Harvey (:daleharvey)]

Ok, one of the shared functions used in the top sites hasnt been upflifted to 2.1 https://bugzilla.mozilla.org/show_bug.cgi?id=990047, will flag that for blocking

Comment 7

[Dale Harvey (:daleharvey)]

Attachment: https://github.com/mozilla-b2g/gaia/pull/24223

Comment 8

[Kevin Grandon :kgrandon]

Comment on attachment 8492199 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/24223

Looks good, thanks!

Comment 9

[Kevin Grandon :kgrandon]

Test landed to master here: https://github.com/mozilla-b2g/gaia/commit/7d538e0b930eab9a49e83c27478f6d65efec91ae

We should be able to uplift this to 2.1 with a=testonly if we wanted to.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Deal.

v2.1: https://github.com/mozilla-b2g/gaia/commit/3742913e11f69e789dcb0aa0dedf2e5572da0129

Comment 11

[Brogan Zumwalt [Inactive]]

Issue verified as fixed on Flame 2.1 and Flame 2.2

Device: Flame 2.1 KK (319mb) (Full Flash)
BuildID: 20141011000201
Gaia: f5d4ff60ffed8961f7d0380ada9d0facfdfd56b1
Gecko: d813d79d3eae
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 34.0a2 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Device: Flame 2.2 Master KK (319mb) (Full Flash)
BuildID: 20141011040204
Gaia: 95f580a1522ffd0f09302372b78200dab9b6f322
Gecko: 3f6a51950eb5
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 35.0a1 (2.2 Master)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Browsing history and top sites appear on all browser launches