1067841 - Music app functional issues - Navigation

Status: RESOLVED DUPLICATE of bug 1043712

(Firefox OS Graveyard :: Gaia::Music, defect)

Description

[Pooja]

We are observing few issues in Music app. Wants to confirm whether these are issue or FFOS implementation design.

Issue#1:Navigating to Music Menu/songs list when doing next operation on last clip of the list
Description:  when doing next next  till end of the songs list then navigating to music menu instead of first clip of the list
--------------
 
Issue#2: "Shuffle" and "repeat single song" both can be enabled at same time
Description: At a time either "Shuffle" or "repeat single song"  should be available.
--------------
 
Issue#3: Playback pauses at the end of the clip before starting of next clip
Description: here the playback pauses(UI pauses) at the end of the each clip before starting next clip

Comment 1

[Pooja]

[Blocking Requested - why for this release]:

Comment 2

[Pooja]

Any update on this?

Comment 3

[Jason Smith [:jsmith]]

Pooja - Can you split each issue out into separate bugs? That will allow us to diagnose each issue separately here.

Comment 4

[bhargavg1]

(In reply to Jason Smith [:jsmith] from comment #3)
> Pooja - Can you split each issue out into separate bugs? That will allow us
> to diagnose each issue separately here.

Cloned the following bugs for 

#2 - Bug 1068863 - Music app functional issues
#3 - Bug 1068865 - Music app functional issues

Comment 5

[Jason Smith [:jsmith]]

QA Wanted to see if this reproduces on Flame KK 2.1

Note - this bug is focusing on issue #1 in comment 0.

Comment 6

[Jim Porter (:squib)]

Comment 0 isn't very clear to me. Could you elaborate? This could be the issue I've seen before where tapping on "next track" when you're on the last track ends up registering as two taps: one to close the player, and one to select the "all songs" view, meaning that instead of returning to, say, the tiles view, you end up in the all songs view.

I doubt this is a blocker though, since it's been around for a few versions. But it'd be good to fix.

(Or maybe this is talking about a different issue?)

Comment 7

[Hema Koka [:hema]]

Not blocking release based on triage on 9/17

Adding to priority bug list though. Hub, lets look into fixing this in master (Issue #1) 

Thanks
Hema

Comment 8

[Pooja]

(In reply to Jim Porter (:squib) from comment #6)
> Comment 0 isn't very clear to me. Could you elaborate? 

Hi Jim,

Suppose of you have 3 songs in your Music folder
1. Open App ->Songs Menu
2. Play first song
3. Tap on "Next"
4. It will start playing 2nd song
5. Tap on "Next"
6. It will start playing 3rd song
7. Tap on "Next"

Actual result:
 Its Navigated to Songs Menu
Expected:
  It should start playing first song i.e we should be again back on Step#2

Comment 9

[Jim Porter (:squib)]

(In reply to Pooja from comment #8)
> Expected:
>   It should start playing first song i.e we should be again back on Step#2

No it shouldn't. If you don't have repeat on, once you hit the end of the album, the playlist is over and it should stop playing. If you'd like it to go back to the beginning of the album after you hit the end, turn on repeat; I tested this out and it works fine.

Comment 10

[Hubert Figuiere [:hub]]

Jacqueline, please see comment 8 and comment 9. I agree with :squib in comment 9 though. Do you have a definitive UX answer?

Thank you kindly.

Comment 11

[Jacqueline Savory [:jsavory] UX]

Yes, I agree with Jim as well. Once the user reaches the end of an album/playlist etc., the next button should have no action and should display a disabled state. 

The user should definitely not be brought to the song page and if they want to return to the beginning of the album/playlist they would need to turn on repeat all and then tap next.

Comment 12

[Hubert Figuiere [:hub]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/24191

Comment 13

[Hubert Figuiere [:hub]]

Comment on attachment 8491598 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/24191

Let's get Jim to review.

Comment 14

[Jim Porter (:squib)]

(In reply to jsavory from comment #11)
> Yes, I agree with Jim as well. Once the user reaches the end of an
> album/playlist etc., the next button should have no action and should
> display a disabled state. 

I disagree with this part. Currently, hitting next until you fall off the end of the playlist is the only way of actually stopping (not just pausing) the music, except for killing the music app entirely. This is useful since it closes out the "now playing" notification in the utility tray and lockscreen.

I'd be sad to see this go away unless we come up with another way of really stopping playback (long-press on the pause button?).

Comment 15

[Jacqueline Savory [:jsavory] UX]

After discussing this with Jim, we agreed that it would be best if when the next button is pressed during the last song of the song list, it will instead return the user to the previous screen, instead of disabling.

Comment 16

[Jim Porter (:squib)]

I think that makes this a dup of bug 1043712.

Comment 18

[Hubert Figuiere [:hub]]

Comment on attachment 8491598 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/24191

Cancelling review.