1069376 - Using SeaMonkey cannot expand developer's comments and version sections

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Code Quality, defect, P1)

Description

[Philip Chee]

STR:
1. Install a SeaMonkey nightly build (or build it yourself)
2. Visit addons.mozilla.org
3. Visit an extension or theme page e.g.
https://addons.mozilla.org/en-us/seamonkey/addon/reminderfox/?src=hp-dl-featured
4. Notice that the Developer's Comments section and the Versions section cannot be expanded. Also no review comments show.

Comment 1

[Jorge Villalobos [:jorgev] (he/him)]

Is this problem only happening on nightly builds? I tried with release and didn't see any problems.

Are there any errors in the console?

Comment 2

[Philip Chee]

(In reply to Jorge Villalobos [:jorgev] from comment #1)
> Is this problem only happening on nightly builds? I tried with release and
> didn't see any problems.

Happens with SeaMonkey nightly builds AND Thunderbird daily builds.

STR for Thunderbird:

1. Go Tools->Add-ons
2. Select Get Addons tab
3. Pick any addon and click on Learn more button
4. New content tab opens e.g  Simple Locale Switcher 0.8.3

> 
> Are there any errors in the console?

Sat Sep 27 2014 23:42:57
Error: TypeError: $(...).installButton is not a function
Source file: https://addons.cdn.mozilla.net/static/js/impala-min.js?build=16ac44a-54257430
Line: 1
 ----------
Sat Sep 27 2014 23:42:57
Error: TypeError: z.button is undefined
Source file: https://addons.mozilla.org/en-US/firefox/addons/buttons.js?b=16ac44a-54257430
Line: 14
 ----------
Sat Sep 27 2014 23:42:57
Error: www.paypalobjects.com : server does not support RFC 5746, see CVE-2009-3555

Comment 3

[Kris Maglione [:kmag]]

The problem seems to be this line in capabilities.js:

    'webApps': !!(navigator.mozApps && navigator.mozApps.install),

We shouldn't even need that capability check anymore. Let's just remove it.

Comment 4

[Kris Maglione [:kmag]]

(the same goes for the other mozApps property checks in the same file, of course)

Comment 5

[David Larlet [:davidbgk]]

Please add a target milestone on critical bugs given that we use that filter to know which bugs we should work on that month.

Comment 6

[David Larlet [:davidbgk]]

I tried to fix this in https://github.com/mozilla/olympia/pull/317 by removing all webApps/app_runtime references and logic but I don't know how to test that i.e. make my Thunderbird opening a local URL instead of directly the AMO prod.

Comment 7

[Kris Maglione [:kmag]]

It looks like the only easy way to test this on Thunderbird is to open about:config (Tools > Options > Advanced > Config Editor) and change the 'extensions.webservice.discoverURL' preference to the exact URL you want to visit, and then open the add-ons manager.

Unfortunately, the URL filter is hard coded to 'addons.mozilla.org' in Thunderbird, so you won't be able to open any links in Thunderbird.

Comment 8

[Mathieu Agopian [:magopian]]

I tried to reproduce this issue on thunderbird, but:
1/ it only seems to happens on the very first click on the "read more" link for an extension, and it also happens with the latest public version 31.1.2
2/ i wasn't able to replay this locally by modifying the discoverURL

Regarding 2/, you are right Kris, when I click on a link, it opens it in firefox, and there's no issue. I thus don't know how to validate that the fix is working.

Comment 9

[Mathieu Agopian [:magopian]]

Thanks to someone from #thunderbird, I could reproduce this issue locally after installing and using the following extension: https://addons.mozilla.org/en-US/thunderbird/addon/webapp-tabs/?src=search

Comment 10

[Mathieu Agopian [:magopian]]

Testing on Thunderbird 31.1.2, with and without the changes from the PR.

The only error I can see atm is on line 204 of zamboni/button.js.

It seems it's the ("InstallTrigger" in window) test that raises: NS_ERROR_FACTORY_NOT_REGISTERED.

I can't find why this is happening (it looks more like a thunderbird issue?), and if I remove this check, then the page seems to load everytime perfectly.

Any clue who I should NI for more information on that?

Comment 11

[Mathieu Agopian [:magopian]]

After some more investigation and some help from :irving on #thunderbird, it seems this is because of https://bugzilla.mozilla.org/show_bug.cgi?id=1081190

I've updated the PR to "try/catch" around this statement, as a workaround.

Comment 12

[Mathieu Agopian [:magopian]]

Oh, sorry, didn't mean to NI :irving.

Comment 13

[David Larlet [:davidbgk]]

https://github.com/mozilla/olympia/commit/964f166c9608fad3c313994f23ece2e9c4a6268b

Comment 14

[Philip Chee]

Confirmed fixed using:
User agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:36.0) Gecko/20100101 Firefox/36.0 SeaMonkey/2.33a1
Build identifier: 20141024233150

Thanks everyone!